https://bugzilla.redhat.com/show_bug.cgi?id=979792
Bug ID: 979792 Summary: Review Request: perl-Storm - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cickumqt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://cicku.me/perl-Storm.spec SRPM URL: http://cicku.me/perl-Storm-0.240-1.fc20.src.rpm Description: Storm is a Moose based library for storing and retrieving objects over a DBI connection. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: perl-Storm |Review Request: perl-Storm |- <short summary here> |- Object-relational mapping
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tdabasin@redhat.com Assignee|nobody@fedoraproject.org |tdabasin@redhat.com Flags| |fedora-review?
--- Comment #1 from Tomas Dabašinskas tdabasin@redhat.com --- Taking up the review
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|tdabasin@redhat.com |nobody@fedoraproject.org Flags|fedora-review? |
--- Comment #2 from Tomas Dabašinskas tdabasin@redhat.com --- As per Christopher's email, there's a reviewer for this package already.
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
--- Comment #3 from Parag AN(पराग) panemade@gmail.com --- hmm the srpm is not downloading....
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=979792
--- Comment #4 from Christopher Meng cickumqt@gmail.com --- You can try again now..
There might have some issues in Requires tag, please be patient...
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- Thanks for the heads up.
Review: + mock build for f20 is successful
+ rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ Source verified with upstream as (sha256sum) srpm tarball : 0f7d79f6d732569d934d4592dc06c2d3487173ece608208dc0886967bc6807d5 upstream tarball : 0f7d79f6d732569d934d4592dc06c2d3487173ece608208dc0886967bc6807d5
+ license is valid "Artistic 2.0" and included in some source files as well as in LICENSE file.
+ make test gave All tests successful. Files=43, Tests=103, 30 wallclock secs ( 0.19 usr 0.05 sys + 28.70 cusr 0.85 csys = 29.79 CPU)
+ Package perl-Storm-0.240-1.fc20.noarch -> Provides: perl(Moose::Meta::Attribute::Custom::Trait::AutoIncrement) = 0.240 perl(Moose::Meta::Attribute::Custom::Trait::ForeignKey) = 0.240 perl(Moose::Meta::Attribute::Custom::Trait::NoStorm) = 0.240 perl(Moose::Meta::Attribute::Custom::Trait::PrimaryKey) = 0.240 perl(Moose::Meta::Attribute::Custom::Trait::StormArray) = 0.240 perl(Moose::Meta::Class::Custom::Trait::AutoTable) = 0.240 perl(Storm) = 0.240 perl(Storm::Aeolus) = 0.240 perl(Storm::Flood) = 0.240 perl(Storm::Flood::Plan) = 0.240 perl(Storm::LiveObjects) = 0.240 perl(Storm::LiveObjects::Scope) = 0.240 perl(Storm::Meta::Attribute::Trait::AutoIncrement) = 0.240 perl(Storm::Meta::Attribute::Trait::ForeignKey) = 0.240 perl(Storm::Meta::Attribute::Trait::NoStorm) = 0.240 perl(Storm::Meta::Attribute::Trait::PrimaryKey) = 0.240 perl(Storm::Meta::Attribute::Trait::StormArray) = 0.240 perl(Storm::Meta::Class::Trait::AutoTable) = 0.240 perl(Storm::Meta::Column) = 0.240 perl(Storm::Meta::Relationship) = 0.240 perl(Storm::Meta::Relationship::ManyToMany) = 0.240 perl(Storm::Meta::Relationship::OneToMany) = 0.240 perl(Storm::Meta::Table) = 0.240 perl(Storm::Model) = 0.240 perl(Storm::Object) = 0.240 perl(Storm::Policy) = 0.240 perl(Storm::Policy::Object) = 0.240 perl(Storm::Query::Delete) = 0.240 perl(Storm::Query::DeleteWhere) = 0.240 perl(Storm::Query::Insert) = 0.240 perl(Storm::Query::Lookup) = 0.240 perl(Storm::Query::Refresh) = 0.240 perl(Storm::Query::Select) = 0.240 perl(Storm::Query::Select::Iterator) = 0.240 perl(Storm::Query::Update) = 0.240 perl(Storm::Role) = 0.240 perl(Storm::Role::CanDeflate) = 0.240 perl(Storm::Role::CanInflate) = 0.240 perl(Storm::Role::Iterator) = 0.240 perl(Storm::Role::Model) = 0.240 perl(Storm::Role::Model::Meta::Class) = 0.240 perl(Storm::Role::Object) = 0.240 perl(Storm::Role::Object::Meta::Attribute) = 0.240 perl(Storm::Role::Object::Meta::Class) = 0.240 perl(Storm::Role::Query) = 0.240 perl(Storm::Role::Query::CanParseUserArgs) = 0.240 perl(Storm::Role::Query::HasAttributeMap) = 0.240 perl(Storm::Role::Query::HasAttributeOrder) = 0.240 perl(Storm::Role::Query::HasBindParams) = 0.240 perl(Storm::Role::Query::HasLimitClause) = 0.240 perl(Storm::Role::Query::HasOrderByClause) = 0.240 perl(Storm::Role::Query::HasSQLFunctions) = 0.240 perl(Storm::Role::Query::HasWhereClause) = 0.240 perl(Storm::Role::Query::IsExecutable) = 0.240 perl(Storm::SQL::Column) = 0.240 perl(Storm::SQL::Fragment::Limit) = 0.240 perl(Storm::SQL::Fragment::OrderBy) = 0.240 perl(Storm::SQL::Fragment::Where::Boolean) = 0.240 perl(Storm::SQL::Fragment::Where::Comparison) = 0.240 perl(Storm::SQL::Fragment::Where::SubgroupEnd) = 0.240 perl(Storm::SQL::Fragment::Where::SubgroupStart) = 0.240 perl(Storm::SQL::Function) = 0.240 perl(Storm::SQL::Literal) = 0.240 perl(Storm::SQL::Parameter) = 0.240 perl(Storm::SQL::Placeholder) = 0.240 perl(Storm::Source) = 0.240 perl(Storm::Test::Types) = 0.240 perl(Storm::Transaction) = 0.240 perl(Storm::Types) = 0.240 perl-Storm = 0.240-1.fc20
Requires: perl(Carp) perl(DBI) perl(DateTime::Format::MySQL) perl(Devel::GlobalDestruction) perl(Moose) perl(Moose::Exporter) perl(Moose::Role) perl(Moose::Util::MetaRole) perl(Moose::Util::TypeConstraints) perl(MooseX::SemiAffordanceAccessor) perl(MooseX::StrictConstructor) perl(MooseX::Types) perl(MooseX::Types::Moose) perl(Scalar::Util) perl(Storm::Aeolus) perl(Storm::LiveObjects) perl(Storm::LiveObjects::Scope) perl(Storm::Meta::Attribute::Trait::AutoIncrement) perl(Storm::Meta::Attribute::Trait::ForeignKey) perl(Storm::Meta::Attribute::Trait::NoStorm) perl(Storm::Meta::Attribute::Trait::PrimaryKey) perl(Storm::Meta::Attribute::Trait::StormArray) perl(Storm::Meta::Class::Trait::AutoTable) perl(Storm::Meta::Column) perl(Storm::Meta::Relationship::ManyToMany) perl(Storm::Meta::Relationship::OneToMany) perl(Storm::Meta::Table) perl(Storm::Policy) perl(Storm::Policy::Object) perl(Storm::Query::Delete) perl(Storm::Query::DeleteWhere) perl(Storm::Query::Insert) perl(Storm::Query::Lookup) perl(Storm::Query::Refresh) perl(Storm::Query::Select) perl(Storm::Query::Select::Iterator) perl(Storm::Query::Update) perl(Storm::Role::Object) perl(Storm::Role::Object::Meta::Attribute) perl(Storm::Role::Object::Meta::Class) perl(Storm::SQL::Column) perl(Storm::SQL::Fragment::Limit) perl(Storm::SQL::Fragment::OrderBy) perl(Storm::SQL::Fragment::Where::Boolean) perl(Storm::SQL::Fragment::Where::Comparison) perl(Storm::SQL::Fragment::Where::SubgroupEnd) perl(Storm::SQL::Fragment::Where::SubgroupStart) perl(Storm::SQL::Function) perl(Storm::SQL::Literal) perl(Storm::SQL::Parameter) perl(Storm::SQL::Placeholder) perl(Storm::Source) perl(Storm::Transaction) perl(Storm::Types) perl(Sub::Exporter) perl(namespace::clean) perl(strict) perl(warnings)
suggestions: 1) you can remove Requires: dependencies as rpm usually generate these automatically.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Christopher Meng cickumqt@gmail.com --- New Package SCM Request ======================= Package Name: perl-Storm Short Description: Object-relational mapping Owners: cicku Branches: f18 f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=979792
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=979792
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Storm-0.240-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Storm-0.240-1.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=979792
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Storm-0.240-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Storm-0.240-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Storm-0.240-1.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Storm-0.240-1.fc18 Resolution|--- |ERRATA Last Closed| |2013-08-01 23:33:48
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Storm-0.240-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=979792
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Storm-0.240-1.fc18 |perl-Storm-0.240-1.fc19
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Storm-0.240-1.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org