[Bug 1016476] New: Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

Bug ID: 1016476
           Summary: Review Request: spring-retry - Abstraction around
                    retrying failed operations
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL: http://msrb.fedorapeople.org/review/spring-retry.spec
SRPM URL: http://msrb.fedorapeople.org/review/spring-retry-1.0.2-1.fc21.src.rpm
Description: Spring Retry provides an abstraction around retrying failed
operations,
with an emphasis on declarative control of the process and policy-based
bahaviour that is easy to extend and customize. For instance, you can
configure a plain POJO operation to retry if it fails, based on the type
of exception, and with a fixed or exponential backoff.
Fedora Account System Username: msrb

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

Michal Srb  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |652183 (FE-JAVASIG)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from gil cattaneo  ---
i would like to take this review

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

--- Comment #2 from gil cattaneo  ---
hi
org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu)
aspectjweaver package, if you want run same tests
regards

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

--- Comment #3 from gil cattaneo  ---
Created attachment 809378
  --> https://bugzilla.redhat.com/attachment.cgi?id=809378&action=edit
review notes

NON blocking issues

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

please, contact upstream to include a license copy

[?]: If tests are skipped during package build explain why it was needed in a
     comment
     Note: Tests seem to be skipped. Verify there is a commment giving a
     reason for this
see previous comment
approved

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

--- Comment #4 from Michal Srb  ---
(In reply to gil cattaneo from comment #2)
> hi
> org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu)
> aspectjweaver package, if you want run same tests
> regards

Thanks for the info. Package aspectjweaver in Fedora only provides
org.aspectj:aspectjweaver. Maybe only alias is missing. I will check if it
works with spring-retry.

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

--- Comment #5 from gil cattaneo  ---
can you add also OSGi manifest?
%pom_add_plugin org.apache.felix:maven-bundle-plugin . '
<extensions>true</extensions>
<configuration>
  <instructions>
    <Bundle-SymbolicName>org.springframework.retry</Bundle-SymbolicName>
    <Bundle-Name>${project.name}</Bundle-Name>
    <Bundle-Vendor>SpringSource</Bundle-Vendor>
    <Bundle-Version>${project.version}</Bundle-Version>
  </instructions>
</configuration>
<executions>
  <execution>
    <id>bundle-manifest</id>
    <phase>process-classes</phase>
    <goals>
      <goal>manifest</goal>
    </goals>
  </execution>
</executions>'

or <Bundle-Vendor>${project.organization.name}</Bundle-Vendor>
if project.organization.name is equal to SpringSource
regards

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

Michal Srb  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #6 from Michal Srb  ---
No problem, I will add OSGi metadata. I have also opened pull request for
adding ASL 2.0 license text and tests are enabled now.

New Package SCM Request
=======================
Package Name: spring-retry
Short Description: Abstraction around retrying failed operations
Owners: msrb sochotni mizdebsk msimacek
Branches: f20
InitialCC: java-sig

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

Michal Srb  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2013-10-16 09:23:50

--- Comment #8 from Michal Srb  ---
Thanks for the review and the repo. The package is now available in Rawhide.

[Bug 1016476] Review Request: spring-retry - Abstraction around retrying failed operations

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016476

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|652183 (FE-JAVASIG)         |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug