[Bug 2309684] New: Review Request: betterfetch - A simple fetch script that gets the system info quickly
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
Bug ID: 2309684 Summary: Review Request: betterfetch - A simple fetch script that gets the system info quickly Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: gq2ic3wbe@mozmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spe... SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.5... Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch) Fedora Account System Username: sctech
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
--- Comment #1 from gq2ic3wbe@mozmail.com --- Here is the finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.5/betterfetch-1... Also, this is my package and I need a sponsor. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
--- Comment #2 from gq2ic3wbe@mozmail.com --- betterfetch updated to 1.7. SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.7... Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spe... Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch) Fedora Account System Username: sctech Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.7/betterfetch-1...
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
gq2ic3wbe@mozmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |betterfetch
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl Doc Type|--- |If docs needed, set a value
--- Comment #3 from Artur Frenszek-Iwicki fedora@svgames.pl ---
Source0: %{name}-%{version}.tar.gz
This should be a downloadable URL. Since the project is hosted on GitHub, you can use:
URL: https://github.com/sctech-tr/betterfetch Source0: %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
%files /usr/bin/betterfetch /usr/bin/betterfetchrc /etc/betterfetchrc /etc/betterfetch-version
Don't hardcode these paths. Replace /usr/bin with the %{_bindir} macro and /etc/ with the %{_sysconfdir} macro. This should be done in both the %files and %install sections. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_...
Also, please include the license text. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
--- Comment #4 from gq2ic3wbe@mozmail.com --- I'll have a look at them tomorrow, thanks for pointing out!
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
--- Comment #5 from gq2ic3wbe@mozmail.com --- I think I corrected them. (I also uploaded it to COPR) SRPM URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch-1.8... Spec URL: https://raw.githubusercontent.com/sctech-tr/betterfetch/main/betterfetch.spe... Description: betterfetch is a fetch script used to quickly show system information in terminal. it's a fork of zfetch (https://github.com/emilydaemon/zfetch) Fedora Account System Username: sctech Finished RPM: https://github.com/sctech-tr/betterfetch/releases/download/1.8/betterfetch-1...
Product: Fedora Version: rawhide Component: Package Review
gq2ic3wbe@mozmail.com has denied Package Review package-review@lists.fedoraproject.org's request for gq2ic3wbe@mozmail.com's needinfo: Bug 2309684: Review Request: betterfetch - A simple fetch script that gets the system info quickly https://bugzilla.redhat.com/show_bug.cgi?id=2309684
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
gq2ic3wbe@mozmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gq2ic3wbe@mozmail |needinfo- |.com) |
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer.
If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it.
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2309684
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/sctech-t | |r/betterfetch
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9819691 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/betterfetch/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com