[Bug 2053969] New: Review Request: golang-github-gopasspw-gopass - The slightly more awesome standard unix password manager for teams
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Bug ID: 2053969 Summary: Review Request: golang-github-gopasspw-gopass - The slightly more awesome standard unix password manager for teams Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: me@fale.io QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fale.fedorapeople.org/golang-github-gopasspw-gopass/golang-github-go... SRPM URL: https://fale.fedorapeople.org/golang-github-gopasspw-gopass/golang-github-go... Description: The slightly more awesome standard unix password manager for teams COPR build: http://copr.fedorainfracloud.org/coprs/fale/gopass/build/3486927/ Fedora Account System Username: fale
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2053960, 2053961, 2053962, | |2053963, 2053964, 2053965, | |2053966, 2053968 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2053960 [Bug 2053960] Review Request: golang-github-gokyle-twofactor - Two-factor authentication. https://bugzilla.redhat.com/show_bug.cgi?id=2053961 [Bug 2053961] Review Request: golang-github-gopasspw-pinentry - Pinentry client in Go https://bugzilla.redhat.com/show_bug.cgi?id=2053962 [Bug 2053962] Review Request: golang-github-jsimonetti-pwscheme - Golang packages defining different password schemes https://bugzilla.redhat.com/show_bug.cgi?id=2053963 [Bug 2053963] Review Request: golang-github-martinhoefling-goxkcdpwgen - Xkcd style password generator library and cli tool https://bugzilla.redhat.com/show_bug.cgi?id=2053964 [Bug 2053964] Review Request: golang-github-skip2-qrcode - QR Code encoder https://bugzilla.redhat.com/show_bug.cgi?id=2053965 [Bug 2053965] Review Request: golang-github-mitchellh-ps - Find, list, and inspect processes from Go https://bugzilla.redhat.com/show_bug.cgi?id=2053966 [Bug 2053966] Review Request: golang-github-caspr-io-yamlpath - Golang YAML Path implementation https://bugzilla.redhat.com/show_bug.cgi?id=2053968 [Bug 2053968] Review Request: golang-github-schollz-closestmatch - Golang library for fuzzy matching within a set of strings
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053960, which changed state.
Bug 2053960 Summary: Review Request: golang-github-gokyle-twofactor - Two-factor authentication. https://bugzilla.redhat.com/show_bug.cgi?id=2053960
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053962, which changed state.
Bug 2053962 Summary: Review Request: golang-github-jsimonetti-pwscheme - Golang packages defining different password schemes https://bugzilla.redhat.com/show_bug.cgi?id=2053962
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #1 from Mikel Olasagasti Uranga mikel@olasagasti.info --- As gopass is a known app, it makes sense to rename golang-github-gopasspw-gopass.spec to gopass.spec, as done with doctl for example. You'll need to rename the BZ title accordingly.
- Define "%global goname gopass" as in https://src.fedoraproject.org/rpms/doctl/blob/rawhide/f/doctl.spec#_15
for cmd in helpers/postrel pkg/pwgen/pwrules helpers/man helpers/changelog helpers/release; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done
These are not required for gopass usage, can be removed.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #2 from Fabio Alessandro Locati me@fale.io --- Hi Mikel,
Looking doctl, I notice that the "master" package is also named that way. Should I close this request and create a new one with the right name as well?
Thanks a lot, Fale
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
Should I close this request and create a new one with the right name as well?
You can just rename the BZ title and upload a new spec/srpm with the new name for review.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: gopass - |golang-github-gopasspw-gopa |The slightly more awesome |ss - The slightly more |standard unix password |awesome standard unix |manager for teams |password manager for teams |
--- Comment #4 from Fabio Alessandro Locati me@fale.io --- SPEC: https://fale.fedorapeople.org/gopass/gopass.spec SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm Copr: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3725247/
Thanks a lot!!
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2035289
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2035289 [Bug 2035289] Review Request: golang-github-mitchellh-ps - go-ps
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053965, which changed state.
Bug 2053965 Summary: Review Request: golang-github-mitchellh-ps - Find, list, and inspect processes from Go https://bugzilla.redhat.com/show_bug.cgi?id=2053965
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- As mentioned, the auxiliary commands are not required for gopass (not packaged in the official binary release for example), so unless you've a good reason they can be dropped. You should remove this parts of the spec:
%build %gobuild -o %{gobuilddir}/bin/gopass %{goipath} for cmd in helpers/postrel pkg/pwgen/pwrules helpers/man helpers/changelog helpers/release; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done
(...)
install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
(...)
%files %license LICENSE %doc docs CONTRIBUTING.md GOVERNANCE.md README.md ARCHITECTURE.md CHANGELOG.md %{_bindir}/*
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #6 from Fabio Alessandro Locati me@fale.io --- Sorry for that, I made a little bit of mess on my filesystem while renaming files and folders.
SPEC: https://fale.fedorapeople.org/gopass/gopass.spec SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3730796/
Thanks a lot Mikel for your suggestions and patience :-)
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #7 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Sorry, my previous comment was not correct, as you still need gopass binary of course. Anyhow, you did the correct thing, sorry again about that.
I just realized that check section is being ignored, you should use `%bcond_without check`
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #8 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I did some changes and upload a new spec here: https://mikel.olasagasti.info/tmp/fedora/gopass.spec
- Enable tests - Add BuildRequires for tests - Add Requires - Generate bash/fish/zsh completions. For some reason bash ones seem not to work - Test TestFind fails, I added a skip for it - Other tests, internal/backend/storage/fs/link_test.go pkg/appdir/appdir_xdg_test.go pkg/pwgen/validate_test.go pkg/termio/identity_test.go, fail with the following error, but I was not able to trace it correctly:
code in directory /usr/share/gocode/src/gotest.tools/assert expects import "gotest.tools/v3/assert"
Check these changes and adapt them to your spec.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #9 from Fabio Alessandro Locati me@fale.io --- No problem and a huge thankyou for your SPEC file which allowed me to greatly improve the tests and SH completion :-).
SPEC: https://fale.fedorapeople.org/gopass/gopass.spec SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3734378/
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #10 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
Requires: git Requires: gnupg BuildRequires: git-core BuildRequires: gnupg2
I would use the same Requires as in BuildRequires.
#rm internal/backend/storage/fs/link_test.go pkg/appdir/appdir_xdg_test.go pkg/pwgen/validate_test.go pkg/termio/identity_test.go
Remove this leftover.
After these changes I think package can be approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #11 from Fabio Alessandro Locati me@fale.io --- Hi!
SPEC: https://fale.fedorapeople.org/gopass/gopass.spec SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3736098/
Thanks a lot :-)
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #12 from Mikel Olasagasti Uranga mikel@olasagasti.info --- go2rpm package with some extras, fedora-review is correct:
- The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines
Package approved! On import, don't forget to do the following:
- Add package to release-monitoring.org - Add package to Koschei - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #13 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gopass
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fabio Alessandro Locati me@fale.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2065054
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2065054 [Bug 2065054] Build for F36 and rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053966, which changed state.
Bug 2053966 Summary: Review Request: golang-github-caspr-io-yamlpath - Golang YAML Path implementation https://bugzilla.redhat.com/show_bug.cgi?id=2053966
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053961, which changed state.
Bug 2053961 Summary: Review Request: golang-github-gopasspw-pinentry - Pinentry client in Go https://bugzilla.redhat.com/show_bug.cgi?id=2053961
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053964, which changed state.
Bug 2053964 Summary: Review Request: golang-github-skip2-qrcode - QR Code encoder https://bugzilla.redhat.com/show_bug.cgi?id=2053964
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053968, which changed state.
Bug 2053968 Summary: Review Request: golang-github-schollz-closestmatch - Golang library for fuzzy matching within a set of strings https://bugzilla.redhat.com/show_bug.cgi?id=2053968
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2053963, which changed state.
Bug 2053963 Summary: Review Request: golang-github-martinhoefling-goxkcdpwgen - Xkcd style password generator library and cli tool https://bugzilla.redhat.com/show_bug.cgi?id=2053963
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4506cf983b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4506cf983b
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9036145a7b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9036145a7b
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4506cf983b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4506cf983b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4506cf983b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9036145a7b has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9036145a7b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9036145a7b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2053969 Bug 2053969 depends on bug 2065054, which changed state.
Bug 2065054 Summary: Build for F36 and rawhide https://bugzilla.redhat.com/show_bug.cgi?id=2065054
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2053969
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-04-07 15:26:02
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-4506cf983b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com