[Bug 2168110] New: Review Request: php-phpunit-php-code-coverage10 - PHP code coverage information
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Bug ID: 2168110 Summary: Review Request: php-phpunit-php-code-coverage10 - PHP code coverage information Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.0.0-1.rem... Description: Library that provides collection, processing, and rendering functionality for PHP code coverage information.
Fedora Account System Username: remi
--
for phpunit10
previous reviews: bug #1420374 for php-phpunit-php-code-coverage5 bug #1541343 for php-phpunit-php-code-coverage6 bug #1671663 for php-phpunit-php-code-coverage7 bug #1800790 for php-phpunit-php-code-coverage8 bug #1867898 for php-phpunit-php-code-coverage9
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2168090, 2167807, 2168094, | |2167799, 2167791, 2167804, | |2167782
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2167782 [Bug 2167782] Review Request: php-sebastian-version4 - Managing the version number of Git-hosted PHP projects, version 4 https://bugzilla.redhat.com/show_bug.cgi?id=2167791 [Bug 2167791] Review Request: php-sebastian-environment6 - Handle HHVM/PHP environments, version 6 https://bugzilla.redhat.com/show_bug.cgi?id=2167799 [Bug 2167799] Review Request: php-sebastian-complexity3 - Calculating the complexity of PHP code units https://bugzilla.redhat.com/show_bug.cgi?id=2167804 [Bug 2167804] Review Request: php-sebastian-lines-of-code2 - Counting the lines of code in PHP source code https://bugzilla.redhat.com/show_bug.cgi?id=2167807 [Bug 2167807] Review Request: php-phpunit-php-text-template3 - Simple template engine, version 3 https://bugzilla.redhat.com/show_bug.cgi?id=2168090 [Bug 2168090] Review Request: php-phpunit-php-file-iterator4 - FilterIterator implementation based on a list of suffixes, version 4 https://bugzilla.redhat.com/show_bug.cgi?id=2168094 [Bug 2168094] Review Request: php-sebastian-code-unit-reverse-lookup3 - Looks up which function or method a line of code belongs to, version 3
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2168112
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2168112 [Bug 2168112] Review Request: phpunit10 - The PHP Unit Testing framework version 10
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Updated to 10.0.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.0.1-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/%%7Bgh_ven | |dor}/%{gh_project}
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5578993 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Updated to 10.0.2
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.0.2-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #4 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1948367 --> https://bugzilla.redhat.com/attachment.cgi?id=1948367&action=edit The .spec file difference from Copr build 5578993 to 5598203
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5598203 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Updated to 10.1.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.0-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #7 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1957341 --> https://bugzilla.redhat.com/attachment.cgi?id=1957341&action=edit The .spec file difference from Copr build 5598203 to 5778366
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #8 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5778366 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #9 from Remi Collet fedora@famillecollet.com --- Updated to 10.1.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.1-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1958233 --> https://bugzilla.redhat.com/attachment.cgi?id=1958233&action=edit The .spec file difference from Copr build 5778366 to 5804624
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5804624 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #12 from Remi Collet fedora@famillecollet.com --- Updated to 10.1.2
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.2-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1966582 --> https://bugzilla.redhat.com/attachment.cgi?id=1966582&action=edit The .spec file difference from Copr build 5804624 to 5950903
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5950903 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2167782, which changed state.
Bug 2167782 Summary: Review Request: php-sebastian-version4 - Managing the version number of Git-hosted PHP projects, version 4 https://bugzilla.redhat.com/show_bug.cgi?id=2167782
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2167791, which changed state.
Bug 2167791 Summary: Review Request: php-sebastian-environment6 - Handle HHVM/PHP environments, version 6 https://bugzilla.redhat.com/show_bug.cgi?id=2167791
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2167799, which changed state.
Bug 2167799 Summary: Review Request: php-sebastian-complexity3 - Calculating the complexity of PHP code units https://bugzilla.redhat.com/show_bug.cgi?id=2167799
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2167804, which changed state.
Bug 2167804 Summary: Review Request: php-sebastian-lines-of-code2 - Counting the lines of code in PHP source code https://bugzilla.redhat.com/show_bug.cgi?id=2167804
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2167807, which changed state.
Bug 2167807 Summary: Review Request: php-phpunit-php-text-template3 - Simple template engine, version 3 https://bugzilla.redhat.com/show_bug.cgi?id=2167807
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2168090, which changed state.
Bug 2168090 Summary: Review Request: php-phpunit-php-file-iterator4 - FilterIterator implementation based on a list of suffixes, version 4 https://bugzilla.redhat.com/show_bug.cgi?id=2168090
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110 Bug 2168110 depends on bug 2168094, which changed state.
Bug 2168094 Summary: Review Request: php-sebastian-code-unit-reverse-lookup3 - Looks up which function or method a line of code belongs to, version 3 https://bugzilla.redhat.com/show_bug.cgi?id=2168094
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |benson_muite@emailplus.org Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org
--- Comment #15 from Benson Muite benson_muite@emailplus.org --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #16 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6093515 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #17 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "MIT License". 247 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/php-phpunit-php-code- coverage10/2168110-php-phpunit-php-code-coverage10/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [x]: Run phpci static analyze on all php files. Note: 6.5.5@7852058 static analyze results in /home/FedoraPackaging/reviews/php-phpunit-php-code- coverage10/2168110-php-phpunit-php-code-coverage10/phpci.log
Rpmlint ------- Checking: php-phpunit-php-code-coverage10-10.1.2-1.fc39.noarch.rpm php-phpunit-php-code-coverage10-10.1.2-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6nolngb0')] checks: 31, packages: 2
php-phpunit-php-code-coverage10.noarch: E: zero-length /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/css/custom.css php-phpunit-php-code-coverage10.spec:144: W: unversioned-explicit-provides bundled(js-popper) php-phpunit-php-code-coverage10.spec: W: invalid-url Source0: php-phpunit-php-code-coverage10-10.1.2-db1497e.tgz php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar.html.dist php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard.html.dist 2 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.9 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
php-phpunit-php-code-coverage10.noarch: E: zero-length /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/css/custom.css php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar.html.dist php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard.html.dist 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.2 s
Requires -------- php-phpunit-php-code-coverage10 (rpmlib, GLIBC filtered): (php-composer(nikic/php-parser) >= 4.15 with php-composer(nikic/php-parser) < 5) (php-composer(phpunit/php-file-iterator) >= 4.0 with php-composer(phpunit/php-file-iterator) < 5) (php-composer(phpunit/php-text-template) >= 3.0 with php-composer(phpunit/php-text-template) < 4) (php-composer(sebastian/code-unit-reverse-lookup) >= 3.0 with php-composer(sebastian/code-unit-reverse-lookup) < 4) (php-composer(sebastian/complexity) >= 3.0 with php-composer(sebastian/complexity) < 4) (php-composer(sebastian/environment) >= 6.0 with php-composer(sebastian/environment) < 7) (php-composer(sebastian/lines-of-code) >= 2.0 with php-composer(sebastian/lines-of-code) < 3) (php-composer(sebastian/version) >= 4.0 with php-composer(sebastian/version) < 5) (php-composer(theseer/tokenizer) >= 1.2.0 with php-composer(theseer/tokenizer) < 2) php(language) php-composer(fedora/autoloader) php-date php-dom php-json php-libxml php-pcre php-reflection php-spl php-tokenizer php-xmlwriter
Provides -------- php-phpunit-php-code-coverage10: bundled(js-bootstrap) bundled(js-d3) bundled(js-jquery) bundled(js-nvd3) bundled(js-popper) php-composer(phpunit/php-code-coverage) php-phpunit-php-code-coverage10
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2168110 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, PHP, Generic Disabled plugins: Python, Ruby, R, Perl, fonts, SugarActivity, C/C++, Java, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: a) Is there a version for bundled js-popper? b) Could the bundled javascript libraries that are already be packaged used? Unclear if there is a strong dependency on the version. c) phpcompatinfo section, line 127, has requires that include:
Requires: php-date Requires: php-pcre Requires: php-reflection Requires: php-spl Requires: php-tokenizer
phpcompatinfo gives these as requirements, but they are also listed below line 89 of the spec file.
phpcompatinfo also lists pcov, but not sure if this is only required in a few cases.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #18 from Remi Collet fedora@famillecollet.com ---
a) Is there a version for bundled js-popper?
Not AFAIK
b) Could the bundled javascript libraries that are already be packaged used? Unclear if there is a strong dependency on the version
To be honest, javascript is the worst nightmare for packaging No API warranty (semver) I suffer a lot because of this in the past (was with jquery) so I definitively prefer the "bundled everything" way for JS
phpcompatinfo also lists pcov, but not sure
It lists xdebug and pcov with "C" for conditional, so:
Suggests: php-xdebug Recommends: php-pcov
In fact one is needed to retrieve coverage information, from xdebug (better but slow), pcov (faster) or phpdbg Missing tool will be properly reported by PHPUnit
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.2-2.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #19 from Benson Muite benson_muite@emailplus.org --- Thanks. Ok on JS bundling. The updated spec still twice lists:
Requires: php-date Requires: php-json Requires: php-pcre Requires: php-reflection Requires: php-spl Requires: php-tokenizer
Probably the lines
# From phpcompatinfo report for version 10.0.0 Requires: php-date . . . Requires: php-tokenizer
can be removed after
BuildRequires: php-theseer-tokenizer >= 1.2.0 %endif
add
# Some of these from phpcompatinfo report for version 10.0.0
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #20 from Remi Collet fedora@famillecollet.com ---
The updated spec still twice lists:
Humm... can't see them...
See the removal: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera...
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #21 from Benson Muite benson_muite@emailplus.org --- Have not checked srpm. They still are there in the spec file available at: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera...
https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-covera...
Searching for php-json in the browser shows 2 entries.
Please ensure removed when importing.
Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #22 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/php-phpunit-php-code-coverage10
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
--- Comment #23 from Remi Collet fedora@famillecollet.com --- Thanks for the review
SCM requests https://pagure.io/releng/fedora-scm-requests/issue/54109 https://pagure.io/releng/fedora-scm-requests/issue/54110
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4cf73d652 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4cf73d652
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4cf73d652 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4cf73d652 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4cf73d652
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2168110
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-07-10 01:17:21
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4cf73d652 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com