[Bug 1218779] New: Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Bug ID: 1218779
           Summary: Review Request: vagrant-triggers - Vagrant plugin to
                    allow using arbitrary commands on host before/after
                    Vagrant commands
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

SRPM URL:
http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.0-1.fc21.src...

Description: 
A Vagrant plugin that allows for the definition of arbitrary
scripts that will run on the host before and/or after Vagrant
commands.

Fedora Account System Username: ngompa

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vít Ondruch  ---
Just a few quick notes:

* Empty changelog
  - You should put some entry into changelog

* Unused BuildRequires
  - The following build requires are not required:

BuildRequires: rubygem-rake, rubygem-rspec, rubygem-simplecov
    BuildRequires: ruby(release)
    BuildRequires: ruby

- If you put the test suite into usable state, the  rubygem-rspec would be
the
    only required gem. Usage of Rake and SimpleCov is discouraged in every
case.

* Bundler is not required for runtime
  - I believe that "Requires: rubygem-bundler: is not needed, since
    rubygem-bundler is very likely pulled in via Vagrant dependency.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

--- Comment #2 from Vít Ondruch  ---
* Too long summary
  - Not sure if there is some limit for Summary, but it seems to be pretty
long.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #3 from Josef Stribny  ---
I will take it for a review.

Please fix first the issues pointed out by Vit.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

--- Comment #4 from Neal Gompa  ---
New SRPM URL:
http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.0-2.fc22.src...

Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

I believe I have addressed everything noted by Vít, except the "usable state
test suite" thing.

While I do now have simplecov disabled, I have continued to have the tests
disabled because they throw this error and I don't know how to fix it:

/builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/spec_helper.rb:4:in
`require': cannot load such file -- vagrant (LoadError)
    from
/builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/spec_helper.rb:4:in
`<top (required)>'
    from
/builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/vagrant-triggers/action/trigger_spec.rb:1:in
`require'
    from
/builddir/build/BUILD/vagrant-triggers-0.5.0/usr/share/vagrant/gems/gems/vagrant-triggers-0.5.0/spec/vagrant-triggers/action/trigger_spec.rb:1:in
`<top (required)>'
    from
/usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in
`load'
    from
/usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in
`block in load_spec_files'
    from
/usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in
`each'
    from
/usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/configuration.rb:896:in
`load_spec_files'
    from
/usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:22:in
`run'
    from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:80:in
`run'
    from /usr/share/gems/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:17:in
`block in autorun'

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

John Skeoch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]         |[e-mail]

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]           |[e-mail]
              Flags|                            |fedora-review?

--- Comment #6 from Vít Ondruch  ---
Hi Neal,

what is the status here? Josef takes sabbatical leave, so I should probably
finish this.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #7 from Neal Gompa  ---
Well, my status is basically the same as it was in comment 4, though I suppose
I should update to the latest version (0.5.2) and rebase my patches (if
needed).

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

--- Comment #8 from Neal Gompa  ---
I've updated to vagrant-triggers 0.5.2.

New SRPM URL:
http://kinginuyasha.enanocms.org/downloads/vagrant-triggers-0.5.2-1.fc23.src...

Spec URL: http://kinginuyasha.enanocms.org/downloads/vagrant-triggers.spec

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

--- Comment #9 from Neal Gompa  ---
Erk, forgot to note in comment 8 that I still have the same problem as before
if I enable tests.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before/after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Tomas Hrcka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]         |[e-mail]

--- Comment #10 from Tomas Hrcka  ---
Hi Neal I am taking this review, expect update short time.

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before /after Vagrant commands

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #11 from Igor Gnatenko  ---
ping?

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before /after Vagrant commands

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

--- Comment #12 from Vít Ondruch  ---
(In reply to Neal Gompa from comment #9)
> Erk, forgot to note in comment 8 that I still have the same problem as
> before if I enable tests.

This should help:

~~~
rspec2 -I%{vagrant_dir}/lib spec
~~~

Nevertheless, I don't think this is compatible with Vagrant 1.9+, since this is
using Bundler, but Vagrant itself is not using Bundler anymore. I created this
[1] PR which might or might not fix the compatibility.

Unfortunately, the upstream is stalled a bit [2].

[1] https://github.com/emyl/vagrant-triggers/pull/90
[2] https://github.com/emyl/vagrant-triggers/issues/85

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before /after Vagrant commands

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Aron Griffis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Aron Griffis  ---
Functionality of vagrant-triggers has been merged into vagrant proper now

https://github.com/hashicorp/vagrant/pull/9713

[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before /after Vagrant commands

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2018-05-11 04:05:35

--- Comment #14 from Vít Ondruch  ---
(In reply to Aron Griffis from comment #13)
> Functionality of vagrant-triggers has been merged into vagrant proper now
>
> https://github.com/hashicorp/vagrant/pull/9713

Thx for the info. Because this has not moved forward a lot in past two years, I
believe it is save to close this as WONTFIX and focus on update of Vagrant (bug
1574756) instead.