https://bugzilla.redhat.com/show_bug.cgi?id=2128257
Bug ID: 2128257 Summary: Review Request: motion - A motion detection system Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gist.githubusercontent.com/Vascom/28d6d07ee5c429bbaf46b1eb29b2dcd9/r... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/403/92220403/motion-4.4.0-5.f...
Description: Motion is a software motion detector. It grabs images from video4linux devices and/or from webcams (such as the axis network cameras). Motion is the perfect tool for keeping an eye on your property keeping only those images that are interesting. Motion is strictly command line driven and can run as a daemon with a rather small footprint. This version is built with ffmpeg support but without MySQL and PostgreSQL support.
Previously this package was at Rpmfusion repo.
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Flags| |fedora-review? CC| |vitaly@easycoding.org
--- Comment #1 from Vitaly Zaitsev vitaly@easycoding.org ---
# libmysqlclient-dev (>= 5.5.17-4), # libpq-dev, # libsdl1.2-dev, # libv4l-dev,
Can be removed.
Requires: libv4l
Requires: libv4l%{?_isa}
Requires(post): systemd Requires(preun): systemd Requires(postun): systemd
Should be replaced with %{?systemd_requires}.
Source0: https://github.com/Motion-Project/motion/archive/release-%%7Bversion%7D.tar....
Can be simplified: Source0: https://github.com/Motion-Project/motion/archive/release-%%7Bversion%7D/%%7B...
%triggerun -- motion < 3.3.0-trunkREV557.8 find /var/motion -user root -group root -exec chown motion:video '{}' ';'
This is too dangerous and should be removed.
%pre getent passwd motion >/dev/null || \ useradd -r -g video -d /run/motion -s /sbin/nologin \ -c "motion detection system" motion exit 0
Please switch to %sysusers_create_compat: https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/
%post /usr/bin/systemd-tmpfiles --create %{_tmpfilesdir}/%{name}.conf
Please switch to this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #2 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://gist.githubusercontent.com/Vascom/28d6d07ee5c429bbaf46b1eb29b2dcd9/r... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3830/98233830/motion-4.5.1-3....
Updated. But with last two changes I need help.
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://motion-project.gith | |ub.io/
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5589334 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU General Public License v2.0 or later", "BSD 3-Clause License". 45 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/motion/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 286720 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in motion [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1699840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros
Rpmlint ------- Checking: motion-4.5.1-3.fc39.x86_64.rpm motion-debuginfo-4.5.1-3.fc39.x86_64.rpm motion-debugsource-4.5.1-3.fc39.x86_64.rpm motion-4.5.1-3.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm96tc72v')] checks: 31, packages: 4
motion.x86_64: W: tmpfile-not-in-filelist /run/motion motion.x86_64: W: tmpfile-not-in-filelist /var/log/motion.log motion.src: W: name-repeated-in-summary motion motion.x86_64: W: name-repeated-in-summary motion motion.spec:241: W: macro-in-%changelog %{next_version} motion.x86_64: E: explicit-lib-dependency libv4l(x86-64) motion.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/motion 4 packages and 0 specfiles checked; 1 errors, 6 warnings, 1 badness; has taken 0.3 s
Rpmlint (debuginfo) ------------------- Checking: motion-debuginfo-4.5.1-3.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_f2wxmj2')] checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
motion.x86_64: W: tmpfile-not-in-filelist /run/motion motion.x86_64: W: tmpfile-not-in-filelist /var/log/motion.log motion.x86_64: W: name-repeated-in-summary motion motion.x86_64: E: explicit-lib-dependency libv4l(x86-64) motion.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/motion 3 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.5 s
Source checksums ---------------- https://github.com/Motion-Project/motion/archive/release-4.5.1/motion-releas... : CHECKSUM(SHA256) this package : 0c824276bb23565b7cf10409ebdcb46b85fb1f6abca957252e52290bb1fe473e CHECKSUM(SHA256) upstream package : 0c824276bb23565b7cf10409ebdcb46b85fb1f6abca957252e52290bb1fe473e
Requires -------- motion (rpmlib, GLIBC filtered): /bin/sh config(motion) glibc libavcodec.so.59()(64bit) libavcodec.so.59(LIBAVCODEC_59)(64bit) libavdevice.so.59()(64bit) libavdevice.so.59(LIBAVDEVICE_59)(64bit) libavformat.so.59()(64bit) libavformat.so.59(LIBAVFORMAT_59)(64bit) libavutil.so.57()(64bit) libavutil.so.57(LIBAVUTIL_57)(64bit) libc.so.6()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libmicrohttpd.so.12()(64bit) libsqlite3.so.0()(64bit) libswscale.so.6()(64bit) libswscale.so.6(LIBSWSCALE_6)(64bit) libv4l(x86-64) libwebp.so.7()(64bit) libwebpmux.so.3()(64bit) rtld(GNU_HASH) shadow-utils systemd
motion-debuginfo (rpmlib, GLIBC filtered):
motion-debugsource (rpmlib, GLIBC filtered):
Provides -------- motion: config(motion) motion motion(x86-64)
motion-debuginfo: debuginfo(build-id) motion-debuginfo motion-debuginfo(x86-64)
motion-debugsource: motion-debugsource motion-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name motion --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, SugarActivity, Ocaml, Python, fonts, PHP, Haskell, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #5 from Vitaly Zaitsev vitaly@easycoding.org ---
Note: No gcc, gcc-c++ or clang found in BuildRequires
BuildRequires: gcc-c++
License: GPL-2.0-or-later
License: GPL-2.0-or-later AND BSD-3-Clause
motion.x86_64: W: tmpfile-not-in-filelist /run/motion
%install ... install -D -d -m 0700 %{buildroot}/run/%{name} touch %{buildroot}/run/%{name}/%{name}.pid
%files ... %attr(0700,%{name},video) /run/%{name}/ %verify(not size mtime md5) /run/%{name}/%{name}.pid
motion.x86_64: W: tmpfile-not-in-filelist /var/log/motion.log
Please remove this from tmpfiles config and use classic installation:
%install ... install -D -d -m 0700 %{buildroot}%{_localstatedir}/log/%{name}/
%files ... %attr(-,%{name},video) %dir %{_localstatedir}/log/%{name}/ %ghost %{_localstatedir}/log/%{pypi_name}/%{name}.log
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #6 from Vitaly Zaitsev vitaly@easycoding.org --- Small fixes:
%attr(0700,%{name},video) /run/%{name}/
%attr(0700,%{name},video) %dir /run/%{name}/
%attr(-,%{name},video) %dir %{_localstatedir}/log/%{name}/
%attr(0700,%{name},video) %dir %{_localstatedir}/log/%{name}/
Product: Fedora Version: rawhide Component: Package Review
Vitaly vitaly@easycoding.org has canceled Package Review package-review@lists.fedoraproject.org's request for Vitaly vitaly@easycoding.org's needinfo: Bug 2128257: Review Request: motion - A motion detection system https://bugzilla.redhat.com/show_bug.cgi?id=2128257
https://bugzilla.redhat.com/show_bug.cgi?id=2128257
--- Comment #8 from leigh scott leigh123linux@googlemail.com --- You need to fix these sed commands as the base files have changed.
#We change the PID file path to match the one in the startup script sed -i 's|/var/run/motion/motion.pid|/var/run/motion.pid|g' %{buildroot}%{_sysconfdir}/%{name}/motion.conf #We set the log file and target directory - logging is for 3.3 branch sed -i 's|;logfile /tmp/motion.log|logfile /var/log/motion.log|g' %{buildroot}%{_sysconfdir}/%{name}/motion.conf sed -i 's|target_dir /tmp/motion|target_dir /var/motion|g' %{buildroot}%{_sysconfdir}/%{name}/motion.conf
also motion should include /var/motion directory in %files section.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com