[Bug 1321461] New: Review Request: compiz-plugins-experimental - Additional plugins for Compiz
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
Bug ID: 1321461 Summary: Review Request: compiz-plugins-experimental - Additional plugins for Compiz Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: chat-to-me@raveit.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-experimental.sp... SRPM URL: https://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-experimental-0.... Description: The Compiz Reloaded Project brings 3D desktop visual effects that improve usability of the X Window System and provide increased productivity though plugins and themes contributed by the community giving a rich desktop experience. This package contains additional plugins from the Compiz Reloaded Project Fedora Account System Username: raveit65
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #1 from Wolfgang Ulbrich chat-to-me@raveit.de --- This is a re-review request for a package rename. Old packackage name is compiz-plugins-unsupported.
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |leigh123linux@googlemail.co | |m
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #2 from leigh scott leigh123linux@googlemail.com --- Created attachment 1140805 --> https://bugzilla.redhat.com/attachment.cgi?id=1140805&action=edit spec file patch
Can you fix the missing epoch tags on the package provides and your global epoch misses the package tag!
compiz-plugins-experimental.x86_64: W: incoherent-version-in-changelog 1:0.8.12-2 ['0.8.12-2.fc25', '0.8.12-2'] compiz-plugins-experimental.x86_64: W: self-obsoletion compiz-plugins-unsupported < 1:0.8.12-2.fc25 obsoletes compiz-plugins-unsupported = 0.8.12-2.fc25 compiz-plugins-experimental.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-plugins-experimental/COPYING compiz-plugins-experimental-devel.x86_64: W: self-obsoletion compiz-plugins-unsupported-devel < 1:0.8.12-2.fc25 obsoletes compiz-plugins-unsupported-devel = 0.8.12-2.fc25
your debug package also has permissions issue
compiz-plugins-experimental-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/compiz-plugins-experimental-0.8.12/src/cubemodel/cubemodel-internal.h compiz-plugins-experimental-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/compiz-plugins-experimental-0.8.12/src/cubemodel/cubemodel.c compiz-plugins-experimental-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/compiz-plugins-experimental-0.8.12/src/cubemodel/fileParser.c
The spec file patch attached should fix all the above issues
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #3 from leigh scott leigh123linux@googlemail.com --- You also have two unclaimed directories
/usr/share/compiz/dialog.xml /usr/share/compiz/elements.xml /usr/share/compiz/elements/autumn1.png /usr/share/compiz/elements/autumn2.png /usr/share/compiz/elements/bubbles1.png /usr/share/compiz/elements/bubbles2.png /usr/share/compiz/elements/fireflies1.svg /usr/share/compiz/elements/fireflies2.svg /usr/share/compiz/elements/snow1.png /usr/share/compiz/elements/snow2.png /usr/share/compiz/elements/stars1.png /usr/share/compiz/fakeargb.xml /usr/share/compiz/fireflies.xml /usr/share/compiz/fireflies/firefly1.png /usr/share/compiz/fireflies/firefly2.png /usr/share/compiz/fireflies/firefly3.png /usr/share/compiz/fireflies/firefly4.png /usr/share/compiz/freewins.xml
The package needs to own /usr/share/compiz/elements/ & /usr/share/compiz/fireflies/
You will need to change the files section to
%files -f %{name}.lang %doc COPYING AUTHORS NEWS %{_libdir}/compiz/*.so %dir %{_datadir}/compiz/elements/ %dir %{_datadir}/compiz/fireflies/ %{_datadir}/compiz/*.xml %{_datadir}/compiz/*/*.png %{_datadir}/compiz/*/*.svg
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #4 from leigh scott leigh123linux@googlemail.com --- I missed a couple more unclaimed directories
/usr/share/compiz/snow/ /usr/share/compiz/stars/
Change files section to
%files -f %{name}.lang %doc COPYING AUTHORS NEWS %{_libdir}/compiz/*.so %dir %{_datadir}/compiz/elements/ %dir %{_datadir}/compiz/fireflies/ %dir %{_datadir}/compiz/snow/ %dir %{_datadir}/compiz/stars/ %{_datadir}/compiz/*.xml %{_datadir}/compiz/*/*.png %{_datadir}/compiz/*/*.svg
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #5 from Wolfgang Ulbrich chat-to-me@raveit.de --- Thanks Leigh for taken the review.
* Mon Mar 28 2016 Wolfgang Ulbrich chat-to-me@raveit.de - 1:0.8.12-3 - add correct epoch versions - own directories
https://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-experimental-0....
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #6 from Wolfgang Ulbrich chat-to-me@raveit.de --- Opps, forgot to fix the permission issue , i will do that too.
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #7 from Wolfgang Ulbrich chat-to-me@raveit.de --- Btw, i fixed permissions and incorrect-fsf-address as upstream. https://github.com/compiz-reloaded/compiz-plugins-experimental/commit/7c81f1... https://github.com/compiz-reloaded/compiz-plugins-experimental/commit/c17b66...
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #8 from leigh scott leigh123linux@googlemail.com --- PASSED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 56 files have unknown license. Detailed output of licensecheck in /home/leigh/Desktop/1321461-compiz- plugins-experimental/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in compiz- plugins-experimental-devel , compiz-plugins-experimental-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4669440 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: compiz-plugins-experimental-0.8.12-3.fc24.x86_64.rpm compiz-plugins-experimental-devel-0.8.12-3.fc24.x86_64.rpm compiz-plugins-experimental-debuginfo-0.8.12-3.fc24.x86_64.rpm compiz-plugins-experimental-0.8.12-3.fc24.src.rpm compiz-plugins-experimental.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-plugins-experimental/COPYING compiz-plugins-experimental-devel.x86_64: W: no-documentation compiz-plugins-experimental.src: W: invalid-url Source0: https://github.com/compiz-reloaded/compiz-plugins-experimental/releases/down... HTTP Error 403: Forbidden 4 packages and 0 specfiles checked; 1 errors, 2 warnings.
Rpmlint (debuginfo) ------------------- Checking: compiz-plugins-experimental-debuginfo-0.8.12-3.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Requires -------- compiz-plugins-experimental (rpmlib, GLIBC filtered): compiz-plugins-extra(x86-64) compiz-plugins-main(x86-64) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXcursor.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXinerama.so.1()(64bit) libXrandr.so.2()(64bit) libXss.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstartup-notification-1.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH)
compiz-plugins-experimental-devel (rpmlib, GLIBC filtered): compiz-plugins-experimental(x86-64) compiz-plugins-extra-devel(x86-64) compiz-plugins-main-devel(x86-64)
compiz-plugins-experimental-debuginfo (rpmlib, GLIBC filtered):
Provides -------- compiz-plugins-experimental: compiz-plugins-experimental compiz-plugins-experimental(x86-64) compiz-plugins-unsupported compiz-plugins-unsupported(x86-64) libanaglyph.so()(64bit) libanimationplus.so()(64bit) libanimationsim.so()(64bit) libatlantis.so()(64bit) libcubemodel.so()(64bit) libdialog.so()(64bit) libelements.so()(64bit) libfakeargb.so()(64bit) libfireflies.so()(64bit) libfreewins.so()(64bit) libghost.so()(64bit) libmswitch.so()(64bit) libphoto.so()(64bit) libputplus.so()(64bit) libscreensaver.so()(64bit) libsmartput.so()(64bit) libsnow.so()(64bit) libsnowglobe.so()(64bit) libstackswitch.so()(64bit) libstar.so()(64bit) libstatic.so()(64bit) libswap.so()(64bit) libthrow.so()(64bit) libtile.so()(64bit) libtoggledeco.so()(64bit) libwizard.so()(64bit) libworkspacenames.so()(64bit)
compiz-plugins-experimental-devel: compiz-plugins-experimental-devel compiz-plugins-experimental-devel(x86-64) compiz-plugins-unsupported-devel compiz-plugins-unsupported-devel(x86-64)
compiz-plugins-experimental-debuginfo: compiz-plugins-experimental-debuginfo compiz-plugins-experimental-debuginfo(x86-64)
Unversioned so-files -------------------- compiz-plugins-experimental: /usr/lib64/compiz/libanaglyph.so compiz-plugins-experimental: /usr/lib64/compiz/libanimationplus.so compiz-plugins-experimental: /usr/lib64/compiz/libanimationsim.so compiz-plugins-experimental: /usr/lib64/compiz/libatlantis.so compiz-plugins-experimental: /usr/lib64/compiz/libcubemodel.so compiz-plugins-experimental: /usr/lib64/compiz/libdialog.so compiz-plugins-experimental: /usr/lib64/compiz/libelements.so compiz-plugins-experimental: /usr/lib64/compiz/libfakeargb.so compiz-plugins-experimental: /usr/lib64/compiz/libfireflies.so compiz-plugins-experimental: /usr/lib64/compiz/libfreewins.so compiz-plugins-experimental: /usr/lib64/compiz/libghost.so compiz-plugins-experimental: /usr/lib64/compiz/libmswitch.so compiz-plugins-experimental: /usr/lib64/compiz/libphoto.so compiz-plugins-experimental: /usr/lib64/compiz/libputplus.so compiz-plugins-experimental: /usr/lib64/compiz/libscreensaver.so compiz-plugins-experimental: /usr/lib64/compiz/libsmartput.so compiz-plugins-experimental: /usr/lib64/compiz/libsnow.so compiz-plugins-experimental: /usr/lib64/compiz/libsnowglobe.so compiz-plugins-experimental: /usr/lib64/compiz/libstackswitch.so compiz-plugins-experimental: /usr/lib64/compiz/libstar.so compiz-plugins-experimental: /usr/lib64/compiz/libstatic.so compiz-plugins-experimental: /usr/lib64/compiz/libswap.so compiz-plugins-experimental: /usr/lib64/compiz/libthrow.so compiz-plugins-experimental: /usr/lib64/compiz/libtile.so compiz-plugins-experimental: /usr/lib64/compiz/libtoggledeco.so compiz-plugins-experimental: /usr/lib64/compiz/libwizard.so compiz-plugins-experimental: /usr/lib64/compiz/libworkspacenames.so
Source checksums ---------------- https://github.com/compiz-reloaded/compiz-plugins-experimental/releases/down... : CHECKSUM(SHA256) this package : ba337e9bd482d6eff8dec4a840e3fda1091513a38a581a37cdd45021cc7404b5 CHECKSUM(SHA256) upstream package : ba337e9bd482d6eff8dec4a840e3fda1091513a38a581a37cdd45021cc7404b5
AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: compiz-plugins-experimental-0.8.12/configure.ac:12
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1321461 -m fedora-24-x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #9 from Till Maas opensource@till.name --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/compiz-plugins-experiment...
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- compiz-plugins-experimental-0.8.12-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3aad60714a
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- compiz-plugins-experimental-0.8.12-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3aad60714a
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- compiz-plugins-experimental-0.8.12-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1321461
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-04-03 13:57:24
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla