[Bug 444235] New: Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

Summary: Review Request: djview4 - DjVu viewer
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://terjeros.fedorapeople.org/djview4/djview4.spec
SRPM URL: http://terjeros.fedorapeople.org/djview4/djview4-4.3-1.fc9.src.rpm
Description:

DjView4 is a DjVu document viewer with the following features:
 o continuous scrolling of pages
 o side-by-side display of pages
 o display thumbnails as a grid
 o display outlines
 o page names supported
 o metadata dialog

It's based on DjVuLibre and Qt4.

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: djview4 - DjVu viewer

https://bugzilla.redhat.com/show_bug.cgi?id=444235

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: djview4 -   |Review Request: djview4 -
                   |DjVu viewer                 |DjVu viewer

------- Additional Comments From [e-mail]  2008-04-25 18:09 EST -------
Sure, take it.

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: djview4 - DjVu viewer

https://bugzilla.redhat.com/show_bug.cgi?id=444235

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-04-29 14:32 EST -------
*** Bug 374621 has been marked as a duplicate of this bug. ***

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #3 from Jason Tibbitts   2008-08-10 18:30:09 EDT ---
Builds fine and rpmlint is silent.

I note that the compiler is called properly everywhere except when compiling
nsdejavu.c.  However, the plugin isn't actually installed by this package, so
I'm not going to worry about it.  However, if in the future you decide to turn
on the plugin, you'll have several things to look at.  (The licensing is
different, for one thing.)

Your scriptlets seem to be missing the
  if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
    %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
  fi
part.  See
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

* source files match upstream:
   a783c3700f32d31b0a2a8662d5e2abcd1b4ab3cc129543daaa8af9211135e911  
   djview4-4.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
? compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   djview4 = 4.3-1.fc10
   djview4(x86-64) = 4.3-1.fc10
  =
   /bin/sh
   libQtCore.so.4()(64bit)
   libQtGui.so.4()(64bit)
   libQtNetwork.so.4()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libdjvulibre.so.15()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libjpeg.so.62()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)

* %check is not present; no test suite upstream.  I have not tested this 
   package.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X scriptlets missing icon cache update.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* desktop files valid and installed properly.

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

--- Comment #4 from Terje Røsten   2008-08-12 15:16:22 EDT ---
> I note that the compiler is called properly everywhere except when compiling
> nsdejavu.c.  However, the plugin isn't actually installed by this package, so
> I'm not going to worry about it.  However, if in the future you decide to turn
> on the plugin, you'll have several things to look at.  (The licensing is
> different, for one thing.)

Ok, thanks for heads up.
> Your scriptlets seem to be missing the
>   if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
>     %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
>   fi
> part.  See
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

Fixed in updated package:

spec: http://terjeros.fedorapeople.org/djview4/djview4.spec
srpm: http://terjeros.fedorapeople.org/djview4/djview4-4.3-2.fc9.src.rpm

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

--- Comment #5 from Jason Tibbitts   2008-08-17 10:42:19 EDT ---
Looks good to me.

APPROVED

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

--- Comment #6 from Terje Røsten   2008-08-19 13:54:01 EDT ---
Thanks tibbs!

New Package CVS Request
=======================
Package Name: djview4
Short Description: DjVu viewer
Owners: terjeros
Branches: F-8 F-9
InitialCC:

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

--- Comment #7 from Kevin Fenzi   2008-08-23 13:51:10 EDT ---
cvs done.

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

Terje Røsten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #8 from Terje Røsten   2008-08-24 08:04:37 EDT ---
Built and pushed.

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

Jonathan Underwood  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #9 from Jonathan Underwood  2012-02-21 13:19:49 EST ---
Package Change Request
======================
Package Name: djview4
New Branches: el6
Owners: jgu
InitialCC: terjeros

[Bug 444235] Review Request: djview4 - DjVu viewer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444235

--- Comment #10 from Jon Ciesla  2012-02-21 13:32:46 EST ---
Git done (by process-git-requests).