[Bug 234831] New: Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

Summary: Review Request: fgfs-base - FlightGear base scenery and
                    data files
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Spec URL: http://fr2.rpmfind.net/pub/bellet/review/fgfs-base.spec
SRPM URL: http://fr2.rpmfind.net/pub/bellet/review/fgfs-base-0.9.10-1.fc6.src.rpm

Description:
This package contains the base scenery and aircrafts data files for FlightGear

This package is noarch, it is big because it contains all the available
aircrafts data. It also provides a base Scenery : the area of San Francisco
airport. The spec file has an empty %prep section, because the tarball doesn't
provide a Makefile, as all the data from the tarball is supposed to land in the
same destination data directory.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-04-02 15:27 EST -------
good:
+ Naming is ok
* Tar ball matches with upstream.
+ License is ok
+ Local build works fine.
+ Binary packagea are ok.

Bad:
- Pakcage contains no docs.
- Pakcage contrains no verbatin copy of the license

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |177841
              nThis|                            |

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

------- Additional Comments From [e-mail]  2007-04-02 19:06 EST -------
ok. I moved doc files and COPYING to the docdir.

New SPEC : http://fr2.rpmfind.net/pub/bellet/review/fgfs-base.spec
New SRPM : http://fr2.rpmfind.net/pub/bellet/review/fgfs-base-0.9.10-2.fc6.src.rpm

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

------- Additional Comments From [e-mail]  2007-04-03 12:09 EST -------
Good:
+ Package contains verbatin copy of the license text.

*** APPROVED ***

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-04-07 12:01 EST -------
Thanks Jochen!

New Package CVS Request
=======================
Package Name: fgfs-base
Short Description: FlightGear base scenery and data files
Owners: [e-mail]
Branches: FC-6
InitialCC:

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |234826
              nThis|                            |

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-04-08 16:16 EST -------
fgfs-base has been successfully build. Thanks for the review.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-base - FlightGear base scenery and data files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234831

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Fabrice Bellet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #6 from Fabrice Bellet   2008-12-15 04:17:43 EDT ---
New Package CVS Request
=======================
Package Name: FlightGear-data
Short Description: FlightGear base scenery and data files
Owners: [e-mail]
Branches:
InitialCC:

I'll rename this package, because upstream name changed, since version 1.99.5:
ftp://ftp.de.flightgear.org/pub/fgfs/Shared/

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Kevin Fenzi   2008-12-18 12:20:05 EDT ---
For package renames, we don't have a hard policy yet, but I would like to
suggest the following:

- Can you create the new packages with the new names and the needed
provides/obsoletes. 
- Post a link to them on fedora-devel list and/or here. 
- Once they check out on provides/obsoletes, I can make the new package names
in cvs for you, and you can mark the old one as dead.package and import the new
one.

Does that sound reasonable?

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

--- Comment #8 from Fabrice Bellet   2008-12-19 10:45:30 EDT ---
Sure.

The concerned packages are here : http://fr2.rpmfind.net/pub/bellet/review/

.fgfs-base is renamed to FlightGear-data
.fgfs-Atlas is renamed to FlightGear-Atlas

SimGear, FlightGear and FlightGear-data new versions are currently released
upstream synchronously, with the same version numbers. FlighGear-Atlas and
FlightGear are the only two packages that depend on FlightGear-data, so I
updated their Requires accordingly. And no other package depends on
FlightGear-Atlas. So I see no use in this case, to continue to provide the old
names of these two renamed packages.

(I'm maintainer for all the FlightGear-* packages, and comaintainer for
SimGear, so I expect to update all these packages in rawhide at the same time)

Does it looks good ?

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

--- Comment #9 from Fabrice Bellet   2008-12-19 11:34:27 EDT ---
ah typo in fgfs-Atlas.spec. please grab again from the previous url, if you
already have.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

--- Comment #10 from Kevin Fenzi   2008-12-21 00:00:39 EDT ---
Yep. That looks good to me from what I can see.
I would of course still push to rawhide and confirm it obsoletes as you expect
before pushing for f10/f9.

So, would you like to just put all the requests here and I can do them at once? 
Once the new packages are setup, you can dead.package the old ones.

Thanks for your patience.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |

--- Comment #11 from Kevin Fenzi   2008-12-22 22:07:30 EDT ---
Go ahead and add the requests here (use Fedora account system accounts) and
reset the fedora-cvs flag when you are ready.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Fabrice Bellet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #12 from Fabrice Bellet   2009-01-06 09:28:55 EDT ---
Ok.

New Package CVS Request
=======================
Package Name: FlightGear-data
Short Description: FlightGear base scenery and data files
Owners: bellet
Branches:
InitialCC:

New Package CVS Request
=======================
Package Name: FlightGear-Atlas
Short Description: Flightgear map tools
Owners: bellet
Branches:
InitialCC:

Thanks!

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #13 from Kevin Fenzi   2009-01-06 20:33:01 EDT ---
cvs done.

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

Fabrice Bellet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #14 from Fabrice Bellet  2010-07-09 04:46:32 EDT ---
Package Change Request
======================
Package Name: FlightGear-data
New Branches: EL-6
Owners: bellet

[Bug 234831] Review Request: fgfs-base - FlightGear base scenery and data files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234831

--- Comment #15 from Kevin Fenzi  2010-07-09 14:08:23 EDT ---
CVS done (by process-cvs-requests.py).