[Bug 913325] New: Review Request: trac-defaultcc-plugin - Trac plugin to set default CC address(es) by component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Bug ID: 913325 Summary: Review Request: trac-defaultcc-plugin - Trac plugin to set default CC address(es) by component Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: awilliam@redhat.com
Spec URL: https://www.happyassassin.net/extras/trac-defaultcc-plugin.spec SRPM URL: https://www.happyassassin.net/extras/trac-defaultcc-plugin-0.3-0.1.svn12643.... Description: A trac plugin which automatically adds a default CC list when a new ticket is created, based on the selected Component. CC lists can be configured per Component through the component admin panel. Fedora Account System Username: adamwill
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |kevin@scrye.com
--- Comment #1 from Adam Williamson awilliam@redhat.com --- Spec is based straight off of the trac-tickettemplate-plugin spec, needed little in the way of modification. I can't easily test this as I don't have a local trac instance and setting one up is kind of a drag. Kevin says he has a test instance and can try it out there. It's a simple enough plugin, only issue might be if it happens to be incompatible with our version of trac, but I think that should be okay. I have run rpmlint on the spec and RPMs, and it's happy.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #2 from Kevin Fenzi kevin@scrye.com --- Will review this tomorrow morning most likely... ;)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: (no md5 due to checkout, but a checkout and diff shows no changes) OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) see below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. rpmlint says: trac-defaultcc-plugin.src: W: invalid-url Source0: trac-defaultcc-plugin-svn12643.tar.xz
can be ignored.
I don't see any blockers here, so this package is APPROVED.
I'm happy to co-maintain.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Adam Williamson awilliam@redhat.com --- New Package SCM Request ======================= Package Name: trac-defaultcc-plugin Short Description: Trac plugin to set default CC address(es) by component Owners: adamwill kevin Branches: el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- trac-defaultcc-plugin-0.3-0.1.svn12643.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-defaultcc-plugin-0.3-0.1.svn126...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2013-02-26 11:39:00
--- Comment #7 from Adam Williamson awilliam@redhat.com --- I've done a Rawhide build already, so closing. Thanks, Kevin and Jon.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913325
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- trac-defaultcc-plugin-0.3-0.1.svn12643.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla