[Bug 442914] New: Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=442914

Summary: Review Request: eg - Git for mere mortals
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://jbowes.fedorapeople.org/tmp/eg.spec
SRPM URL: http://jbowes.fedorapeople.org/tmp/eg-0.70-1.fc9.src.rpm
Description:
Easy Git (eg) is a wrapper for git, designed to make git easy to learn and use.

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

------- Additional Comments From [e-mail]  2008-04-17 11:44 EST -------
Updated:
Spec URL: http://jbowes.fedorapeople.org/tmp/eg.spec
SRPM URL: http://jbowes.fedorapeople.org/tmp/eg-0.70-2.fc9.src.rpm

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-04-17 15:49 EST -------
OK	source files match upstream
        (diff between supplied archive and the one produced directly from git is empty)
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPL). License text not included upstream.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (rawhide/X86_64).
N/A	debuginfo package looks complete.
OK*	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
N/A	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

rpmlint output:

eg.noarch: I: checking
eg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/eg
eg.src: I: checking

This a common issue of packages with "bash completion" support where
/etc/bash_completion.d directory owned by the package. Trigger based solution is
mentioned at http://fedoraproject.org/wiki/ToshioKuratomi/TriggerScripts.

package is APPROVED

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

------- Additional Comments From [e-mail]  2008-04-18 07:39 EST -------
Thanks for the review, Dan!

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-04-18 07:42 EST -------
New Package CVS Request
=======================
Package Name: eg
Short Description: Git for mere mortals
Owners: jbowes
Branches: F-8
Cvsextras Commits: yes

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-04-18 12:28 EST -------
cvs done.

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

------- Additional Comments From [e-mail]  2008-04-25 03:51 EST -------
James, you should close the review bug as it was already built in Koji.

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals

https://bugzilla.redhat.com/show_bug.cgi?id=442914

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-04-25 12:37 EST -------
Thanks Dan, I completely forgot.

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=442914

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Dan Horák   2008-08-10 14:13:35 EDT ---
*** Bug 458543 has been marked as a duplicate of this bug. ***

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=442914

Terje Røsten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Terje Røsten   2008-10-21 15:09:32 EDT ---
James, what's up here?

I can't find this package in any repo, could you please have a look?

BTW: upstream version is 0.93.

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=442914

--- Comment #10 from James Bowes   2008-11-05 08:55:37 EDT ---
(In reply to comment #9)
> James, what's up here?
>
> I can't find this package in any repo, could you please have a look?
>
> BTW: upstream version is 0.93.

Ha, guess i forgot to submit it to bodhi. Anyways, it's there now. I'll update
to a newer version shortly.

Thanks Terje!

[Bug 442914] Review Request: eg - Git for mere mortals

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=442914

--- Comment #11 from Terje Røsten   2008-12-06 08:12:58 EDT ---
Now you can eg push to stable, eg has been in testing in over 4 weeks.