[Bug 2332078] New: Review Request: python-markdown-callouts - Markdown extension to provide a classier syntax for admonitions
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Bug ID: 2332078 Summary: Review Request: python-markdown-callouts - Markdown extension to provide a classier syntax for admonitions Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-mar... SRPM URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-mar...
Description: This package provides an extension for Python-Markdown that adds a classier syntax for admonitions.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126755896
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://oprypin.github.io/m | |arkdown-callouts Keywords| |AutomationTriaged
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8384636 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |michel@michel-slm.name Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
--- Comment #3 from Michel Lind michel@michel-slm.name --- - I'll call the bcond flag tests instead of checks - since it's confusing, you do have a check section - Run the import check unconditionally, there is no reason not to
Will try and see why the tests fail
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
--- Comment #4 from Michel Lind michel@michel-slm.name --- pyproject.toml lists an extra dependency on pytest-golden, which I don't see packaged. Update the comment about why tests are not run, and/or package this?
(I suspect we'll have to disable tests in EPEL because packaging this might bring in many dependencies, but this will help if we want to reenable tests in Fedora sometime)
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2332084
--- Comment #5 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-mar... SRPM URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-mar...
Changelog: - rename bcond - fix the tests
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2332084 [Bug 2332084] Review Request: python-pytest-golden - Plugin for pytest that offloads expected outputs to data files
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2062182 --> https://bugzilla.redhat.com/attachment.cgi?id=2062182&action=edit The .spec file difference from Copr build 8384636 to 8384732
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8384732 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from Michel Lind michel@michel-slm.name --- Package was generated with pyp2spec, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines
Package APPROVED.
===
Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:
- add @python-packagers-sig with "commit" access as package co-maintainer
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-markdown-callouts
https://bugzilla.redhat.com/show_bug.cgi?id=2332078 Bug 2332078 depends on bug 2332084, which changed state.
Bug 2332084 Summary: Review Request: python-pytest-golden - Plugin for pytest that offloads expected outputs to data files https://bugzilla.redhat.com/show_bug.cgi?id=2332084
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7e6c3bfb8d (python-markdown-callouts-0.4.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e6c3bfb8d
https://bugzilla.redhat.com/show_bug.cgi?id=2332078
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-13 12:01:47
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7e6c3bfb8d (python-markdown-callouts-0.4.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com