[Bug 452601] New: Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=452601

Summary: Review Request: perl-Business-CreditCard  -
                    Validate/generate credit card checksums/names
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://stahnma.fedorapeople.org/reviews/perl-Business-CreditCard.spec
SRPM URL: http://stahnma.fedorapeople.org/reviews/perl-Business-CreditCard-0.30-1.fc9....
Description: 
These subroutines tell you whether a credit card number is self-consistent
-- whether the last digit of the number is a valid checksum for the
preceding digits.

Note: To find license, I had to look in the actual Perl pm file.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |452450
              nThis|                            |

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-06-23 20:45 EST -------
*** Bug 244947 has been marked as a duplicate of this bug. ***

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-06-23 23:26 EST -------
Tibbs, since the other bug was closed without ever CVS branching, will this one
be reviewed or could we just branch the other one?  I can maintain either way.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-06-24 12:59 EST -------
FYI, it's just SOP to close old dead reviews as duplicates of new ones.  If I
can get a few minutes I'll go ahead and review this package; it should be trivial.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-06-24 14:46 EST -------
The copyright in the .pm file says the usual "Same as Perl", so the License: tag
should be "GPL+ or Artistic" as indicated in
http://fedoraproject.org/wiki/Licensing.  Yes, even though Artistic alone is not
acceptable for Fedora, people who get the software from us are still welcome to
use the software under those terms

Honestly, that's the only issue; you can just fix it when you check in.

* source files match upstream:
   1a052afd178419057dff025b8ea3ad003ab110bce270359d3af70ad18664e055  
   Business-CreditCard-0.30.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Business::CreditCard) = 0.30
   perl-Business-CreditCard = 0.30-1.fc10
  =
   perl >= 1:5
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
   perl(vars)

* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED; just fix up the License: tag when you check in.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-06-24 15:13 EST -------
New Package CVS Request
=======================
Package Name:   perl-Business-CreditCard 
Short Description: Validate/generate credit card checksums/names
Owners: stahnma
Branches:F8, F9, EL4, EL5
InitialCC:
Cvsextras Commits: Yes

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-06-24 20:18 EST -------
cvs done.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-07-03 10:05 EST -------
perl-Business-CreditCard-0.30-1.fc8 has been submitted as an update for Fedora 8

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-07-03 10:06 EST -------
perl-Business-CreditCard-0.30-1.fc9 has been submitted as an update for Fedora 9

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

------- Additional Comments From [e-mail]  2008-07-03 23:39 EST -------
perl-Business-CreditCard-0.30-1.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Business-CreditCard'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6084

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-07-08 22:40 EST -------
perl-Business-CreditCard-0.30-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-07-08 22:54 EST -------
perl-Business-CreditCard-0.30-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

------- Additional Comments From [e-mail]  2008-07-26 01:59 EST -------
perl-Business-CreditCard-0.30-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Business-CreditCard  - Validate/generate credit card checksums/names

https://bugzilla.redhat.com/show_bug.cgi?id=452601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=452601

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #13 from Petr Pisar  2011-07-26 04:19:41 EDT ---
Package Change Request
======================
Package Name: perl-Business-CreditCard
Branches: f14 f15
New InitialCC: perl-sig

Please add `perl-sig' pseudo-user to InitialCC group for all Fedora branches.
This cannot be done by maintainer through pkgdb interface.

[Bug 452601] Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=452601

--- Comment #14 from Jon Ciesla  2011-07-26 08:02:32 EDT ---
See 226258.