Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241597
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/HTML-Tidy/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-HTML-Tidy-1.08-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-HTML-Tidy.spec
Description: HTML::Tidy is an HTML checker in a handy dandy object. It's meant as a replacement for HTML::Lint. If you're currently an HTML::Lint user looking to migrate, see the section "Converting from HTML::Lint".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241597
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-HTML-Tidy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241597
------- Additional Comments From ville.skytta@iki.fi 2007-05-29 14:28 EST ------- Not assigning to myself because I (still) think that including the test suite code in the main package is not a good idea, but here's some notes:
make test fails at least in a devel x86_64 mach buildroot, and apparently for someone else too: http://rt.cpan.org/Public/Bug/Display.html?id=26875
"validation" is misleading in Summary; tidy is not a validator. "checking" and/or "cleanup" would be more accurate.
Cosmetic: could use perl in %prep for all in-place edits - now there's one sed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(cweyl@alumni.drew. | |edu)
------- Additional Comments From tibbs@math.uh.edu 2007-09-21 23:44 EST ------- I get 403: Forbidden when trying to fetch the package, and there's been no reply to the existing commentary. Setting NEEDINFO.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
------- Additional Comments From tibbs@math.uh.edu 2007-10-23 16:47 EST ------- So it seems that Chris is back. Chris, did you want to move forward with this package as well?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(cweyl@alumni.drew.| |edu) |
------- Additional Comments From cweyl@alumni.drew.edu 2007-11-18 15:00 EST ------- Ok, updated packages posted:
http://fedora.biggerontheinside.net/review/perl-HTML-Tidy.spec http://fedora.biggerontheinside.net/review/perl-HTML-Tidy-1.08-2.fc8.src.rpm
These packages build cleanly against the updated libtidy (yes, it was updated a while ago :)) and in F-8 mock.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |ruben@rubenkerkhof.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From ruben@rubenkerkhof.com 2008-01-20 08:38 EST ------- Hi Chris,
The package looks good to me, the only thing is that the webtidy script needs a dependency on LWP::Simple.
Checklist: * source matches upstream: 7912a2a739c6e2cfb6b409fb30b5047e18285dad HTML-Tidy-1.08.tar.gz * package is properly named according to the naming guidelines * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds fine in mock * package installs properly * rpmlint has no complaints. * final provides and requires are sane: [ruben@odin SPECS]$ rpm -q --provides perl-HTML-Tidy Tidy.so perl(HTML::Tidy) = 1.08 perl(HTML::Tidy::Message) perl-HTML-Tidy = 1.08-2.fc8 [ruben@odin SPECS]$ rpm -q --requires perl-HTML-Tidy /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.1.3) libtidy-0.99.so.0 perl >= 0:5.006001 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Getopt::Long) perl(HTML::Tidy) perl(HTML::Tidy::Message) perl(XSLoader) perl(base) perl(constant) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) * %check is present and succeeds * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * documentation is small, so no -doc subpackage is necessary.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
------- Additional Comments From cweyl@alumni.drew.edu 2008-01-20 14:37 EST ------- Thanks for the review! I'll add the dep on LWP::Simple prior to building.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
------- Additional Comments From cweyl@alumni.drew.edu 2008-01-20 14:43 EST ------- New Package CVS Request ======================= Package Name: perl-HTML-Tidy Short Description: (X)HTML cleanup in a Perl object Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-01-21 11:57 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
------- Additional Comments From ruben@rubenkerkhof.com 2008-03-08 12:25 EST ------- Chris, can you please import the package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object Alias: perl-HTML-Tidy
https://bugzilla.redhat.com/show_bug.cgi?id=241597
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2008-03-14 01:58 EST ------- *blush*
Imported and building for rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=241597
Nathanael Noblet nathanael@gnat.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nathanael@gnat.ca Flag|fedora-cvs+ |fedora-cvs?
--- Comment #11 from Nathanael Noblet nathanael@gnat.ca 2010-04-06 19:32:08 EDT --- Package Change Request ====================== Package Name: dspam Short Description: (X)HTML cleanup in a Perl object New Branches: EL-5 Owners: gnat InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=241597
--- Comment #12 from Chris Weyl cweyl@alumni.drew.edu 2010-04-06 19:38:29 EDT --- Branch request acked and approved. Enjoy! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=241597
--- Comment #13 from Kevin Fenzi kevin@tummy.com 2010-04-07 22:20:37 EDT --- Did you mean perl-HTML-Tidy here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=241597
--- Comment #14 from Nathanael Noblet nathanael@gnat.ca 2010-04-08 00:22:45 EDT --- ah yes sorry. totally meant perl-HTML-Tidy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=241597
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #15 from Kevin Fenzi kevin@tummy.com 2010-04-09 00:47:50 EDT --- cvs done.
package-review@lists.fedoraproject.org