https://bugzilla.redhat.com/show_bug.cgi?id=1894744
Bug ID: 1894744 Summary: Review Request: callaudiod - Call audio routing daemon Product: Fedora Version: rawhide Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: sorensentor@tuta.io QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gitlab.com/fedora-mobile/callaudiod/-/raw/master/callaudiod.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-33-x86... Description: Call audio routing daemon Fedora Account System Username: torbuntu
A new dependency which will be required for future versions of Calls: https://src.fedoraproject.org/rpms/calls
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
sorensentor@tuta.io changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sorensentor@tuta.io Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
sorensentor@tuta.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|unspecified |medium
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com ---
- This should go to the a devel subpackage:
%{_includedir}/libcallaudio-0/libcallaudio.h %{_libdir}/libcallaudio-0.so %{_libdir}/pkgconfig/libcallaudio-0.pc
- Don't repeat the name in the Summary, don't put a dot at the end of the summary, capitalize the summary:
callaudiod.src: W: summary-not-capitalized C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.src: W: summary-ended-with-dot C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.src: W: name-repeated-in-summary C callaudiod
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Header files in -devel subpackage, if present. Note: callaudiod : /usr/include/libcallaudio-0/libcallaudio.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3". 19 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/callaudiod/review- callaudiod/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: callaudiod : /usr/lib64/pkgconfig/libcallaudio-0.pc [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: callaudiod-0.0.4-1.fc34.x86_64.rpm callaudiod-0.0.4-1.fc34.src.rpm callaudiod.x86_64: W: summary-not-capitalized C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.x86_64: W: summary-ended-with-dot C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.x86_64: W: name-repeated-in-summary C callaudiod callaudiod.x86_64: W: unstripped-binary-or-object /usr/bin/callaudiocli callaudiod.x86_64: W: unstripped-binary-or-object /usr/bin/callaudiod callaudiod.x86_64: W: unstripped-binary-or-object /usr/lib64/libcallaudio-0.so.0 callaudiod.x86_64: W: devel-file-in-non-devel-package /usr/include/libcallaudio-0/libcallaudio.h callaudiod.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libcallaudio-0.so callaudiod.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libcallaudio-0.pc callaudiod.x86_64: W: no-manual-page-for-binary callaudiocli callaudiod.x86_64: W: no-manual-page-for-binary callaudiod callaudiod.src: W: summary-not-capitalized C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.src: W: summary-ended-with-dot C callaudiod is a daemon for dealing with audio routing during phone calls. callaudiod.src: W: name-repeated-in-summary C callaudiod callaudiod.src: W: invalid-url Source0: callaudiod-0.0.4.tar.gz 2 packages and 0 specfiles checked; 0 errors, 15 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
--- Comment #2 from Torrey Sorensen sorensentor@tuta.io --- Thank you for the review! I made the following edits and rebuilt: - created devel package for header and unversioned .so file. - Fixed the summary formatting.
Spec URL: https://gitlab.com/fedora-mobile/callaudiod/-/raw/master/callaudiod.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-33-x86...
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/callaudiod
https://bugzilla.redhat.com/show_bug.cgi?id=1894744
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|POST |CLOSED Last Closed| |2021-10-22 14:06:06
--- Comment #5 from Mattia Verga mattia.verga@protonmail.com --- This is now available in Fedora repos, closing.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com