https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Bug ID: 1448041 Summary: Review Request: python-metakernel - Metakernel for Jupyter Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mattias.ellert@physics.uu.se QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.grid.tsl.uu.se/review/python-metakernel.spec SRPM URL: http://www.grid.tsl.uu.se/review/python-metakernel-0.20.1-1.fc27.src.rpm
Description: A Jupyter/IPython kernel template which includes core magic functions (including help, command and file path completion, parallel and distributed processing, downloads, and much more).
Fedora Account System Username: ellert
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Mattias Ellert mattias.ellert@physics.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1448040
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1448040 [Bug 1448040] Review Request: python-ipyparallel - Interactive Parallel Computing with IPython
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
--- Comment #1 from Mattias Ellert mattias.ellert@physics.uu.se --- New upstream version:
Spec URL: http://www.grid.tsl.uu.se/review/python-metakernel.spec SRPM URL: http://www.grid.tsl.uu.se/review/python-metakernel-0.20.2-1.fc25.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
--- Comment #2 from Mattias Ellert mattias.ellert@physics.uu.se --- New version with tests in a separate subpackage:
Spec URL: http://www.grid.tsl.uu.se/review/python-metakernel.spec SRPM URL: http://www.grid.tsl.uu.se/review/python-metakernel-0.20.2-2.fc27.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@redhat.com Assignee|nobody@fedoraproject.org |tcallawa@redhat.com Flags| |fedora-review+
--- Comment #3 from Tom "spot" Callaway tcallawa@redhat.com --- Review ======= Notes: You will need to be careful with how you update this package. If it were my package, I would macroize the different versions/release values at the top:
%global metapyver 0.19.1 %global echover 0.19.1 %global bashver 0.19.1 # Reminder: Do I need to increment these release values? %global metapyrel 3 %global echorel 3 %global bashrel 3
It's easy to push an update and forget to change these values. I'm not sure if koji will notice if subpackages show up with identical nvr if the source nvr is different. Again, if it were me, I'd lock the release value (and never reset it back to 1) across all the subpackages just to ensure that I didn't accidentally screw it up. That said, I _know_ you know what you're doing here.
- rpmlint checks return: python2-metakernel-tests.noarch: W: no-documentation python3-metakernel-tests.noarch: W: no-documentation python2-metakernel-python.noarch: W: no-documentation python3-metakernel-python.noarch: W: no-documentation python2-metakernel-echo.noarch: W: no-documentation python3-metakernel-echo.noarch: W: no-documentation python2-metakernel-bash.noarch: W: no-documentation python3-metakernel-bash.noarch: W: no-documentation All safe to ignore - package meets naming guidelines - package meets python and general packaging guidelines - license (BSD) OK, text in %license, matches source - spec file legible, in am. english - source matches upstream (1c7e5badcf8505a550d01f2946d56d2160a5d163633503c97dfe39bc8b0e05f7) - package compiles on f26 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - -docs is appropriate - nothing in %doc affects runtime - no need for .desktop file
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-metakernel
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-metakernel-0.20.2-2.fc26 python-ipyparallel-6.0.2-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9c373ea651
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-ipyparallel-6.0.2-2.fc26, python-metakernel-0.20.2-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9c373ea651
https://bugzilla.redhat.com/show_bug.cgi?id=1448041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-09 15:23:31
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-ipyparallel-6.0.2-2.fc26, python-metakernel-0.20.2-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1448041 Bug 1448041 depends on bug 1448040, which changed state.
Bug 1448040 Summary: Review Request: python-ipyparallel - Interactive Parallel Computing with IPython https://bugzilla.redhat.com/show_bug.cgi?id=1448040
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com