Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=432262
Summary: Review Request: flobopuyo - 2-player falling bubbles game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: musuruan@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-2.fc8.src.rpm Description: A two-player falling bubbles game. The goal is to make groups of four or more Puyos (colored bubbles) to make them explode and send bad ghost Puyos to your opponent. You win the game if your opponent reaches the top of the board. You can play against computer or another human.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede@hhs.nl
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-02 07:22 EST ------- Andrea, do you want to swap reviews with one of these? :
* lbrickbuster2 - popular brickbusting arcadegame from lgames - bug 435514 * lure - Lure of the Temptress - Adventure Game - bug 435564
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |packages@amiga-hardware.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
------- Additional Comments From packages@amiga-hardware.com 2008-03-22 19:33 EST ------- * rpmlint: No Problems * Package named correctly: Yes * Patches named correctly: Yes * Spec file named correctly: Yes * Licence(s) acceptable: Yes * Licence field matches: Not Quite (!!) See below * Licence file installed: Yes and included upstream * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * %install contain rm -rf %{buildroot} or similar: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock i386/ppc/x86_64 in devel) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Generally yes (!!) see comments * Separate -doc needed (for large docs): N/A * %doc affects runtime: N/A * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: N/A * Owns files it didn't create: No * .desktop files included and installed correctly: Yes * Filenames valid UTF8: Yes
1. The files glSDL.h and glSDL.c are marked as LGPL, so the license field might need to be:
# glSDL.h and glSDL.c are LGPL+, all others are GPLv2+ License: GPLv2+ and LGPL+
2. Not a blocker, but macro usage could be improved a little, for example when referring to the man page.
Damn, I was playing this game for over an hour, before I remembered I was in the middle of a review! :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
------- Additional Comments From musuruan@gmail.com 2008-03-23 05:33 EST ------- Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-2.fc8.src.rpm
changelog * Sun Mar 23 2008 Andrea Musuruane musuruan@gmail.com 0.20-3 - Fixed License tag - Improved macro usage
I had to change LGPL+ to LGPLv2+. Rpmlint was complaining for good. There is no LGPLv1. BTW Good catch Ian!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-23 11:25 EST ------- (In reply to comment #2)
- The files glSDL.h and glSDL.c are marked as LGPL, so the license field
might need to be:
# glSDL.h and glSDL.c are LGPL+, all others are GPLv2+ License: GPLv2+ and LGPL+
Erm GPL trumps LGPL (as in the whole is distributed under the LGPL clause which says LGPL may be converted to GPL if you wish) so the whole can only be distributed under the GPL, and as such the license field should be just "GPLv2+"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From packages@amiga-hardware.com 2008-03-23 15:57 EST ------- (In reply to comment #3)
LGPLv1. BTW Good catch Ian!
Ugh, apparently not. BTW I think so you posted the wrong URL so I used.
http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-3.fc8.src.rpm
Looks good. No need to post another update, just revert the license back to GPLv2+ (sorry!) before import. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From musuruan@gmail.com 2008-03-24 05:00 EST ------- New Package CVS Request ======================= Package Name: flobopuyo Short Description: A two-player falling bubbles game. The goal is to make groups of four or more Owners: musuruan Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-24 12:52 EST ------- I assume the description here should be "A two-player falling bubbles game". If thats not the case, reset the fedora-cvs flag and I will update it.
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org