https://bugzilla.redhat.com/show_bug.cgi?id=2389251
Bug ID: 2389251 Summary: Review Request: davegnukem - scrolling side-view shooter Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://suve.fedorapeople.org/review/davegnukem-1.0.3-1/davegnukem.spec srpm: https://suve.fedorapeople.org/review/davegnukem-1.0.3-1/davegnukem-1.0.3-1.f... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136210083
Description: Dave Gnukem is a retro-style 2D scrolling platform shooter similar to, and inspired by, Duke Nukem 1 (~1991). The original Duke Nukem 1 had 16-color EGA 320x200 graphics; the aim here is "similar but different" gameplay and "look and feel". It is kind of a parody of the original.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://djoffe.com/gnukem/ Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9441385 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1364745 | |(FE-GAMESIG,GamingSIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- 1. Is there a particular reason why you can't replace: %setup -q -n dave_gnukem-%{version} %setup -q -n dave_gnukem-%{version} -D -T -a 1 with %setup -q -n dave_gnukem-%{version} -a 1 ?
2. Is there any particular reason to use double hyphen instead of a single one in patch file names? Patch0: gnukem--Makefile.patch Patch1: gnukem--BigEndian.patch
3. %{_mandir}/man6/%{name}.* Shouldn't this be: %{_mandir}/man6/%{name}.6* ?
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #3 from Artur Frenszek-Iwicki fedora@svgames.pl --- 1. Huh. Didn't know that would work. Thanks for the suggestion.
2. Not really, just personal preference.
3. Yep, it should. Good catch.
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #4 from Artur Frenszek-Iwicki fedora@svgames.pl --- Fixed 1) and 3) and backported the AppStream metainfo file.
spec: https://suve.fedorapeople.org/review/davegnukem-1.0.3-2/davegnukem.spec srpm: https://suve.fedorapeople.org/review/davegnukem-1.0.3-2/davegnukem-1.0.3-2.f... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=136603327
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2105423 --> https://bugzilla.redhat.com/attachment.cgi?id=2105423&action=edit The .spec file difference from Copr build 9441385 to 9509762
https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9509762 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com