[Bug 2373136] New: Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Bug ID: 2373136
           Summary: Review Request libtsm
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

I would like to unretire libtsm

Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Description:
TSM is a state machine for DEC VT100-VT520 compatible terminal emulators. It
tries to support all common standards while keeping compatibility to existing
emulators like xterm, gnome-terminal, konsole, ...

Fedora Account System Username: jfalempe

https://src.fedoraproject.org/rpms/libtsm

Reproducible: Always

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #1 from Neal Gompa  ---
Initial spec review:
> Version:        4.0.2^1.git69922bde

This should probably be "4.0.2^1.git%{shortcommit}"

You might want to macroize the "1" so it's easy to spot to update.
> Release:        0

This needs to be set to "1%{?dist}"

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/
> Group:          Development/Libraries/C and C++

This should be dropped, we don't use the Group tag at all.
> Source:         https://github.com/Aetf/libtsm/archive/%%7Bcommit%7D/%%7Bname%7D-%%7Bshortco...

This can be simplified to
"%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz"
> %package -n %{lname}

We don't typically do this in Fedora, this can be folded back into the main
"libtsm" package.
> %post -n %{lname} -p /sbin/ldconfig
> %postun -n %{lname} -p /sbin/ldconfig

This is useless in Fedora since Fedora 28 / RHEL 8.

Cf. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #2 from Neal Gompa  ---
Hey, is this spec file derived from another distribution's package? It looks
like an openSUSE-style package.

If it is, can we please put the openSUSE package changelog entries in here?

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #3 from Jocelyn Falempe  ---
I forked it from Michael Bryant (Shadow53)
https://copr.fedorainfracloud.org/coprs/shadow53/kmscon/package/libtsm/

From the git history of his repo, I don't see any reference to an opensuse
package.

Thanks for the review of the spec file, I will make the change.

Also I'm trying to make a release upstream, so I don't have to use commit sha.
https://github.com/Aetf/kmscon/issues/114

[Bug 2373136] Review Request libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #4 from Neal Gompa  ---
Hmm okay. It's weird because the openSUSE spec looks very similar:
https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/libt...

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request libtsm       |Review Request: libtsm -
                   |                            |DEC-VT terminal emulator
                   |                            |state machine

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #5 from Neal Gompa  ---
> Requires:       %{lname} = %{version}-%{release}

This needs should be "%{name}%{?_isa} = %{version}-%{release}" (assuming the
library subpackage is folded back into the main package as suggested).

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #6 from Fedora Review Service  ---
The ticket summary is not in the correct format.
Expected:

Review Request: <main package name here> - <short summary here>

Found:

Review Request libtsm

As a consequence, the package name cannot be parsed and submitted to
be automatically build. Please modify the ticket summary and trigger a
build by typing [fedora-review-service-build].

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #7 from Jocelyn Falempe  ---
(In reply to Neal Gompa from comment #1)
> > %package -n %{lname}
>
> We don't typically do this in Fedora, this can be folded back into the main
> "libtsm" package.

I'm sorry, I'm not sure what to do there. Should I just remove the lines with
%{lname} ?

I've started a MR with the other requested changes:
https://gitlab.com/kdj0c/copr-fedora/-/merge_requests/1/diffs

Thanks for fixing the bug title.

(In reply to Neal Gompa from comment #4)
> Hmm okay. It's weird because the openSUSE spec looks very similar:
> https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/
> libtsm.spec?expand=1

Hum, it looks like he has done some copy/paste from Suse when updating to use
Aetf's repo.
I can copy the changelogs from here (except the 2025 entry).
https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/libt...

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

I would like to unretire libtsm

Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Description:
TSM is a state machine for DEC VT100-VT520 compatible terminal emulators. It
tries to support all common standards while keeping compatibility to existing
emulators like xterm, gnome-terminal, konsole, ...

Fedora Account System Username: jfalempe

https://src.fedoraproject.org/rpms/libtsm

Reproducible: Always

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #8 from Jocelyn Falempe  ---
[fedora-review-service-build].

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #9 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

[fedora-review-service-build]

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |Unretirement

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #10 from Neal Gompa  ---
Created attachment 2096391
  --> https://bugzilla.redhat.com/attachment.cgi?id=2096391&action=edit
changelog entries from suse spec

(In reply to Jocelyn Falempe from comment #7)
> Hum, it looks like he has done some copy/paste from Suse when updating to
> use Aetf's repo.
> I can copy the changelogs from here (except the 2025 entry).
> https://build.opensuse.org/projects/X11:terminals/packages/libtsm/files/
> libtsm.changes?expand=1

Here's the changelog entries correctly formatted for you to inject.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #11 from Jocelyn Falempe  ---
Thanks, I merged it with the current changelog.

I didn't take the two last entries 2022 and 2025, because it was already
diverged from opensuse.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #12 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

[fedora-review-service-build]

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #13 from Jocelyn Falempe  ---
[fedora-review-service-build]

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #14 from Neal Gompa  ---
> Source:         %{url}/archive/refs/tags/v%{version}.tar.gz

This should use the format
"%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
> Group:          Development/Libraries/C and C++

This should be dropped.
> %autosetup  -n %{name}-%{version} -p1

This can be simplified to "%autosetup -p1"
> %{_libdir}/libtsm.so.*

This needs to have the soversion tracked, like so:
"%{_libdir}/libtsm.so.4{,.*}"

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_l...

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #15 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Thanks, I've made the requested changes.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #16 from Neal Gompa  ---
This looks great to me. At this point I think this package is good to go.

Review notes:

* Package follows Fedora Packaging Guidelines
* Package licensing is correct
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #17 from Jocelyn Falempe  ---
Thanks a lot for your review.

What are the next steps?

I'm not a Fedora packager, so I will probably need a sponsor.

Also I've applied the same review comments to the kmscon BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=2373128

So it should be easier to review.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

--- Comment #18 from Neal Gompa  ---
(In reply to Jocelyn Falempe from comment #17)
> Thanks a lot for your review.
>
> What are the next steps?
>
> I'm not a Fedora packager, so I will probably need a sponsor.

I have sponsored you as a packager. So now you need to follow the next steps to
import the package into Fedora.

Cf.
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Proc...

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #19 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/libtsm

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #20 from Fedora Update System  ---
FEDORA-2025-54ea3bf478 (libtsm-4.1.0-1.fc42) has been submitted as an update to
Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-54ea3bf478

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #21 from Fedora Update System  ---
FEDORA-2025-54ea3bf478 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2025-54ea3bf478 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-54ea3bf478

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2373136] Review Request: libtsm - DEC-VT terminal emulator state machine

https://bugzilla.redhat.com/show_bug.cgi?id=2373136

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2025-10-14 01:41:59

--- Comment #22 from Fedora Update System  ---
FEDORA-2025-54ea3bf478 (libtsm-4.1.0-1.fc42) has been pushed to the Fedora 42
stable repository.
If problem still persists, please make note of it in this bug report.