https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Bug ID: 1079718 Summary: Review Request: perl-Catalyst-Plugin-Compress - Compress Catalyst response Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: sven@consol.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://nierlein.com/fedora/perl-Catalyst-Plugin-Compress.spec SRPM URL: http://nierlein.com/fedora/perl-Catalyst-Plugin-Compress-0.005-1.fc21.src.rp... Description: Catalyst::Plugin::Compress is a Catalyst Plugin that compresses the returned page. Fedora Account System Username: sni
Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6664814
Since this is my first review request, docs state that i should ask for a sponsor.
This perl module is required to proceed in #1069988
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Sven Nierlein Sven.Nierlein@consol.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1069988
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1069988 [Bug 1069988] Review Request: naemon - Open Source Host, Service And Network Monitoring Program
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #1 from Sven Nierlein Sven.Nierlein@consol.de --- Spec file update according to comments of related bugs and uploaded new files to:
http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress-0.005-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #2 from Sven Nierlein Sven.Nierlein@consol.de --- Source RPM: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-Compress-0.005-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Catalyst-Plugin-Compre | |ss
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #3 from Sven Nierlein Sven.Nierlein@consol.de --- new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-Compress.spec
the only thing i changed is the release number.
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de
--- Comment #4 from Ralf Corsepius rc040203@freenet.de --- Missing [MUSTFIX]: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #5 from Sven Nierlein Sven.Nierlein@consol.de --- Sorry for the delay, i wanted to get through the review process with one module first and then work on the remaining review requests.
So here is the updated spec file: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-Compress-0.005-3....
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Sven Nierlein Sven.Nierlein@consol.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ddick@cpan.org Assignee|nobody@fedoraproject.org |ddick@cpan.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #6 from David Dick ddick@cpan.org --- Hi Sven,
The following BRs MUST be fixed.
--- perl-Catalyst-Plugin-Compress.old 2014-05-20 23:51:55.000000000 +1000 +++ perl-Catalyst-Plugin-Compress.spec 2014-05-21 21:02:00.988340126 +1000 @@ -8,16 +8,28 @@ Source0: http://www.cpan.org/modules/by-module/Catalyst/Catalyst-Plugin-Compress-%%7B... BuildArch: noarch BuildRequires: perl +BuildRequires: perl(Catalyst::Utils) +BuildRequires: perl(Config) +BuildRequires: perl(Cwd) +BuildRequires: perl(Fcntl) +BuildRequires: perl(File::Find) +BuildRequires: perl(File::Path) +BuildRequires: perl(File::Spec) +BuildRequires: perl(FindBin) +BuildRequires: perl(List::Util) BuildRequires: perl(Test::More) BuildRequires: perl(Catalyst::Runtime) >= 5.80001 BuildRequires: perl(Compress::Bzip2) >= 2 BuildRequires: perl(Compress::Zlib) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MM_Unix) BuildRequires: perl(MRO::Compat) +BuildRequires: perl(strict) +BuildRequires: perl(vars) +BuildRequires: perl(warnings) Requires: perl(Catalyst::Runtime) >= 5.80001 Requires: perl(Compress::Bzip2) >= 2 Requires: perl(Compress::Zlib) -Requires: perl(MRO::Compat) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description
The runtime "Requires: perl(MRO::Compat)" was removed as it is auto-detected. The other requirements cannot be auto-detected, so they were left. Once you apply these changes, this package should be good to go.
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #7 from Sven Nierlein Sven.Nierlein@consol.de --- Ok, thanks. I applied your patch and uploaded new files here: http://nierlein.com/fedora/2014-05-24/perl-Catalyst-Plugin-Compress.spec http://nierlein.com/fedora/2014-05-24/perl-Catalyst-Plugin-Compress-0.005-4....
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from David Dick ddick@cpan.org --- koji builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=6887280
License ok.
Build/Requires ok.
rpmlint is fine (incorrect spelling errors are the only output)
pure perl library. no C deps
fedora-review did not produce any errors/warnings
package APPROVED!
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Sven Nierlein Sven.Nierlein@consol.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Sven Nierlein Sven.Nierlein@consol.de --- New Package SCM Request ======================= Package Name: perl-Catalyst-Plugin-Compress Short Description: Compress response Owners: sni Branches: f21 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1079718
Sven Nierlein Sven.Nierlein@consol.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |0.005-4 Resolution|--- |RAWHIDE Last Closed| |2014-06-05 14:37:01
--- Comment #11 from Sven Nierlein Sven.Nierlein@consol.de --- build and upload ready
package-review@lists.fedoraproject.org