[Bug 1212047] New: Review Request: golang-github-hashicorp-go-syslog- Golang syslog wrapper, cross-compile friendly

List overview All Threads
Download

newer

older

[Bug 1214913] New: Review Request:...

[Bug 1003301] New: Review Request:...

Red Hat Bugzilla

15 Apr 2015 15 Apr '15

8:04 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Bug ID: 1212047 Summary: Review Request: golang-github-hashicorp-go-syslog- Golang syslog wrapper, cross-compile friendly Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jchaloup@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-hashicorp-go-syslog/...

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-hashicorp-go-syslog/...

Description: Golang syslog wrapper, cross-compile friendly

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9487809

$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-hashicorp-go-syslog-devel-0-0.1.git42a2b57.fc20.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

16 Apr 16 Apr

2:24 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog- Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Jan Chaloupka jchaloup@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1212318

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1212318 [Bug 1212318] Review Request: golang-github-hashicorp-serf- Service orchestration and management tool http://www.serfdom.io

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:25 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog- Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Jan Chaloupka jchaloup@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1208616

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1208616 [Bug 1208616] New Package Request: consul - Consul is a tool for service discovery and configuration. Consul is distributed, highly available, and extremely scalable.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2 Jun 2 Jun

9:50 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog- Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Pavel Odvody podvody@redhat.com changed:

--- Comment #1 from Pavel Odvody podvody@redhat.com --- Unowned directories.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: golang-github-hashicorp-go-syslog-devel-0-0.1.git42a2b57.fc21.noarch.rpm golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Requires -------- golang-github-hashicorp-go-syslog-devel (rpmlib, GLIBC filtered):

Provides -------- golang-github-hashicorp-go-syslog-devel: golang(github.com/hashicorp/go-syslog) golang-github-hashicorp-go-syslog-devel

Source checksums ---------------- https://github.com/hashicorp/go-syslog/archive/42a2b573b664dbf281bd48c3cc12c... : CHECKSUM(SHA256) this package : 378f5249729661db9d0c65030fbf636f6ec1d60ee926e67abf8c6dd7921d3907 CHECKSUM(SHA256) upstream package : 378f5249729661db9d0c65030fbf636f6ec1d60ee926e67abf8c6dd7921d3907

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/bin/fedora-review -b 1212047 Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Jun 17 Jun

11:06 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Lokesh Mandvekar lsm5@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:09 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Lokesh Mandvekar lsm5@redhat.com changed:

--- Comment #2 from Lokesh Mandvekar lsm5@redhat.com --- - specfile conforms to current golang packaging draft - license correct and valid - only sources installed for now

package approved

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:42 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Jan Chaloupka jchaloup@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #3 from Jan Chaloupka jchaloup@redhat.com --- New Package SCM Request ======================= Package Name: golang-github-hashicorp-go-syslog Short Description: Golang syslog wrapper, cross-compile friendly Upstream URL: https://github.com/hashicorp/go-syslog Owners: jchaloup Branches: f22 f21 el6 InitialCC: golang-sig

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Jun 18 Jun

10:01 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:01 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

19 Jun 19 Jun

9:19 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:19 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-syslog-0-...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:20 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-syslog-0-...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:21 a.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-hashicorp-go-syslog-0-...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Jun 20 Jun

4:15 p.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Jun 29 Jun

7:07 p.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Fedora Update System updates@fedoraproject.org changed:

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc21 has been pushed to the Fedora 21 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:22 p.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Fedora Update System updates@fedoraproject.org changed:

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.fc22 has been pushed to the Fedora 22 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Jul 8 Jul

12:02 p.m.

New subject: [Bug 1212047] Review Request: golang-github-hashicorp-go-syslog - Golang syslog wrapper, cross-compile friendly

https://bugzilla.redhat.com/show_bug.cgi?id=1212047

Fedora Update System updates@fedoraproject.org changed:

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-hashicorp-go-syslog-0-0.1.git42a2b57.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3667

Age (days ago)

3751

Last active (days ago)

package-review@lists.fedoraproject.org

16 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla