[Bug 2360957] New: Review Request: rust-testresult - Provides TestResult type for concise and precise test failures
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Bug ID: 2360957 Summary: Review Request: rust-testresult - Provides TestResult type for concise and precise test failures Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jjelen@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjelen.fedorapeople.org/rust-testresult.spec SRPM URL: https://jjelen.fedorapeople.org/rust-testresult-0.4.1-1.fc43.src.rpm Description: Provides TestResult type that can be used in tests to avoid unwraps but at the same time to have precise stacktraces with the point of failure clearly written. Fedora Account System Username: jjelen
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/te | |stresult
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8919429 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Jakub Jelen jjelen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2292911
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2292911 [Bug 2292911] rust-cryptoki-0.9.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Andreas Schneider asn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asn@redhat.com Assignee|nobody@fedoraproject.org |asn@redhat.com Flags| |fedora-review? Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Andreas Schneider asn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Andreas Schneider asn@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 16 files have unknown license. Detailed output of licensecheck in /home/asn/workspace/pkg/fedora/REVIEW/2360957-rust- testresult/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- testresult-devel , rust-testresult+default-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: rust-testresult-devel-0.4.1-1.fc42.noarch.rpm rust-testresult+default-devel-0.4.1-1.fc42.noarch.rpm rust-testresult-0.4.1-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpkjxa_8f9')] checks: 32, packages: 3
rust-testresult+default-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://crates.io/api/v1/crates/testresult/0.4.1/download#/testresult-0.4.1.... : CHECKSUM(SHA256) this package : 614b328ff036a4ef882c61570f72918f7e9c5bee1da33f8e7f91e01daee7e56c CHECKSUM(SHA256) upstream package : 614b328ff036a4ef882c61570f72918f7e9c5bee1da33f8e7f91e01daee7e56c
Requires -------- rust-testresult-devel (rpmlib, GLIBC filtered): /usr/bin/just /usr/bin/sh cargo
rust-testresult+default-devel (rpmlib, GLIBC filtered): cargo crate(testresult)
Provides -------- rust-testresult-devel: crate(testresult) rust-testresult-devel
rust-testresult+default-devel: crate(testresult/default) rust-testresult+default-devel
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Jakub Jelen jjelen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #3 from Jakub Jelen jjelen@redhat.com --- Built in rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=131857798
Added to release monitoring.
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-62ed3c0044 (rust-testresult-0.4.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-62ed3c0044
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-62ed3c0044 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-62ed3c0044 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-62ed3c0044
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2360957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2025-05-14 02:29:04
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-62ed3c0044 (rust-testresult-0.4.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com