[Bug 226411] New: Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

Summary: Merge Review: setserial
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: setserial

http://cvs.fedora.redhat.com/viewcvs/devel/setserial/
Initial Owner: [e-mail]

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
  BugsThisDependsOn|                            |163778

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-06 15:32 EST -------
Review for Release: 19.2.2

MUSTFIX:
there are a couple of problems with the spec and the patches
* the fhs patch has two errors
+mandir = @bindir@ <-- this should be @mandir@
+       $(STRIP) $(DESTDIR)$(bindir)/setserial -< should not be at all, leads to
empty debuginfo
* the readme patch should include references to Fedora, not Red Hat
* the spec does not include the preferred BUILDROOT, does not honor SMP
flags,uses %makeinstall instead of make install
Warning from rpmlint: Summary ends with dot

I will attach the fixes for all of the above. Please use whatever you find
useful and once corrected I will do the formal full review.

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

------- Additional Comments From [e-mail]  2007-02-06 15:33 EST -------
Created an attachment (id=147516)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147516&action=vie...)
fixes mandir and allows creating a debuginfo rpm

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

------- Additional Comments From [e-mail]  2007-02-06 15:34 EST -------
Created an attachment (id=147517)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147517&action=vie...)
replaces Red Hat with Fedora in instructions

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

------- Additional Comments From [e-mail]  2007-02-06 15:37 EST -------
Created an attachment (id=147518)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147518&action=vie...)
fixed spec. Beware, release is the SAME as the one that was in CVS/devel at
20:15 GMT/Feb 6th 2007

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

------- Additional Comments From [e-mail]  2007-02-06 19:21 EST -------
Forgot to mention, I did not add %{dist} to the Release field. If possible, it
should be added.

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]           |[e-mail]
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-02-07 05:42 EST -------
Thanks.  Tagged and built as 2.17-20.fc7.

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

------- Additional Comments From [e-mail]  2007-02-07 06:32 EST -------
The public accessible cvs server is not sync-ed yet. I'll do the review tonight.

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|163778                      |163779
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-07 12:48 EST -------
Formal review for release 2.17-20.fc7:

- package meets naming guidelines
- package meets packaging guidelines
- license is GPL (hence OK), matches source; upstream does not include the
license, so it isn't included in the package either
- spec file legible, in am. english
- source matches upstream, last available version, sha1sum
68824494a0b5700f7e999564a59358bf34f79eb1  setserial-2.17.tar.gz
- package bilds in mock for devel/x86_64
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all files and directories that it creates, does take not take ownership
of foreign files/directories
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no static, .pc, .la files
- no need for .desktop file
- rpmlint is silent on the source; there is one warning for the generated binary:
W: setserial spurious-executable-perm /usr/share/doc/setserial-2.17/rc.serial
It can be ignored, this is meant as an initscript which ( if needed ) must be
installed in /etc/init.d anyway

SHOULD
- builds cleanly in mock
- runs as advertised

TODO
- upstream should be bugged to included the license in the supplied tar.gz

APPROVED

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 226411] Merge Review: setserial

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial

https://bugzilla.redhat.com/show_bug.cgi?id=226411

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
  BugsThisDependsOn|163779                      |

------- Additional Comments From [e-mail]  2007-09-01 09:34 EST -------
depending on FE-ACCEPT is wrong, blocking it is not needed when fedora-review+
is set.