[Bug 701347] New: Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library - package-review

List overview All Threads
Download

newer

[Bug 701347] New: Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

older

[Bug 699586] New: Review Request:...

[Bug 457709] Review Request:...

Red Hat Bugzilla

2 May 2011 2 May '11

11:54 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Summary: Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalev@smartlink.ee QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---

Spec URL: http://kalev.fedorapeople.org/mingw32-gtkmm30.spec SRPM URL: http://kalev.fedorapeople.org/mingw32-gtkmm30-3.0.0-1.fc15.src.rpm Description: gtkmm is the official C++ interface for the popular GUI library GTK+. Highlights include type safe callbacks, and a comprehensive set of widgets that are easily extensible via inheritance.

This package contains the MinGW Windows cross compiled gtkmm library, API version 3.0.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by thread

Red Hat Bugzilla

2 May 2 May

11:57 a.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Kalev Lember kalev@smartlink.ee changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:27 p.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #1 from Thomas Sailer t.sailer@alumni.ethz.ch 2011-05-02 13:27:21 EDT --- Fedora review mingw32-gtkmm30-3.0.0-1.fc15.src.rpm 2011-05-02

+ OK ! needs attention

rpmlint output: $ rpmlint mingw32-gtkmm30-3.0.0-1.fc15.src.rpm mingw32-gtkmm30.spec mingw32-gtkmm30.src: W: spelling-error %description -l en_US gtkmm mingw32-gtkmm30.src:68: E: files-attr-not-set mingw32-gtkmm30.src:69: E: files-attr-not-set mingw32-gtkmm30.src:70: E: files-attr-not-set mingw32-gtkmm30.src:71: E: files-attr-not-set mingw32-gtkmm30.src:72: E: files-attr-not-set mingw32-gtkmm30.src:73: E: files-attr-not-set mingw32-gtkmm30.src:74: E: files-attr-not-set mingw32-gtkmm30.src:75: E: files-attr-not-set mingw32-gtkmm30.src:76: E: files-attr-not-set mingw32-gtkmm30.src:77: E: files-attr-not-set mingw32-gtkmm30.src:78: E: files-attr-not-set mingw32-gtkmm30.src:79: E: files-attr-not-set mingw32-gtkmm30.src:80: E: files-attr-not-set mingw32-gtkmm30.spec:68: E: files-attr-not-set mingw32-gtkmm30.spec:69: E: files-attr-not-set mingw32-gtkmm30.spec:70: E: files-attr-not-set mingw32-gtkmm30.spec:71: E: files-attr-not-set mingw32-gtkmm30.spec:72: E: files-attr-not-set mingw32-gtkmm30.spec:73: E: files-attr-not-set mingw32-gtkmm30.spec:74: E: files-attr-not-set mingw32-gtkmm30.spec:75: E: files-attr-not-set mingw32-gtkmm30.spec:76: E: files-attr-not-set mingw32-gtkmm30.spec:77: E: files-attr-not-set mingw32-gtkmm30.spec:78: E: files-attr-not-set mingw32-gtkmm30.spec:79: E: files-attr-not-set mingw32-gtkmm30.spec:80: E: files-attr-not-set 1 packages and 1 specfiles checked; 26 errors, 1 warnings.

All these rpmlint warnings and errors are harmless and can be ignored.

+ rpmlint output + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (LICENSE.txt) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 90bb087152a3214c2cc348aa04f917c3 gtkmm-3.0.0.tar.bz2 90bb087152a3214c2cc348aa04f917c3 Download/gtkmm-3.0.0.tar.bz2 ! The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8

Package cannot be scratch-built due to missing dependency (mingw32-gtk3). I suggest we first get mingw32-gtk3 in and then finalize this review. Thanks for doing this!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:29 p.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Thomas Sailer t.sailer@alumni.ethz.ch changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3 May 3 May

2:19 p.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #2 from Kalev Lember kalev@smartlink.ee 2011-05-03 15:19:47 EDT --- Yes, of course, mingw32-gtk3 should go in first. It's pending review in bug #700815 which is marked as blocking this ticket.

Thanks for taking the review, Tom!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9 May 9 May

9:21 a.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #3 from Kalev Lember kalev@smartlink.ee 2011-05-09 10:21:46 EDT --- * Mon May 09 2011 Kalev Lember kalev@smartlink.ee - 3.0.1-1 - Update to 3.0.1

Spec URL: http://kalev.fedorapeople.org/mingw32-gtkmm30.spec SRPM URL: http://kalev.fedorapeople.org/mingw32-gtkmm30-3.0.1-1.fc15.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 May 29 May

10:58 a.m.

New subject: [Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Bug 701347 depends on bug 700815, which changed state.

Bug 700815 Summary: Review Request: mingw-gtk3 - MinGW Windows GTK+ library https://bugzilla.redhat.com/show_bug.cgi?id=700815

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:51 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Kalev Lember kalev@smartlink.ee changed:

--- Comment #4 from Kalev Lember kalev@smartlink.ee 2011-05-29 13:51:44 EDT --- mingw32-gtk3 is imported and built, so it's no longer blocking this review.

* Sun May 29 2011 Kalev Lember kalev@smartlink.ee - 3.0.1-2 - Renamed the base package to mingw-gtkmm30 as per updated guidelines - Use the automatic dep extraction available in mingw32-filesystem 68

Spec URL: http://kalev.fedorapeople.org/mingw-gtkmm30.spec SRPM URL: http://kalev.fedorapeople.org/mingw-gtkmm30-3.0.1-2.fc15.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3099122

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

30 May 30 May

8:38 a.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #5 from Thomas Sailer t.sailer@alumni.ethz.ch 2011-05-30 09:38:28 EDT --- Fedora review mingw-gtkmm30-3.0.1-2.fc15.src.rpm 2011-05-30

+ OK ! needs attention

Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3100290

rpmlint: $ rpmlint mingw-gtkmm30.spec mingw-gtkmm30-3.0.1-2.fc15.src.rpm mingw32-gtkmm30-debuginfo-3.0.1-2.fc16.noarch.rpm mingw32-gtkmm30-3.0.1-2.fc16.noarch.rpm mingw-gtkmm30.src: W: spelling-error %description -l en_US gtkmm mingw32-gtkmm30-debuginfo.noarch: E: debuginfo-without-sources mingw32-gtkmm30.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gtkmm30-3.0.1/COPYING 3 packages and 1 specfiles checked; 2 errors, 1 warnings.

! the fsf address issue should be addressed. Did you or do you know whether the native package maintainer has contacted upstream?

! rpmlint output + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 169ed5b088538fa10483177f3035f77c gtkmm-3.0.1.tar.bz2 169ed5b088538fa10483177f3035f77c Download/gtkmm-3.0.1.tar.bz2 + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3 Jun 3 Jun

12:20 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #6 from Kalev Lember kalev@smartlink.ee 2011-06-03 13:20:41 EDT --- (In reply to comment #5)

...

mingw32-gtkmm30.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gtkmm30-3.0.1/COPYING 3 packages and 1 specfiles checked; 2 errors, 1 warnings.

! the fsf address issue should be addressed. Did you or do you know whether the native package maintainer has contacted upstream?

Filed a bug with the upstream bug tracker: https://bugzilla.gnome.org/show_bug.cgi?id=651797

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:58 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #7 from Thomas Sailer t.sailer@alumni.ethz.ch 2011-06-03 14:58:51 EDT --- Looks good, thanks!

APPROVED by sailer.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:06 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #8 from Kalev Lember kalev@smartlink.ee 2011-06-03 15:06:58 EDT --- Thanks Thomas!

Can you set the fedora‑review flag too please?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:13 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Thomas Sailer t.sailer@alumni.ethz.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:30 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #9 from Kalev Lember kalev@smartlink.ee 2011-06-03 15:30:02 EDT --- New Package SCM Request ======================= Package Name: mingw-gtkmm30 Short Description: MinGW Windows C++ interface for the GTK+ library Owners: kalev thomasj epienbro Branches: f15 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:30 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Kalev Lember kalev@smartlink.ee changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:50 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #10 from Jon Ciesla limb@jcomserv.net 2011-06-03 15:50:39 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:54 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #11 from Kalev Lember kalev@smartlink.ee 2011-06-03 15:54:01 EDT --- Grr, don't ask me why I put thomasj instead of sailer in there, sorry ...

Tom, can you request the ACLs in pkgdb please?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:53 p.m.

New subject: [Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701347

Kalev Lember kalev@smartlink.ee changed:

--- Comment #12 from Kalev Lember kalev@smartlink.ee 2011-06-03 16:53:02 EDT --- Package imported and built, closing the ticket.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5163

Age (days ago)

5195

Last active (days ago)

package-review@lists.fedoraproject.org

17 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla