[Bug 2322184] New: Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

Bug ID: 2322184
           Summary: Review Request: rust-asn1-rs-derive - Derive macros
                    for rust-asn1-rs crate
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://raw.githubusercontent.com/tylerfanelli/rust-asn1-rs-derive_candidate...
SRPM URL:
https://github.com/tylerfanelli/rust-asn1-rs-derive_candidate/raw/refs/heads...
Description: Derive macros for rust-asn1-rs crate
Fedora Account System Username: tfanelli

[Bug 2322184] Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/as
                   |                            |n1-rs-derive
           Keywords|                            |AutomationTriaged

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8184261
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2322184] Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

Tyler Fanelli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(decathorpe@gmail.
                   |                            |com)

--- Comment #3 from Tyler Fanelli  ---
Hi Fabio,

I've submitted all required information and the build succeeded, I just need
approval to continue with the new package process.

For the future, am I able to do this process on my own, without the approval of
anyone else? I only ask because I have to introduce a few more packages and
don't want to interrupt others if not necessary.

[Bug 2322184] Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
              Flags|needinfo?(decathorpe@gmail. |
                   |com)                        |
         Resolution|---                         |DUPLICATE
        Last Closed|                            |2024-10-30 10:46:28

--- Comment #4 from Fabio Valentini  ---
> For the future, am I able to do this process on my own, without the approval of anyone else?

No, all new packages need approval by a second person.
To some degree, I really wonder how you got to be a packager without knowing
these basics 😅

Additionally, in this case, a request for this package was already submitted
elsewhere, so I'll close this one as a duplicate.

*** This bug has been marked as a duplicate of bug 2312632 ***

[Bug 2322184] Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

Cole Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Cole Robinson  ---
(In reply to Fabio Valentini from comment #4)
> > For the future, am I able to do this process on my own, without the approval of anyone else?
>
> No, all new packages need approval by a second person.
> To some degree, I really wonder how you got to be a packager without knowing
> these basics 😅

Lame and unhelpful comment. Not everyone lives and breaths fedora policy and
packaging.

I think it's reasonable for someone who rarely submits new packages to ask
if there's a simpler process they are missing, especially considering how much
you've helped streamline the rust package process with rust2rpm

[Bug 2322184] Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate

https://bugzilla.redhat.com/show_bug.cgi?id=2322184

--- Comment #6 from Fabio Valentini  ---
I apologize for yesterday's quip - it was indeed not helpful.

I guess the NEEDINFO request for me threw me off - at least in Fedora, it's
only used for really important actions and many contributors perceive it as
"aggressive nagging". Just CCing me on this bug would have sufficed to get my
attention.
> I think it's reasonable for someone who rarely submits new packages to ask
> if there's a simpler process they are missing, especially considering how much
> you've helped streamline the rust package process with rust2rpm

I'm happy that you perceive it as streamlined.

But no, there are usually no shortcuts you can take for adding a new package to
Fedora - with some small exceptions,
see
https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#...

wrt/ Rust packages, the only relevant exception is usually the one for "compat"
packages, i.e. for providing more than one version of a crate that is already
packaged.