https://bugzilla.redhat.com/show_bug.cgi?id=1544384
Bug ID: 1544384 Summary: Review Request: tcl-thread - Tcl Thread extension Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://src.fedoraproject.org/fork/vascom/rpms/tcl-thread/raw/master/f/tcl-t... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4407/24964407/tcl-thread-2.8....
Description: Thread extension for the Tcl toolkit. You can use this extension to gain script level access to Tcl threading capabilities.
Homepage http://tcl.sourceforge.net/
This package already was in repo but retired. I am want unretire and update it.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@easycoding.org Assignee|nobody@fedoraproject.org |vitaly@easycoding.org
--- Comment #1 from Vitaly Zaitsev vitaly@easycoding.org --- I will review this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
%global debug_package %{nil}
Remove this row. Your package contains binaries, so they need to be stripped into debuginfo package.
Requires: tcl(abi) = 8.6
You don't need to specify ABI version. Rpmbuild will do it automatically.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #3 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://src.fedoraproject.org/fork/vascom/rpms/tcl-thread/raw/master/f/tcl-t... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6624/24966624/tcl-thread-2.8....
Debuginfo package enabled. Requires of tcl(abi) = 8.6 is necessary because not processing automatically.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Header files in -devel subpackage, if present. Note: tcl-thread-debugsource : /usr/src/debug/tcl- thread-2.8.2-1.fc28.x86_64/generic/psGdbm.h tcl-thread-debugsource : /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/tclThread.h tcl- thread-debugsource : /usr/src/debug/tcl- thread-2.8.2-1.fc28.x86_64/generic/tclThreadInt.h tcl-thread-debugsource : /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/tclXkeylist.h tcl-thread-debugsource : /usr/src/debug/tcl- thread-2.8.2-1.fc28.x86_64/generic/threadSpCmd.h tcl-thread-debugsource : /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/threadSvCmd.h tcl- thread-debugsource : /usr/src/debug/tcl- thread-2.8.2-1.fc28.x86_64/generic/threadSvKeylistCmd.h tcl-thread- debugsource : /usr/src/debug/tcl- thread-2.8.2-1.fc28.x86_64/generic/threadSvListCmd.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/tcl-thread See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Packag...
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "NTP", "Unknown or generated". 71 files have unknown license. Detailed output of licensecheck in /home/vitaly/1544384-tcl-thread/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(kde- platform-plugin, nethogs, libhbalinux, cups-client, rsyslog, rpm- plugin-selinux, libimagequant, giflib, libreoffice-graphicfilter, xsel, trousers, dirac-libs, libdb-utils, xorg-x11-font-utils, OpenEXR- libs, libcom_err, libseccomp, ksysguardd, icoutils, p11-kit, libabw, mpgtx, gtkspell, libid3tag, libmodman, xdotool, dolphin-plugins, parted, kf5-kcontacts, libdvdread, zstd, kgreeter-plugins, bluez-libs, libbs2b, kf5-kjobwidgets, libwebp, libxslt, system-config-printer- udev, perl-Encode, elfutils, python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error, lvm2-libs, kf5-sonnet-core, perl-Digest-SHA, reaver, perl-Params-Classify, kf5-solid, sddm, libzstd, liblognorm, wxBase, symlinks, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio- libs, usermode-gtk, lcms2, deltarpm, libxcb, libyubikey, python3-pycurl, openconnect, xcb-util-keysyms, kf5-threadweaver, libgphoto2, iw, tinyxml, xcb-util, libwmf-lite, mc, http-parser, qt5-qtspeech, pulseaudio-utils, perl-Sub-Identify, dolphin, kf5 -kdelibs4support-libs, libeot, ImageMagick-c++, systemd-bootchart, uniconvertor, kf5-kpackage, kf5-kfilemetadata, perl-Ref-Util-XS, perl- Time-Piece, dbusmenu-qt, qca-qt5, ncurses-libs, libidn2, ldns, perl- Sys-Syslog, fcoe-utils, qhexedit2-qt5-libs, xorg-x11-xkb-utils, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, kf5 -kglobalaccel-libs, xmlrpc-c-client, sane-backends-drivers-cameras, python3-hawkey, libwpd, enchant2, libdc1394, perl-Time-HiRes, libwps, gssdp, cln, kactivitymanagerd, gimagereader-qt, libacl, xorg-x11-drv- ati, kf5-solid-libs, libSM, policycoreutils, mcelog, samba-common- tools, libgdiplus, libmusicbrainz5, pptp, sane-backends-drivers- scanners, libXxf86misc, foomatic, python3-reportlab, minizip, libpath_utils, rpm-build, libglvnd-gles, rpm-plugin-systemd-inhibit, rpm-sign, freeglut, gstreamer1, libnatspec, libtomcrypt, dbus-libs, libreoffice-gtk3, libreoffice-gtk2, optipng, librtmp, cairo-gobject, libkkc, sgpio, gutenprint, openal-soft, usermode, libfbclient2, qpdf- libs, linux-atm-libs, pyparted, libedit, openssh, atk, python3-cairo, SDL_net, accountsservice, isl, hfsplus-tools, krename, ImageMagick, perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-btrfs, libatomic_ops, libmpcdec, gtk-update-icon-cache, ntpdate, kf5-kxmlgui, NetworkManager, libkate, liblangtag, NetworkManager-glib, libdatrie, qcustomplot-qt5, linuxconsoletools, setuptool, ksysguard, kscreenlocker, SDL_sound, guile, pcre-utf16, tree, isdn4k-utils, gnupg, cronie-anacron, xfsprogs, libhbaapi, libcroco, qt5-qtsensors, plymouth-plugin-label, colord-libs, nvidia-settings, aalib-libs, gstreamer1-libav, kdegraphics-thumbnailers, libcddb, gpgmepp, gwenview, libkgapi, libtranslit-m17n, cronie, libexttextcat, kdelibs, qt5-qtquickcontrols, libuv, nettle, colord, libpipeline, pkcs11-helper, kf5-libkdcraw, kde-print-manager, findutils, popt, x265, plasma-desktop, qt5-qtx11extras, libsss_idmap, libraw1394, boost-atomic, kf5-kross-ui, python3-dbus, iproute-tc, isomd5sum, libupnp, qca-gnupg, kruler, coolkey, python2-numpy, dotconf, luajit, libXfont, patch, sqlitebrowser, sqlite-libs, lttng-ust, xcb-util- cursor, enchant, kf5-plasma, libXxf86dga, libwayland-client, kf5-kio- file-widgets, libipt, mdadm, pidgin-birthday-reminder, kf5 -kactivities-stats, device-mapper, ldns-utils, python2-librepo, libXtst, finger, xapian-core-libs, irqbalance, kf5-kbookmarks, GeoIP, libpano13, GraphicsMagick, libsigc++20, python2-talloc, libXrandr, newt, liba52, hplip, okular-libs, crda, libical, qt5-qtdeclarative, kf5-libkexiv2, vo-amrwbenc, qt5-qtquickcontrols2, libftdi, cpprest, libXfont2, libblockdev-loop, libmfx, libssh2, NetworkManager-adsl, plasma-nm-pptp, qimageblitz, dbusmenu-qt5, libXcursor, dracut, kaccounts-integration, procps-ng, plymouth-core-libs, telnet, libXpm, phonon-backend-gstreamer, xorg-x11-drv-nouveau, libotr, zlib, qgpgme, pam_krb5, gutenprint-cups, avahi, libselinux, libassuan, expat, cups- filters, libxmp, userspace-rcu, libgudev, libbsd, live555, make, khelpcenter, libnice, libzip, libsoup, python-nss, kmousetool, perl- Net-SSLeay, perl-Filter, cups-libs, libdrm, kget-libs, libsepol, gzip, autogen-libopts, keyutils, libipa_hbac, libfdisk, libdmx, kdiff3, openssl-libs, pcre2, opencc, okular, prison, ipset, boost-chrono, libselinux-python3, kf5-kcoreaddons, ntfs-3g, kf5-kjsembed, fuse-libs, poedit, xorg-x11-xauth, libglvnd-glx, libktorrent, gvfs-smb, gtkspell3, libcue, herqq, json-glib, kf5-kglobalaccel, libX11-xcb, libfontenc, libicu, xorg-x11-drv-vmware, NetworkManager-openconnect, btrfs-progs, bind99-libs, perl-Devel-PPPort, xerces-c, mesa-libglapi, purple-skypeweb, glx-utils, libtommath, libquadmath, perl-MIME-Base64, polkit-qt5-1, libass, SDL_image, libstdc++, ppp, python2-crypto, libtiger, git, perl-Compress-Raw-Bzip2, libcrystalhd, jack-audio- connection-kit, mpg123-libs, opus, libselinux-python, tcpdump, libxklavier, traceroute, cyrus-sasl-plain, kde-style-breeze, libblockdev-crypto, gconfmm26, kf5-karchive, pcsc-lite-ccid, libreoffice-pdfimport, rp-pppoe, libtheora, kmix, attr, mtr, okular- part, libblockdev-part, pugixml, plymouth, libcanberra-gtk3, cld2, gstreamer1-plugins-bad-free-gtk, libXrender, mtdev, mailx, kwin, systemd-udev, libXvMC, kf5-kimageformats, check, kdepimlibs- kxmlrpcclient, kmahjongg, python2-pillow, libXmu, kget, lucene++, smartmontools, jasper-libs, rubberband, device-mapper-libs, xorg-x11-xinit, marisa, libogg, libffi, libGLEW, python2-hawkey, diffutils, chrony, time, glibc, mpfr, kf5-knotifyconfig, cyrus-sasl- md5, iputils, kate4-part, numactl-libs, recode, gpgme, kf5-kded, xorg-x11-drv-openchrome, libmcpp, konsole5-part, libnfsidmap, mpg123, gdb-headless, libqmi-utils, libmbim-utils, psacct, lame-libs, VirtualBox, libtirpc, iptables-libs, cryptsetup-libs, SDL2_image, bind-libs, pygobject2, mesa-libwayland-egl, PyQt4, ghostscript-x11, lua-posix, libinput, iperf, kf5-syntax-highlighting, libpkgconf, mono- core, signon-plugin-oauth2, gegl, qt5-qtconnectivity, id3lib, libabigail, im-chooser, qt5-qtsvg, pidgin-otr, libreoffice-calc, sni- qt, libqmi, gawk, dmraid-events, pcsc-lite-libs, libbasicobjects, plasma-integration, kdelibs-webkit, libobjc, nmap, perl-Devel-Peek, filezilla, libdvbpsi, libsmbclient, python2-reportlab, libvdpau, compat-openssl10, perl-Guard, opencore-amr, ntsysv, recordmydesktop, dbus-python, oddjob-mkhomedir, kf5-kidletime, openCOLLADA, xcb-util- renderutil, pavumeter, nmap-ncat, logrotate, kf5-kcmutils, irrXML, libdnet, flann, ntfsprogs, appstream-qt, protobuf, kf5-kio-ntlm, samba-common-libs, libpsl, mpg123-plugins-pulseaudio, python3-rpm, librcc, librcd, jimtcl, libuser, lz4-libs, boost-date-time, tmpwatch, libglade2, kf5-kwallet, pixman, gtk2-immodule-xim, kf5-kparts, wpa_supplicant, xorg-x11-drv-vesa, libbluray, cifs-utils, openjpeg, libbabeltrace, libfastjson, vpnc, psmisc, net-snmp-libs, xorg-x11-drv- libinput, libiodbc, libblockdev-mpath, cairo, eb, libgcc, libmng, ilmbase, perl-Compress-Bzip2, poppler, kf5-akonadi-contacts, libstemmer, djvulibre-libs, fftw-libs-double, net-tools, ModemManager, procmail, qt5-qtbase-gui, rtkit, orc, kdepimlibs-gpgme, polkit, libuuid, faad2-libs, libarchive, libfreehand, cryptsetup, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, cryptsetup-python, mtools, pygtk2, vim-minimal, harfbuzz-icu, libkdegames, libplist, checkpolicy, libmimic, xdg-user-dirs, kwin- common, paman, perl-Event, gdk-pixbuf2, audacious-plugins-freeworld- ffaudio, svgalib, kcalc, gupnp, authconfig, libevent, redland, python2-cccolutils, libpciaccess, git-core, imsettings-qt, libblockdev, spectacle, dconf, xz-libs, perl-IO-AIO, dbus-glib, libdvdnav, gwenview-libs, libcap, libprojectM, kf5-attica, avahi- tools, kinfocenter, libwbclient, libkmahjongg, kteatime, kf5-kio- widgets-libs, kmod-VirtualBox-4.14.18-300.fc27.x86_64, kf5-ki18n, libthai, fakeroot, kwebkitpart, qt5-qttools-libs-designer, nss-tools, iproute, python2-gpg, libsmartcols, konsole5, fakeroot-libs, leptonica, chmlib, libwpg, os-prober, ethtool, qt5-qttools-libs- designercomponents, libfprint, systemd-libs, cpio, util-linux, oxygen- gtk2, smplayer, imsettings, krb5-libs, libconfig, enca, rmt, python3-qt5, perl-Net-LibIDN, clucene-core, kmod, libxml++, NetworkManager-pptp, libetonyek, screen, kf5-kiconthemes, libpagemaker, kf5-kitemviews, libxkbcommon, pinentry-qt, device- mapper-multipath-libs, yajl, lockdev, kdesu, cups-filters-libs, kf5-knotifications, poppler-utils, biosdevname, lpsolve, grantlee-qt5, xorg-x11-server-utils, vid.stab, cracklib, libdnf, goldendict, libgdl, libdbusmenu-gtk3, libdbusmenu-gtk2, pulseaudio-libs-glib2, libnice- gstreamer1, qtsoap, nm-connection-editor, python-xpyb, libudisks2, gstreamer1-plugins-bad-free, kf5-kholidays, zenity, chkconfig, libquicktime, libgnome-keyring, hostname, kdialog, librados2, subunit, pam, python2-cffi, libkscreen-qt5, openldap, gamin, kf5-ktexteditor, ipcalc, SDL, kde-print-manager-libs, fdupes, speex, audacious-libs, libspnav, neon, libkworkspace, libsamplerate, python2-lxml, newt- python3, samba-libs, boost-iostreams, logstalgia, pakchois, gamin- python, lapack, libgee06, libusbmuxd, perl-Unicode-Normalize, gperftools-libs, libimobiledevice, NetworkManager-wwan, polkit-pkla- compat, libmtp, kde-gtk-config, librevenge, hexchat, iftop, nspr, python3-gobject-base, gnupg2-smime, dnsmasq, libXfixes, libblkid, kdnssd, libcdio, kf5-kactivities-libs, rsync, samba-winbind, lua-libs, pavucontrol, perl-Params-Util, soundtouch, xorg-x11-drv-evdev, libXinerama, lirc-libs, khotkeys, libteam, vim-enhanced, libcmis, qt5-qttools, elfutils-libs, pcmciautils, acl, cyrus-sasl-scram, ark- libs, xorg-x11-apps, gupnp-igd, kf5-kinit, gnupg2, kf5-khtml, libgee, rdist, qjson, mesa-libEGL, systemd-pam, libkscreen, ftgl, perl- Storable, perl-Digest-MD5, libshout, soprano, keditbookmarks, perl- Sort-Key, ksshaskpass, nss-util, libsemanage, libstorj, systemd- container, libcomps, at, gtk3-immodule-xim, libsidplayfp, vamp-plugin- sdk, kf5-kcompletion, libblockdev-fs, kpat, libgnomecanvas, libnma, gettext, soxr, espeak, libverto-tevent, python-cheetah, kf5-gpgmepp, libaccounts-glib, libmetalink, libewf, slang, kate-plugins, usbutils, e2fsprogs, kf5-frameworkintegration-libs, libcdio-paranoia, grub2 -tools-minimal, cpp, libksba, kdecoration, libwayland-server, gdbm, libpurple, libsndfile, libvisio, tk, bzip2-libs, qt5-qtxmlpatterns, mpv, gnutls, jack-audio-connection-kit-example-clients, kf5-kpeople, device-mapper-persistent-data, ykpers, libselinux-utils, perl-Scalar- List-Utils, dosfstools, rng-tools, libspectre, nano, keyutils-libs, libproxy, libreoffice-math, perl-Data-Dumper, kf5-kpty, pidgin, kgpg, qt5-qttools-libs-help, libkworkspace5, tesseract, plasma-pa, libatasmart, perl-XML-Parser, mlocate, file-libs, grub2-tools, avahi- glib, libblockdev-swap, libnetfilter_conntrack, python3-gobject, qca, ocl-icd, pidgin-libnotify, fprintd-pam, blas, libee, libusbx, python3-pygpgme, kf5-kconfig-gui, qrencode-libs, libICE, drpm, xsane, createrepo_c-libs, purple-hangouts, kf5-kio-core, libgpod, perl- Compress-Raw-Zlib, libindicator-gtk3, speexdsp, libntlm, upower, p7zip, libreoffice-x11, xcb-util-wm, openssl, qtspell-qt5, socat, gnome-vfs2, PackageKit-Qt5, alsa-lib, x264-libs, python2-gobject, gtkmm24, PyYAML, mesa-dri-drivers, pyliblzma, libffado, suitesparse, lha, fribidi, libgnomekbd, pciutils, libini_config, openssh-clients, kf5-libktorrent, libX11, htop, python3-cryptography, gparted, systemd, kwrited, u2f-hidraw-policy, libnl3, gimp-libs, libmikmod, libidn, grubby, kf5-kio-gui, openjpeg-libs, kcharselect, libdbusmenu, libbytesize, filelight, libmpeg2, powerdevil, python3-systemd, libnl3-cli, ibus-libs, python2-libcomps, kmenuedit, qbittorrent, audit-libs, libdb-cxx, bluez, gettext-libs, liborcus, kf5-kwidgetsaddons, ftp, NetworkManager-bluetooth, libref_array, liboath, raptor2, kf5-networkmanager-qt, libcrypt-nss, plymouth- plugin-two-step, sbc, qt-x11, libsane-hpaio, libhangul, bash, poppler- glib, potrace, python3-tinycss, libblockdev-lvm, libopenraw, lvm2, harfbuzz, cups, dmraid, purple-matrix, libva, gvfs-client, NetworkManager-libnm, audacious-plugins-freeworld-mms, python2-libs, perl-BDB, lrzsz, libglvnd-egl, opusfile, dhcp-libs, libtalloc, grep, ffmpeg, plasma-nm-openconnect, libepoxy, kf5-baloo-libs, kf5-kdelibs4support, perl-Variable-Magic, man-db, kf5-kcalendarcore, audacious-plugin-fc, libgadu, liblogging-stdlog, timedatex, yaml- cpp03, qt5-qtenginio, kf5-bluez-qt, rasqal, wireless-tools, libdb, passwd, cups-pk-helper, quota, kmod-libs, libdv, gutenprint-libs, lm_sensors-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, purple-plugin_pack-pidgin, libmwaw, flite, libusal, libunwind, OpenColorIO, gtkmm30, libsemanage-python, libgit2, qt5-qtmultimedia, stunnel, kwrite, kscreen, gobject-introspection, kf5 -kconfig-core, libpwquality, kf5-knewstuff, fontconfig, jbigkit-libs, kf5-kservice, python3-sip, meanwhile, python3-PyQt4, perl-Math-BigInt- FastCalc, rest, libtar, libdaemon, lzma-sdk457, easytag, python3-librepo, libaccounts-qt5, pkgconf, json-c, kf5-kauth, sed, pygtk2-libglade, ark, perl-threads-shared, glib-networking, mjpegtools-lav, python3-qt5-base, kpartx, libpng, ghostscript-core, sane-backends-libs, python3-pillow, qt5-qtwebsockets, mesa-libgbm, cyrus-sasl, hardlink, libcollection, libgcrypt, plasma-nm, cairomm, perl-Unicode-UTF8, nss-softokn, python3-numpy, lsof, binutils, libreoffice-impress, twolame-libs, xorg-x11-server-Xorg, usbmuxd, libmbim, plasma-workspace-libs, perl-IO, VirtualBox-server, libverto, glibmm24, openrdate, dosbox, libXScrnSaver, realmd, libmspub, grantlee, ncurses, graphite2, python3-kerberos, passwdqc-lib, imlib2, libmad, libde265, libpng15, gmp, irda-utils, volume_key-libs, b43-fwcutter, farstream02, ffmpeg-libs, poppler-qt, alsa-plugins- pulseaudio, perl-interpreter, ebook-tools-libs, libksysguard-common, gimp, libcurl, kf5-kcrash, miniz, coreutils, python-krbV, libcap-ng, gvfs, dbus-x11, signon, pinentry, alsa-tools-firmware, librepo, shapelib, kde-cli-tools, gsm, gsl, qt4-style-oxygen, boost-filesystem, libtevent, kf5-sonnet-ui, samba-winbind-clients, openblas-threads, libglvnd, boost-system, libpcap, wxBase3, im-chooser-common, snappy, rb_libtorrent, libindicator, libxdo, cyrus-sasl-lib, libdmtx, libfc14audiodecoder, qwt, numactl, xmlrpc-c, jsoncpp, perl- TermReadKey, qt5-qtwebkit, protobuf-c, python3-PyYAML, attica, kf5 -baloo-file, libmspack, perl-Unicode-Collate, libssh, inkscape, qt5-qtimageformats, GConf2, newt-python, plasma-milou, xorg-x11-resutils, proj, xz-lzma-compat, ttmkfdir, fipscheck, bc, wget, boost-regex, qt5-qtserialport, libgomp, libexif, libkadm5, gstreamer1-plugins-bad-freeworld, ladspa, kf5-kdewebkit, libgusb, glib2, libbinio, ImageMagick-libs, libwmf, pcre2-utf16, libmnl, audacious-plugins, libzmf, gdisk, nss, pcre, tcp_wrappers-libs, sane- backends, gstreamer1-plugins-base, speech-dispatcher, pciutils-libs, libmpc, libXi, audacious, openjpeg2, libmatroska, flac-libs, libXt, libXv, rpm-libs, info, libnfnetlink, polkit-qt, libiec61883, device- mapper-event, qt5-qtbase, audacious-plugins-exotic, libguess, libpskc, linux-atm, lirc-core, kdepimlibs, jwhois, curl, qca-ossl, gcc-gdb- plugin, qt5-qtwebengine, fipscheck-lib, llvm, pyxattr, python2-pycurl, qt-gstreamer, bluedevil, paps, libstaroffice, lzo-minilzo, ustr, pinfo, phonon, libdhash, protobuf-compiler, kf5-kmime, imsettings- libs, gd, gc, python3-cups, libxshmfence, kate, audacious-plugins- freeworld-aac, ampache_browser, gstreamer1-plugins-ugly-free, atlas, purple-plugin_pack, unzip, gtk2, gtk3, libv4l, atkmm, npth, audit- libs-python, libyaml, plasma-breeze, xcb-util-image, m17n-lib, mozjs17, libfilezilla, libblockdev-mdraid, exiv2-libs, lensfun, libebml, libunistring, gstreamer1-plugins-good, python2-rpm, libasyncns, device-mapper-multipath, c-ares, kdeplasma-addons, libspiro, python2-cairo, jansson, bind-utils, audacious-plugins-jack, kcolorchooser, librsvg2, firefox, kf5-akonadi-server, trousers-lib, zip, webrtc-audio-processing, startup-notification, kf5-kross-core, rfkill, libXevie, babl, kdepimlibs-akonadi, podofo-libs, freeipmi, libqalculate, libtranslit, perl-Devel-CallChecker, libtasn1, libblockdev-dm, libe-book, alsa-utils, sqlite, tar, sudo, speech- dispatcher-espeak, keditbookmarks-libs, dhcp-client, fprintd, gcc, sip, lame, dwz, compat-lua-libs, xorg-x11-drv-qxl, gcr, oddjob, kwalletmanager5, ebtables, avahi-libs, qtwebkit, pigz, libappindicator-gtk3, libao, kf5-kirigami2, kcm_colors, perl-libs, kbd, perl-EV, libreoffice-core, kmod-nvidia-4.14.18-300.fc27.x86_64, libwayland-cursor, openvpn, crash, kf5-kdnssd, gstreamer1-plugins- ugly, xvidcore, libwacom, lzo, poppler-qt5, pango, libss, aspell, dbus, polkit-libs, perl-threads, perl-Params-Validate, pangomm, kde- runtime-libs, kf5-kguiaddons, krita, mesa-libxatracker, openobex, nss- sysinit, LibRaw, uchardet, libtidy, nss-mdns, libkfbapi, python3-cffi, libXxf86vm, polkit-kde, kf5-kwallet-libs, libtgvoip, at-spi2-core, baloo-widgets, kf5-purpose, kdegraphics-mobipocket, glibc-common, re2, kf5-kcodecs, libsexy, kf5-kwindowsystem, nload, testdisk, nheko, kactivities-libs, qt5-qtlocation, python3-libxml2, scim-libs, libgfortran, stoken-libs, fxload, groff-base, python-pwquality, rsh, kfind, libusb, mesa-libGL, perl-Devel-LexAlias, kf5-modemmanager-qt, perl-HTML-Parser, libldb, python2-gobject-base, NetworkManager-vpnc, libmodplug, libXres, samba-winbind-modules, libcanberra, libgle, kf5-krunner, pcsc-lite, kf5-kio-core-libs, grub2-tools-efi, libart_lgpl, wavpack, xorg-x11-drv-wacom, libsrtp, perl-Package-Stash- XS, samba-client-libs, qt5-qtscript, which, x265-libs, samba-client, libaio, kio-extras, kf5-kemoticons, zbar, strace, thunderbird, createrepo_c, talk, lmdb-libs, xmlsec1, libIDL, kf5-kitemmodels, krb5-workstation, tinyxml2, mcpp, freetype, libglvnd-opengl, lksctp- tools, libgltf, usb_modeswitch, tbb, mythes, NetworkManager-wifi, qt, mjpegtools-libs, gnutls-c++, teamd, libvorbis, kwayland-integration, vconfig, libodfgen, dialog, kwin-libs, lcms-libs, iptables, libestr, qt5-qtwebchannel, lua, perl-PadWalker, libksane, kf5-libkipi, avahi- autoipd, telegram-desktop, pulseaudio-module-gconf, llvm-libs, pulseaudio-module-bluetooth, kf5-kconfigwidgets, perl-Coro, qt5-qtgraphicaleffects, ksysguard-libs, portaudio, passwdqc, libXft, schroedinger, libattr, perl-DBI, hyphen, p7zip-plugins, zvbi, mpg123 -plugins-portaudio, rpm, notify-python, iptstate, kf5-prison, python3-lxml, kf5-kdbusaddons, python3-libs, appstream, libappindicator, perl-PathTools, ipset-libs, kf5-kio-widgets, libksysguard, plasma-nm-vpnc, pidgin-toobars, perl-Devel-Size, plymouth-graphics-libs, libreoffice-pyuno, file, libxml2, libreoffice- ure, kf5-frameworkintegration, cyrus-sasl-gssapi, mpage, libnm-gtk, libsecret, openblas, p11-kit-trust, dcraw, libdca, libsysfs, java-1.8.0-openjdk-headless, gdk-pixbuf2-modules, at-spi2-atk, plasma- workspace, nss-pem, vim-common, python2-kerberos, less, libvpx, kf5-baloo, tcl, rpm-build-libs, libnghttp2, krita-libs, libsolv, libxkbcommon-x11, libmms, libuser-python, libtdb, python3-gpg, libXdmcp, perl-Socket, qoauth, squirrel-libs, libvisual, kf5-kunitconversion, python3, python2, plasma-nm-openvpn, xmp-plugin- audacious, kf5-kwayland, minicom, nss-softokn-freebl, perl-DB_File, libofa, shared-mime-info, SDL2, perl-GD, libsigsegv, libglademm24, plasma-drkonqi, boost-thread, perl-Devel-Caller, dolphin-libs, shadow- utils, plasma-systemsettings, boost-random, libcgroup, libXaw, libXau, phonon-qt5, pulseaudio-module-x11, dmidecode, libutempter, egl- wayland, python3-libcomps, phonon-qt5-backend-gstreamer, setools- python, libjpeg-turbo, libmount, spice-vdagent, xorg-x11-drv-fbdev, libavc1394, lldpad, libtiff, sg3_utils-libs, libnotify, ima-evm-utils, mpg123-plugins-jack, java-1.8.0-openjdk, ed, bind-libs-lite, grub2 -tools-extra, openssh-server, ht, qscintilla-qt5, taglib, libXext, libblockdev-utils, ModemManager-glib, bridge-utils, device-mapper- event-libs, kde-runtime, kdelibs-ktexteditor, initscripts, hunspell, kf5-kjs, libieee1284, wxGTK3, akonadi, libndp, pulseaudio, libaesgm, kf5-ktextwidgets, bzip2, kf5-kxmlrpcclient, krusader, purple-libsteam, elfutils-libelf, libchewing, kf5-kdesu, kf5-kdoctools, libavdevice, libtool-ltdl, readline, openslp, xorg-x11-drv-intel, perl-version), /usr/lib/.build-id/90(libwayland-server, firefox, enca, SDL2, krita, lirc-core, libxcb, kate4-part, libreoffice-ure, bluez, kde-runtime- libs, xorg-x11-server-Xorg, systemd, uniconvertor, glibc, gnupg2, VirtualBox-server, speech-dispatcher, pam, kwalletmanager5, iptables, libgphoto2, libdb-utils, dhcp-libs, SDL_sound, libotr, powerdevil, initscripts, hunspell, pciutils, libnl3-cli, python3-PyYAML) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tcl- thread-devel , tcl-thread-debuginfo , tcl-thread-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: tcl-thread-2.8.2-1.fc28.x86_64.rpm tcl-thread-devel-2.8.2-1.fc28.x86_64.rpm tcl-thread-debuginfo-2.8.2-1.fc28.x86_64.rpm tcl-thread-debugsource-2.8.2-1.fc28.x86_64.rpm tcl-thread-2.8.2-1.fc28.src.rpm tcl-thread-devel.x86_64: W: no-documentation tcl-thread-debugsource.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (debuginfo) ------------------- Checking: tcl-thread-debuginfo-2.8.2-1.fc28.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory tcl-thread-devel.x86_64: W: no-documentation tcl-thread-debugsource.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Requires -------- tcl-thread (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgdbm.so.5()(64bit) rtld(GNU_HASH) tcl(abi)
tcl-thread-devel (rpmlib, GLIBC filtered): tcl-thread(x86-64)
tcl-thread-debuginfo (rpmlib, GLIBC filtered):
tcl-thread-debugsource (rpmlib, GLIBC filtered):
Provides -------- tcl-thread: libthread2.8.2.so()(64bit) tcl-thread tcl-thread(x86-64)
tcl-thread-devel: tcl-thread-devel tcl-thread-devel(x86-64)
tcl-thread-debuginfo: debuginfo(build-id) tcl-thread-debuginfo tcl-thread-debuginfo(x86-64)
tcl-thread-debugsource: tcl-thread-debugsource tcl-thread-debugsource(x86-64)
Unversioned so-files -------------------- tcl-thread: /usr/lib64/tcl8.6/thread2.8.2/libthread2.8.2.so
Source checksums ---------------- http://prdownloads.sourceforge.net/tcl/thread2.8.2.tar.gz : CHECKSUM(SHA256) this package : 7f55abdc9ba31657241ca72dc848c5649e4bad4766564c643fe1a7bfbe31a2f8 CHECKSUM(SHA256) upstream package : 7f55abdc9ba31657241ca72dc848c5649e4bad4766564c643fe1a7bfbe31a2f8
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1544384 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from Vitaly Zaitsev vitaly@easycoding.org --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- tcl-thread-2.8.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f353e41ca
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- tcl-thread-2.8.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-91e44ef9cc
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- tcl-thread-2.8.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91e44ef9cc
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-03-06 12:20:18
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- tcl-thread-2.8.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1544384
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- tcl-thread-2.8.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com