Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: telepathy-farstream - Telepathy client library to handle Call channels
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Summary: Review Request: telepathy-farstream - Telepathy client library to handle Call channels Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bdpepple@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.1.2-1.fc16.src.rp... Description: telepathy-farstream is a Telepathy client library that uses Farsight2 to handle Call channels
Scratch build (Rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=3530748
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Brian Pepple bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |797694
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #1 from Bill Nottingham notting@redhat.com 2012-02-28 15:47:12 EST --- This package would appear to need some s/farsight/farstream work done, and updated to 0.2.1?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #2 from Brian Pepple bdpepple@gmail.com 2012-02-28 16:34:01 EST --- (In reply to comment #1)
This package would appear to need some s/farsight/farstream work done, and updated to 0.2.1?
Right. I'm still sorting out the deps that it needs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #3 from Brian Pepple bdpepple@gmail.com 2012-03-04 17:14:15 EST --- Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-1.fc16.src.rp...
i386 build results: http://bpepple.fedorapeople.org/rpms/tp-farstream/
Description: telepathy-farstream is a Telepathy client library that uses Farsight2 to handle Call channels
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #4 from Bill Nottingham notting@redhat.com 2012-03-05 15:24:57 EST --- - Package meets naming and packaging guidelines - ***
Description and URL need /farsight/farsteam/ substitutions.
- Spec file matches base package name. - OK - Spec has consistent macro usage. - OK - Meets Packaging Guidelines. - OK - License - LGPLv2+ (OK) - License field in spec matches - OK - License file included in package - OK - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: - OK 409036c07dcd7d8729ff9c84366c8967 telepathy-farstream-0.2.1.tar.gz
- Package needs ExcludeArch - N/A - BuildRequires correct - OK - Spec handles locales/find_lang - N/A - Package is code or permissible content. - OK - Doc subpackage needed/used. - N/A - Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - OK - Spec has needed ldconfig in post and postun - OK - .pc files in -devel subpackage/requires pkgconfig - OK - .so files in -devel subpackage. - OK - -devel package Requires: %{name} = %{version}-%{release} -OK - .la files are removed. - OK
- Package is a GUI app and has a .desktop file - N/A
- Package compiles and builds on at least one arch. - tested x86_64 w/mock - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. -OK - Package owns all the directories it creates. - OK - No rpmlint output. - ***
telepathy-farstream.src:37: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 37)
- final provides and requires are sane: ***
telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.
SHOULD Items:
- Should build in mock. - tested x86_64 - Should build on all supported archs - didn't test - Should function as described. - didn't test - Should have sane scriptlets. - OK - Should have subpackages require base package with fully versioned depend. - OK - Should have dist tag - OK - Should package latest version - OK
Issues:
1. Description and URL need /farsight/farsteam/ substitutions. 2. Spaces & tabs in the spec 3. telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #5 from Brian Pepple bdpepple@gmail.com 2012-03-05 16:12:30 EST --- Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-2.fc16.src.rp...
Diff: http://bpepple.fedorapeople.org/rpms/spec.diff
* Mon Mar 5 2012 Brian Pepple bpepple@fedoraproject.org - 0.2.1-2 - Use macro for version in provides. - Change reference Farsight in description to Farstream.
Didn't change reference to url, since as of Saturday a page for tp-farstream didn't exist. freedesktop.org appears to be down right, so I can't check to see if this has changed since then.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Bill Nottingham notting@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #6 from Bill Nottingham notting@redhat.com 2012-03-05 16:25:30 EST --- Looks good. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Brian Pepple bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Brian Pepple bdpepple@gmail.com 2012-03-05 16:28:25 EST --- New Package SCM Request ======================= Package Name: telepathy-farstream Short Description: Telepathy client library to handle Call channels Owners: bpepple Branches: f17 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #8 from Jens Petersen petersen@redhat.com 2012-03-06 02:15:08 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-03-06 14:21:33 EST --- empathy-3.3.91-1.fc17,telepathy-farstream-0.2.1-2.fc17,farstream-0.1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/empathy-3.3.91-1.fc17,telepathy-fars...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-03-10 19:57:15 EST --- pidgin-2.10.1-4.fc17,papyon-0.5.6-3.fc17,farstream-0.1.1-4.fc17,telepathy-farstream-0.2.2-1.fc17,empathy-3.3.91-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pidgin-2.10.1-4.fc17,papyon-0.5.6-3....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |telepathy-farstream-0.2.2-2 | |.fc17 Resolution| |ERRATA Last Closed| |2012-03-16 17:12:49
Bug 755727 depends on bug 797694, which changed state.
Bug 797694 Summary: Review Request: Farstream - Libraries for videoconferencing https://bugzilla.redhat.com/show_bug.cgi?id=797694
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|MODIFIED |CLOSED
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2012-03-16 17:12:49 EDT --- telepathy-farstream-0.2.2-2.fc17, farstream-0.1.1-5.fc17, amsn-0.98.4-10.fc17, pidgin-2.10.1-4.fc17, papyon-0.5.6-3.fc17, empathy-3.3.91-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org