https://bugzilla.redhat.com/show_bug.cgi?id=2310860
Bug ID: 2310860 Summary: Review Request: rust-zerofrom - Trait for constructing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Whiteboard: Trivial Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 2310825 Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/rust-zerofrom.spec SRPM URL: https://music.fedorapeople.org/rust-zerofrom-0.1.4-1.fc40.src.rpm
Description: ZeroFrom trait for constructing.
Fedora Account System Username: music
This is a dependency for rust-zerovec, which is needed for updating rust-idna to 1.x.
This package needs rust-zerofrom-derive, bug 2310825, in order for all feature metapackages to be installable.
The submission is the unmodified output of rust2rpm, without a configuration file.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2310825 [Bug 2310825] Review Request: rust-zerofrom-derive - Custom derive for the zerofrom crate
https://bugzilla.redhat.com/show_bug.cgi?id=2310860 Bug 2310860 depends on bug 2310825, which changed state.
Bug 2310825 Summary: Review Request: rust-zerofrom-derive - Custom derive for the zerofrom crate https://bugzilla.redhat.com/show_bug.cgi?id=2310825
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- The generated Summary is a bit wonky, can you improve it a bit?
Other than that, package looks good to me.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- Thanks for the review!
https://release-monitoring.org/project/374329/
(In reply to Fabio Valentini from comment #1)
The generated Summary is a bit wonky, can you improve it a bit?
Sure, how about this?
[package] summary = "ZeroFrom trait for constructing"
That restores the original summary from https://crates.io/crates/zerofrom, which was munged by the rust2rpm heuristics.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zerofrom
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- (In reply to Ben Beasley from comment #2)
Thanks for the review!
https://release-monitoring.org/project/374329/
(In reply to Fabio Valentini from comment #1)
The generated Summary is a bit wonky, can you improve it a bit?
Sure, how about this?
[package] summary = "ZeroFrom trait for constructing"
That restores the original summary from https://crates.io/crates/zerofrom, which was munged by the rust2rpm heuristics.
👍
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e57c7c915a
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-09-10 17:50:49
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-zerofrom-0.1.4-1.fc39, and 1 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41 and rust-zerofrom-derive-0.1.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40 and rust-zerofrom-derive-0.1.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-7f67248787 has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ea19be9ef4
https://bugzilla.redhat.com/show_bug.cgi?id=2310860
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org