[Bug 2318604] New: Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Bug ID: 2318604
           Summary: Review Request: golang-github-x448-float16 - Provides
                    IEEE 754 half-precision format
           Product: Fedora
           Version: rawhide
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://trix.fedorapeople.org/golang-github-x448-float16.spec
SRPM URL:
https://trix.fedorapeople.org/golang-github-x448-float16-0.8.4-1.fc42.src.rp...

Needed for ollama

Reproducible: Always

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Blocks|                            |2318425

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2318425
[Bug 2318425] Review Request: golang-github-ollama-ollama - Get up and running
with Llama 3.2, Mistral, Gemma 2, and other large language models

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #1 from Mikel Olasagasti Uranga  ---
Spec has been created with go2rpm, but bootstrapping logic has been stripped.
Can you run `go2rpm -q github.com/x448/float16` again and keep it? It makes
future maintainability easier.

Otherwise the spec is fine.

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(mikel@olasagasti.
                   |                            |info)

--- Comment #2 from [e-mail] ---
Can you explain why the bootstapping logic is needed ?
I did not have to use it.

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(mikel@olasagasti. |
                   |info)                       |

--- Comment #3 from Mikel Olasagasti Uranga  ---
It was added as part of the go2rpm default template in 1.14 and by default is
disabled. The reason it was added is explained here
https://gitlab.com/fedora/sigs/go/go2rpm/-/merge_requests/13#note_1965122324
and is used in case it's needed for complex packages.

When I mention maintainability I refer that in the future if instead of just
bumping the version (manually, using rpmdev-bumpspec, ...) go2rpm is used to
update the template, there will be always this change that will need to be
reapplied.

If you still prefer to remove it, I can review the packages with that
preference.

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

--- Comment #4 from [e-mail] ---
This and the other ollama packages are very simple packages, i removed the
bootstrapping logic because to get the package built i did not have to do
anything fancy and did not need/use the logic.  Not needing something, I
removed it to make the spec file simpler.

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(mikel@olasagasti.
                   |                            |info)

--- Comment #5 from [e-mail] ---
Is there anything I need to do here ?

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?(mikel@olasagasti. |
                   |info)                       |

--- Comment #6 from Mikel Olasagasti Uranga  ---
> # https://github.com/x448/float16.git

This is a manual edit, not from the template. Please, change before pushing.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [x] The package does not use `%gometa -f` if it has dependents that still
build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #7 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-x448-float16

[Bug 2318604] Review Request: golang-github-x448-float16 - Provides IEEE 754 half-precision format

https://bugzilla.redhat.com/show_bug.cgi?id=2318604

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2024-11-05 14:00:15