[Bug 1788158] New: Review Request: expected - C++11/14/17 std::expected with functional-style extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
Bug ID: 1788158 Summary: Review Request: expected - C++11/14/17 std::expected with functional-style extensions Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: vitaly@easycoding.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/EasyCoding/expected/raw/master/expected.spec SRPM URL: https://xvitaly.fedorapeople.org/for-review/expected-1.0.0-1.fc31.src.rpm Description: C++11/14/17 std::expected with functional-style extensions Fedora Account System Username: xvitaly
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
Artem ego.cordatus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ego.cordatus@gmail.com Assignee|nobody@fedoraproject.org |ego.cordatus@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+
--- Comment #1 from Artem ego.cordatus@gmail.com --- Package approved.
I guess you could drop '%global debug_package %{nil}' since this is noarch package?
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 27 files have unknown license. Detailed output of licensecheck in /mnt/data- linux/tmp/review/1788158-expected/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/tl(defaulting, set, C, locale,, to, Failed), /usr/share/cmake/tl-expected(defaulting, set, C, locale,, to, Failed), /usr/share/doc/expected- devel(defaulting, set, C, locale,, to, Failed), /usr/share/licenses/expected-devel(defaulting, set, C, locale,, to, Failed) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: expected-devel-1.0.0-1.fc32.noarch.rpm expected-1.0.0-1.fc32.src.rpm expected-devel.noarch: W: spelling-error %description -l en_US objec -> object 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). expected-devel.noarch: W: spelling-error %description -l en_US objec -> object 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Source checksums ---------------- https://github.com/TartanLlama/expected/archive/v1.0.0/expected-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 8f5124085a124113e75e3890b4e923e3a4de5b26a973b891b3deb40e19c03cee CHECKSUM(SHA256) upstream package : 8f5124085a124113e75e3890b4e923e3a4de5b26a973b891b3deb40e19c03cee
Requires -------- expected-devel (rpmlib, GLIBC filtered): cmake-filesystem
Provides -------- expected-devel: cmake(tl-expected) expected-devel expected-static
Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1788158 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, SugarActivity, Perl, fonts, C/C++, R, Python, Java, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/expected
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-3df747405b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3df747405b
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- expected-1.0.0-1.fc31, qr-code-generator-1.5.0-1.20191014git67c6246.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3df747405b
https://bugzilla.redhat.com/show_bug.cgi?id=1788158
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-01-09 01:26:54
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- expected-1.0.0-1.fc31, qr-code-generator-1.5.0-1.20191014git67c6246.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com