[Bug 2256307] New: Review Request: golang-github-aybabtme-rgbterm - RGB colors for your terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
Bug ID: 2256307 Summary: Review Request: golang-github-aybabtme-rgbterm - RGB colors for your terminal Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm-0-0.1.20231231gitc... Description: RGB colors for your terminal Fedora Account System Username: mikep
This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm-0-0.1.20231231gitc...
Rebuild with go2rpm 1.10.0.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6840030 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6840054 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #4 from W. Michael Petullo mike@flyn.org --- Unretire request: https://pagure.io/releng/issue/11878
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Spec is correct but there are a couple of issues:
License: MIT
Is not correct. Some functions are under BSD-2-Clause:
https://github.com/aybabtme/rgbterm/blob/master/LICENSE#L23
It should be
License: BSD-2-Clause AND MIT
RPM build warnings: File listed twice: /usr/share/doc/golang-github-aybabtme-rgbterm-devel/README.md File listed twice: /usr/share/licenses/golang-github-aybabtme-rgbterm-devel/LICENSE
You need to rename these files to avoid this issue. You can check the following spec as example:
https://src.fedoraproject.org/rpms/golang-github-prometheus-client/blob/rawh...
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #6 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm-0-0.1.20231231gitc...
- Add second license - Rename duplicate LICENSE file and README.md
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2007797 --> https://bugzilla.redhat.com/attachment.cgi?id=2007797&action=edit The .spec file difference from Copr build 6840054 to 6872106
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6872106 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'BSD-2-Clause and MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
--- Comment #10 from W. Michael Petullo mike@flyn.org --- Unretire request: https://pagure.io/releng/issue/11878
https://bugzilla.redhat.com/show_bug.cgi?id=2256307
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ASSIGNED |CLOSED Last Closed| |2024-01-16 01:26:00
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com