Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: Axel.Thimm@ATrpms.net QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec SRPM URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt-5.89... Description: This package contains configuration files for apt.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
------- Additional Comments From pmatilai@laiskiainen.org 2006-05-09 10:24 EST ------- Created an attachment (id=128787) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128787&action=vie...) Fix some whitespace issues
Some sort of whitespace-eating monster appears to have struck the spec, doesn't build without this + one missing mkdir added.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
------- Additional Comments From Axel.Thimm@ATrpms.net 2006-05-09 14:25 EST ------- Eeck. Fixed in
Spec URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec SRPM URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt-5.89...
* Tue May 9 2006 Axel Thimm Axel.Thimm@ATrpms.net - 5.89-2 - Fix whitespace (by Panu in bug #191040c1).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |ville.skytta@iki.fi OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From ville.skytta@iki.fi 2006-05-11 15:56 EST ------- Issues:
- Shouldn't the package be noarch? - Missing dependency on apt (similar issue seems to exist in the corresponding smart package too, by the way)
Cosmetics:
- Summary and %description could mention Fedora even though it's in %{name}, and %description could be expanded a bit. - Upstream spelling is APT-RPM, that could be used in summary and description too
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
------- Additional Comments From Axel.Thimm@ATrpms.net 2006-05-11 17:01 EST ------- Fixed in
Spec URL: http://people.atrpms.net/~athimm/fedorasubmit/fedora-package-config-apt.spec
* Thu May 11 2006 Axel Thimm Axel.Thimm@ATrpms.net - 5.89-3 - Apply comments from review #191040c3 (by Ville). - Fix summary and description - Config files are arch-independent, so we should become noarch - Create versioned dependency on apt (make sure it's repo-md capable) This creates a circular dependency which should not impose any issues.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From ville.skytta@iki.fi 2006-05-12 16:51 EST ------- No SRPM seems to be available for 5.89-3, but if it's the same as -2 apart from the specfile changes, approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191040
Axel.Thimm@ATrpms.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From Axel.Thimm@ATrpms.net 2006-05-13 06:10 EST ------- Thanks for reviewing & approving. The package for devel has been queued in and I also tagged & built the matching apt package for devel.
(apt will still need some cleansing and an upgrade to the next upstream release, which is estimated to happen soon, I'm building apt just to have something to use fedora-package-conf-apt with and not punch dependency holes in devel)
Branches for FC-5 and FC-4 have been requested.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-package-config-apt - Configuration files for the apt package manager
https://bugzilla.redhat.com/show_bug.cgi?id=191040
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org