[Bug 1550396] New: Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
Bug ID: 1550396 Summary: Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@online.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-netspee... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-netspee...
Description: Add an Internet speed indicator to status area.
Fedora Account System Username: martinkg
%changelog * Wed Feb 07 2018 Martin Gansser martinkg@fedoraproject.org - 3.28-0.2.20180208gite3cea60 - Update to recent git version 3.28-0.2.20180208gite3cea60
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/hedayaty | |/NetSpeed CC| |andrew@tosk.in
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - glib-compile-schemas: This scriptlet SHOULD NOT be used in Fedora 24 or later.
Remove the scriplets, it is not needed anymore.
- Group: is not used in Fedora
- Add -q to %setup to make it quiet
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - glib-compile-schemas must not be run in %postun and %posttrans for Fedora 24 and later. Note: gschema file(s) in gnome-shell-extension-netspeed See:
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 18 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-shell-extension-netspeed/review- gnome-shell-extension-netspeed/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/glib-2.0/schemas, /usr/share/glib-2.0 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gnome-shell-extension-netspeed-28-0.2.20180208gite3cea60.fc29.noarch.rpm gnome-shell-extension-netspeed-28-0.2.20180208gite3cea60.fc29.src.rpm gnome-shell-extension-netspeed.src:26: W: setup-not-quiet 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
--- Comment #2 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-netspee... SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-netspee...
%changelog * Fri Mar 02 2018 Martin Gansser martinkg@fedoraproject.org - 3.28-0.3.20180208gite3cea60 - Remove scriptlet glib-compile-schemas: This scriptlet SHOULD NOT be used in Fedora 24 or later. - Remove Group: is not used in Fedora - Add -q to %%setup to make it quiet
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
--- Comment #4 from MartinKG mgansser@online.de --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-netspeed
https://bugzilla.redhat.com/show_bug.cgi?id=1550396
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2018-03-02 14:23:54
--- Comment #6 from MartinKG mgansser@online.de --- package has been built successfully on f26, f27 and rawhide.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com