[Bug 859270] New: Review Request: php-symfony2-Filesystem - Symfony2 Filesystem Component
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Bug ID: 859270 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: php-symfony2-Filesystem - Symfony2 Filesystem Component Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: shawn.iwinski@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1....
Description: The Filesystem component provides basic utilities for the filesystem.
Fedora Account System Username: siwinski
Distributions: EPEL 6, F16+
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com Depends On| |814994 | |(php-channel-symfony2)
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Remi Collet rcollet@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rcollet@redhat.com
--- Comment #1 from Remi Collet rcollet@redhat.com --- Quick notes, which affects "all" synfony 2.1 packages
- phpunit.xml.dist and Tests/* sould be role="test", so install in %{pear_testdir} - CHANGELOG.md should be role="doc"
sed -e '/CHANGELOG.md/s/role="php"/role="doc"/' \ -e '/phpunit.xml.dist/s/role="php"/role="test"/' \ -e '/Tests/s/role="php"/role="test"/' \ -i package.xml
Of course, this should be reported to upstream
- as tests are provided, should be run in %check
%check cd %{pear_name}-%{version}/Symfony/Component/%{pear_name}/Tests phpunit --bootstrap bootstrap.php .
N.B. : Yaml could not run test in %check, because it depends on phpunit, which depends use Yaml (see the diff I sent you)
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Remi Collet rcollet@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |rcollet@redhat.com
--- Comment #2 from Remi Collet rcollet@redhat.com --- Created attachment 615284 --> https://bugzilla.redhat.com/attachment.cgi?id=615284&action=edit bootstrap.php
Another small issue with the test suite provided: tThe provided "bootstrap" only allow us to run test from the source tree, but not from installation tree.
The attached version works in both. Please test it. It should also work for all components, not specific to this one.
Probably, you can also propose this to upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Remi Collet rcollet@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|rcollet@redhat.com |fedora@famillecollet.com
https://bugzilla.redhat.com/show_bug.cgi?id=859270
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Missing requires : php-posix (at least for test)
https://bugzilla.redhat.com/show_bug.cgi?id=859270
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- Updated per comments.
- Added php-posix require - Added PEAR package.xml modificaions - Added patch for tests' bootstrap.php - Added tests (%check)
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Filesystem.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Filesystem-2.1....
https://bugzilla.redhat.com/show_bug.cgi?id=859270
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Created attachment 624957 --> https://bugzilla.redhat.com/attachment.cgi?id=624957&action=edit 859270-php-symfony2-Filesystem/php-symfony2-Filesystem-review.txt
Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Note : typo in %changelog : modificaions (please fix after import)
No blocker
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=859270
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Shawn Iwinski shawn.iwinski@gmail.com --- New Package SCM Request ======================= Package Name: php-symfony2-Filesystem Short Description: Symfony2 Filesystem Component Owners: siwinski Branches: f16 f17 f18 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=859270
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=859270
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed| |2012-11-17 11:58:57
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla