[Bug 2257974] New: Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

Bug ID: 2257974
           Summary: Review Request: pgrouting - Provides routing
                    functionality to PostGIS / PostgreSQL
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://blinxen.fedorapeople.org/pgrouting/pgRouting.spec
SRPM URL:
https://blinxen.fedorapeople.org/pgrouting/pgrouting-3.6.1-1.fc40.src.rpm

Description:
pgRouting extends the PostGIS / PostgreSQL geospatial database to provide
geospatial routing functionality.

Fedora Account System Username: blinxen

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #1 from blinxen  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=111630837

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #2 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6886224
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6886239
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

--- Comment #5 from Sandro Mani  ---
Taking review

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #6 from Sandro Mani  ---
Issues:
=======
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/pgsql,
     /usr/lib64/pgsql, /usr/share/pgsql/extension

=> require postgresql-server

[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 12656640 bytes in /usr/share
     pgrouting-3.6.1-1.fc40.x86_64.rpm:12656640
     See:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Gui...

=> At your option

[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/sandro/Desktop/2257974-pgRouting/srpm-
     unpacked/pgRouting.spec

=> pgRouting.spec should be pgrouting.spec

Suggestion: use

Source:       
https://github.com/pgRouting/%%7Bname%7D/archive/v%%7Bversion%7D/%%7Bname%7D...

to avoid version-only tarball name.

===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/pgsql,
     /usr/lib64/pgsql, /usr/share/pgsql/extension
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 60744 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 12656640 bytes in /usr/share
     pgrouting-3.6.1-1.fc40.x86_64.rpm:12656640
     See:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Gui...
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/sandro/Desktop/2257974-pgRouting/srpm-
     unpacked/pgRouting.spec
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: pgrouting-3.6.1-1.fc40.x86_64.rpm
          pgrouting-debuginfo-3.6.1-1.fc40.x86_64.rpm
          pgrouting-debugsource-3.6.1-1.fc40.x86_64.rpm
          pgrouting-3.6.1-1.fc40.src.rpm
===========================================================================================================
rpmlint session starts
==========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpgeurln4r')]
checks: 32, packages: 4

pgrouting.src: E: spelling-error ('geospatial', '%description -l en_US
geospatial -> spatial')
pgrouting.x86_64: E: spelling-error ('geospatial', '%description -l en_US
geospatial -> spatial')
pgrouting.src: E: invalid-spec-name
===================================================================== 4
packages and 0 specfiles checked; 3 errors, 0 warnings, 16 filtered, 3 badness;
has taken 2.0 s
=====================================================================

Rpmlint (debuginfo)
-------------------
Checking: pgrouting-debuginfo-3.6.1-1.fc40.x86_64.rpm
===========================================================================================================
rpmlint session starts
==========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpkspdp8ag')]
checks: 32, packages: 1

====================================================================== 1
packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness;
has taken 0.7 s
=====================================================================

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so numeric_float8_no_overflow 
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so CurrentMemoryContext       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_tuptable       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_processed      
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so InterruptPending   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_palloc 
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so TupleDescInitEntry 
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so per_MultiFuncCall  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errhint    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errfinish  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_pfree  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_prepare
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so get_typlenbyvalalign       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so cstring_to_text    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so deconstruct_array  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_fnumber
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so DirectFunctionCall1Coll    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so init_MultiFuncCall 
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so get_call_result_type       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so palloc     
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errmsg     
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_repalloc       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so ProcessInterrupts  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_finish 
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_cursor_fetch   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_connect
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errstart   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_getbinval      
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errstart_cold      
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so end_MultiFuncCall  
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so repalloc   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so pg_detoast_datum   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so text_to_cstring    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_getvalue       
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so HeapTupleHeaderGetDatum    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so heap_form_tuple    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so construct_array    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so ArrayGetNItems     
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so pfree      
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errcode    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_cursor_open    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_gettypeid      
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so errmsg_internal    
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_cursor_close   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: W: undefined-non-weak-symbol
/usr/lib64/pgsql/libpgrouting-3.6.so SPI_freetuptable   
(/usr/lib64/pgsql/libpgrouting-3.6.so)
pgrouting.x86_64: E: spelling-error ('geospatial', '%description -l en_US
geospatial -> spatial')
 3 packages and 0 specfiles checked; 1 errors, 45 warnings, 13 filtered, 1
badness; has taken 1.3 s

Unversioned so-files
--------------------
pgrouting: /usr/lib64/pgsql/libpgrouting-3.6.so

Source checksums
----------------
https://github.com/pgRouting/pgrouting/archive/refs/tags/v3.6.1.tar.gz :
  CHECKSUM(SHA256) this package     :
30231dfe01211f709fca9ac0140454ba6bd812f2b7f45fb30222169cd4e8b061
  CHECKSUM(SHA256) upstream package :
30231dfe01211f709fca9ac0140454ba6bd812f2b7f45fb30222169cd4e8b061

Requires
--------
pgrouting (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    postgis
    rtld(GNU_HASH)

pgrouting-debuginfo (rpmlib, GLIBC filtered):

pgrouting-debugsource (rpmlib, GLIBC filtered):

Provides
--------
pgrouting:
    libpgrouting-3.6.so()(64bit)
    pgrouting
    pgrouting(x86-64)

pgrouting-debuginfo:
    debuginfo(build-id)
    libpgrouting-3.6.so-3.6.1-1.fc40.x86_64.debug()(64bit)
    pgrouting-debuginfo
    pgrouting-debuginfo(x86-64)

pgrouting-debugsource:
    pgrouting-debugsource
    pgrouting-debugsource(x86-64)

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -v -b 2257974
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Haskell, R, Perl, fonts, PHP, Ocaml, SugarActivity, Python,
Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #7 from blinxen  ---
> Taking review

Thanks!
> => require postgresql-server

Added the postgresql-server requirement
> [!]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
> => At your option

I will keep them in the same package. It doesn't make much sense to split them
> => pgRouting.spec should be pgrouting.spec

Renamed the spec file
> Suggestion: use
> Source:        https://github.com/pgRouting/%%7Bname%7D/archive/v%%7Bversion%7D/%%7Bname%7D...
> to avoid version-only tarball name.

Changed the source, thanks for the tip!

Links to the updated files:
Spec URL: https://blinxen.fedorapeople.org/pgRouting/pgrouting.spec
SRPM URL:
https://blinxen.fedorapeople.org/pgRouting/pgrouting-3.6.1-1.fc40.src.rpm

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://pgrouting.org
           Keywords|                            |AutomationTriaged

--- Comment #8 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6888713
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

Sandro Mani  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #9 from Sandro Mani  ---
Approved!

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

--- Comment #10 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/pgrouting

[Bug 2257974] Review Request: pgrouting - Provides routing functionality to PostGIS / PostgreSQL

https://bugzilla.redhat.com/show_bug.cgi?id=2257974

blinxen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
        Last Closed|                            |2024-01-15 20:07:21

--- Comment #11 from blinxen  ---
> Approved!

Thanks!!

Package built in rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-82d3e314fa