Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: martin.sourada@seznam.cz QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnom... SRPM URL: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnom... Description: This package contains the Nodoka theme for Metacity window manager and Nodoka metatheme for Gnome, the metatheme requires gtk-nodoka-engine and echo-icon-theme.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
martin.sourada@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |248163
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com Flag| |fedora-review?
------- Additional Comments From mclasen@redhat.com 2007-07-27 13:40 EST ------- Trivia:
- please use a full source url, if practical
- the emmpty %doc in the file list looks odd, I'd remove that
the description of the main package is a bit misleading: "The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2 theme and Echo Icon set." since it does not actually include these things, but just pull them in via dependencies.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
------- Additional Comments From martin.sourada@seznam.cz 2007-07-27 15:05 EST ------- (In reply to comment #1)
Trivia:
- please use a full source url, if practical
Same as with gtk-nodoka-theme: as we currently use wiki for upstream I think it's impractical ATM
- the emmpty %doc in the file list looks odd, I'd remove that
True, removed
the description of the main package is a bit misleading: "The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2 theme and Echo Icon set." since it does not actually include these things, but just pull them in via dependencies.
Yes, I changed the includes to make use. Seems saner to me...
New release:
New SPEC: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnom... New SRPM: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnom...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
------- Additional Comments From mclasen@redhat.com 2007-07-30 00:01 EST ------- rpmlint is silent on the produced rpms
package name: ok, I think. spec name: ok packaging guidelines: mostly ok - might be a good idea to put a comment pointing to the wiki location of the upstream sources - should add a comment about the "inverse relationship" between main and subpackage, where the main package requires the subpackage license: ok license field: ok license file: ok spec language: ok spec legibility: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locales: n/a shared libs: n/a relocatable: n/a directory ownership: there is a conflict where both the gtk theme package and the metacity theme package own /usr/share/themes/Nodoka. Possible solution: make the metacity theme package require the gtk theme package file list dupes: ok file permissions: ok %clean: ok macro use: ok permissible content: ok large docs: n/a %doc content: ok header files: n/a static libs: n/a pc files: n/a shared lib symlinks: n/a devel package: n/a libtool archives: n/a gui apps: n/a file ownership: see above %install: ok utf8 filenames: ok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
Bug 248516 depends on bug 248163, which changed state.
Bug 248163 Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
------- Additional Comments From martin.sourada@seznam.cz 2007-08-04 10:10 EST ------- I made a new release addressing the above mentioned issues.
New SPEC: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnom...
New SRPM: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnom...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mclasen@redhat.com 2007-08-04 20:27 EST ------- Looks fine now. Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
martin.sourada@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From martin.sourada@seznam.cz 2007-08-05 03:20 EST ------- New Package CVS Request ======================= Package Name: nodoka-theme-gnome Short Description: The Nodoka Metacity theme and Gnome metatheme Owners: martin.sourada@seznam.cz Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-08-05 14:38 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516
martin.sourada@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org