https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Bug ID: 2318412 Summary: Review Request: perl-Term-TermKey - Perl wrapper around libtermkey Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey-0.17-1.... Description: This module provides a light perl wrapper around the libtermkey library. This library attempts to provide an abstract way to read keypress events in terminal-based programs by providing structures that describe keys, rather than simply returning raw bytes as read from the TTY device.
Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2 badness; has taken 0.3 s
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2318410 Doc Type|--- |If docs needed, set a value Blocks| |2283360
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283360 [Bug 2283360] F41FailsToInstall: asciio, perl-App-Asciio https://bugzilla.redhat.com/show_bug.cgi?id=2318410 [Bug 2318410] Review Request: perl-Alien-libtermkey - Alien wrapping for libtermkey
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- QA Contact|extras-qa@fedoraproject.org |xavier@bachelot.org Status|NEW |ASSIGNED CC| |xavier@bachelot.org
--- Comment #1 from Xavier Bachelot xavier@bachelot.org --- According to tangerine, only XSLoader is runtime, all of the other currently tagged as runtime are actually buildtime, testtime are fine.
Otherwise, LGTM, although it's not buildable until perl-Alien-libtermkey hits the repo.
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
--- Comment #2 from Xavier Bachelot xavier@bachelot.org --- Fails to build with: Checking Alien::libtermkey atleast-version 0.16... Unable to find Alien::libtermkey providing pkg-config version 0.16
Should perl-Alien-libtermkey have a Requires: libtermkey ? and/or perl-Term-TermKey have a BuildRequires: pkgconfig(termkey) >= 0.16 ?
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |xavier@bachelot.org CC| |ppisar@redhat.com
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Yes, the meaning of Alien packages is to ensure that it is possible to build against that library. I.e. the Alien package should run-require a *-devel package of the library, and in the same version it was built against because the Alien package builds in the libraries version. See e.g. perl-Alien-pkgconf.
https://bugzilla.redhat.com/show_bug.cgi?id=2318412 Bug 2318412 depends on bug 2318410, which changed state.
Bug 2318410 Summary: Review Request: perl-Alien-libtermkey - Alien wrapping for libtermkey https://bugzilla.redhat.com/show_bug.cgi?id=2318410
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
--- Comment #4 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Petr Pisar from comment #3)
the Alien package should run-require a *-devel package of the library, and in the same version it was built against because the Alien package builds in the libraries version.
This is done in perl-Alien-termkey-0.22-3
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
--- Comment #5 from Xavier Bachelot xavier@bachelot.org --- Build is failing on F42 mock. I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2.
Test Summary Report ------------------- t/05flags.t (Wstat: 139 (Signal: SEGV, dumped core) Tests: 2 Failed: 0) Non-zero wait status: 139 Parse errors: No plan found in TAP output Files=11, Tests=100, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.37 cusr 0.08 csys = 0.49 CPU) Result: FAIL Failed 1/11 test programs. 0/100 subtests failed.
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
--- Comment #6 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Xavier Bachelot from comment #5)
Build is failing on F42 mock.
I will work on this tomorrow.
I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2.
Once this package has been approved and imported in rawhide, I'll backport both packages into F41.
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
--- Comment #7 from Xavier Bachelot xavier@bachelot.org --- Hi Emmanuel,
Still interested in this review ?
Regards, Xavier
https://bugzilla.redhat.com/show_bug.cgi?id=2318412
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2025-06-23 16:13:46
--- Comment #8 from Emmanuel Seyman emmanuel@seyman.fr --- I have orphaned the package that requires this package and no longer require it.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com