https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Bug ID: 1919003 Summary: Review Request: dnf-plugin-cow - Enable RPMCoW in DNF Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: malmond@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... Description: Source package for DNF plugin to enable Copy on Write in DNF and RPM. Fedora Account System Username: malmond
See https://pagure.io/fesco/issue/2534. The other two packages needed for the change in Fedora 34 already exist, they just need patched and/or updated. This single package produces one tiny package that ties it all together.
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
--- Comment #1 from Matthew Almond malmond@fb.com --- This is my first package, and I need a sponsor. I am the upstream maintainer for this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Matthew Almond malmond@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1915976
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1915976 [Bug 1915976] DNF/RPM Copy on Write enablement for all variants
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@michel-slm.name Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags| |fedora-review?
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- I can sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- The packaging is mostly fine. The source RPM name doesn't exactly follow the Python Packaging Guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming) but that applies to Python libraries, and this is just a plugin for DNF; this naming matches other plugins more closely (e.g. dnf-plugins-extras => python3-dnf-plugins-extras-common)
The source checksum doesn't match what's in the URL, could you get it fixed?
Also: per https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_ta...
use Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz
so the downloaded file name is dnf-plugin-cow-0.0.1.tar.gz instead of just 0.0.1.tar.gz
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/michel/src/fedora/reviews/1919003-dnf-plugin-cow/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 4 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1919003-dnf-plugin- cow/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/michel/src/fedora/reviews/1919003-dnf- plugin-cow/srpm-unpacked/dnf-plugin-cow.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: python3-dnf-plugin-cow-0.0.1-3.fc34.noarch.rpm dnf-plugin-cow-0.0.1-3.fc34.src.rpm python3-dnf-plugin-cow.noarch: W: description-shorter-than-summary dnf-plugin-cow.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- python3-dnf-plugin-cow.noarch: W: description-shorter-than-summary 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Source checksums ---------------- https://github.com/facebookincubator/dnf-plugin-cow/archive/0.0.1.tar.gz : CHECKSUM(SHA256) this package : e482be4b01bd94e0102d5ceeac3013302ad1c0b235f1829a136802452650879a CHECKSUM(SHA256) upstream package : d4f68cf8ca990e48a817d14052eff2b864f3d6b2073190bd1b908850e301b9fb diff -r also reports differences
Requires -------- python3-dnf-plugin-cow (rpmlib, GLIBC filtered): config(python3-dnf-plugin-cow) python(abi) python3-dnf
Provides -------- python3-dnf-plugin-cow: config(python3-dnf-plugin-cow) python-dnf-plugin-cow python3-dnf-plugin-cow python3.9-dnf-plugin-cow
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1919003 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, SugarActivity, PHP, fonts, C/C++, Perl, Ocaml, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Matthew Almond malmond@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... Description: Source package for DNF plugin to enable Copy on Write in DNF and RPM. Fedora Account System Username: malmond
See https://pagure.io/fesco/issue/2534. The other two packages needed for the change in Fedora 34 already exist, they just need patched and/or updated. This single package produces one tiny package that ties it all together.
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Matthew Almond malmond@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/malmond/rpmcow/fedora-33-x86... Description: Source package for DNF plugin to enable Copy on Write in DNF and RPM. Fedora Account System Username: malmond
See https://pagure.io/fesco/issue/2534. The other two packages needed for the change in Fedora 34 already exist, they just need patched and/or updated. This single package produces one tiny package that ties it all together.
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Looks fine, APPROVED. Will sponsor now - welcome aboard, Matthew!
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Please build!
https://bugzilla.redhat.com/show_bug.cgi?id=1919003
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com