https://bugzilla.redhat.com/show_bug.cgi?id=967396
Bug ID: 967396 Summary: Review Request: rubygem-chosen-rails - Integrate Chosen JavaScript library with Rails asset pipeline Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: anujmorex@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-chosen-rails/rubygem-chosen-ra... SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-chosen-rails/rubygem-chosen-ra... Description: Integrate Chosen JavaScript library with Rails asset pipeline Fedora Account System Username: anujmore
https://bugzilla.redhat.com/show_bug.cgi?id=967396
--- Comment #1 from Anuj More anujmorex@gmail.com --- Mock builds successfully: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-chosen-rails/... rpmlint complains (but barely ;-)): rubygem-chosen-rails.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry rubygem-chosen-rails.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=967396
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jstribny@redhat.com Assignee|nobody@fedoraproject.org |jstribny@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=967396
--- Comment #2 from Josef Stribny jstribny@redhat.com --- * LICENSE should be marked as %doc * Gemfile and Rakefile should be in the -doc sub-package rather than excluded * README.md should be moved to the -doc sub-package as it's not require during run-time
Other than that I tested it with a simple generated app and everything seems to be fine. Please fix the issues above and I will approve.
https://bugzilla.redhat.com/show_bug.cgi?id=967396
--- Comment #3 from Anuj More anujmorex@gmail.com --- Hi Josef,
Thanks for reviewing the package.
I am following these guidelines (set by myself after looking at example specs and talking to vondruch): https://github.com/execat/Packages/blob/master/rpmspecs/packaging_rules
Changing these would mean changing *ALL* the specfiles I have submitted and am currently working on (There are 20 of those, so that could take some time).
About Gemfile and Rakefile, vondruch specifically asked me to remove them all unless something in the Rakefile really doesn't let package to function properly.
(Applies to https://bugzilla.redhat.com/show_bug.cgi?id=967333 as well)
https://bugzilla.redhat.com/show_bug.cgi?id=967396
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #4 from Vít Ondruch vondruch@redhat.com --- (In reply to Anuj More from comment #3)
Hi Josef,
Thanks for reviewing the package.
I am following these guidelines (set by myself after looking at example specs and talking to vondruch): https://github.com/execat/Packages/blob/master/rpmspecs/packaging_rules
cp -pr spec/ %{buildroot}%{gem_instdir} cp -pr spec/ %{buildroot}%{gem_instdir}
I would suggest to replace the %{buildroot} with '.', i.e. wit the current directory.
Actually, I am not sure why exactly we wrote the guidelines that way, since unpacking the test suite in %check section would do the same (something like in activemodel) on one line. We will try to clarify this with FPC.
About Gemfile and Rakefile, vondruch specifically asked me to remove them all unless something in the Rakefile really doesn't let package to function properly.
I agree with jstribny. I am not sure I would said that anytime. I may said, that some maintainer might have different opinion, but I typically try to keep everything what comes in gem packaged. If I want to remove something, then I ask upstream to do that.
[1] http://pkgs.fedoraproject.org/cgit/rubygem-activemodel.git/tree/rubygem-acti...
https://bugzilla.redhat.com/show_bug.cgi?id=967396
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anujmorex@gmail.com Flags| |needinfo?(anujmorex@gmail.c | |om)
https://bugzilla.redhat.com/show_bug.cgi?id=967396
John Skeoch jskeoch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jstribny@redhat.com |hhorak@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=967396
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Assignee|hhorak@redhat.com |vondruch@redhat.com Flags|needinfo?(anujmorex@gmail.c | |om) | Last Closed| |2016-01-04 04:01:19
--- Comment #6 from Vít Ondruch vondruch@redhat.com --- Closing this stalled review.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org