https://bugzilla.redhat.com/show_bug.cgi?id=1622552
Bug ID: 1622552 Summary: Review Request: golang-github-linuxdeepin-go-dbus-factory - GO DBus factory for Deepin Desktop Environment Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
Description: GO DBus factory for Deepin Desktop Environment
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- You need to use the new Go packaging method, see: https://fedoraproject.org/wiki/More_Go_packaging
You can see examples here: https://eclipseo.fedorapeople.org/golang/
You should get something like this:
=============================================================================== # https://github.com/linuxdeepin/go-dbus-factory %global goipath github.com/linuxdeepin/go-dbus-factory %global commit 2a30fc6fb47b70b8879855df8e29c8f581c419aa
%gometa
Name: %{goname} Version: 0.0.7 Release: 1%{?dist} Summary: GO DBus factory for Deepin Desktop Environment License: GPLv3 URL: %{gourl} Source0: %{gosource}
%description %{summary}
%package devel Summary: %{summary} BuildArch: noarch
%description devel %{summary}
This package contains library source intended for building other packages which use import path with %{goipath} prefix.
%prep %forgeautosetup
%install %goinstall
%check %gochecks
%files devel -f devel.file-list %doc README.md CHANGELOG.md
%changelog * Fri Aug 10 2018 mosquito sensor.wen@gmail.com - 0.0.7-1.20180828git2a30fc6 - First package for Fedora ===============================================================================
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
--- Comment #2 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
I think it's very clear. nice
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Summary|Review Request: |Review Request: |golang-github-linuxdeepin-g |golang-github-linuxdeepin-d |o-dbus-factory - GO DBus |bus-factory - GO DBus |factory for Deepin Desktop |factory for Deepin Desktop |Environment |Environment Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Please note that the SPEC name should now be golang-github-linuxdeepin-dbus-factory.spec The new Go packaging automatically removes "go" or "git" in package name.
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
--- Comment #4 from sensor.wen@gmail.com --- OK, thank you for your help.
https://bugzilla.redhat.com/show_bug.cgi?id=1622552
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-linuxdeepin-dbus-factory
package-review@lists.fedoraproject.org