[Bug 1770949] New: Review Request: nodejs-handle-thing - Wrap Streams2 instance into a HandleWrap
https://bugzilla.redhat.com/show_bug.cgi?id=1770949
Bug ID: 1770949 Summary: Review Request: nodejs-handle-thing - Wrap Streams2 instance into a HandleWrap Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews) Target Milestone: --- Classification: Fedora
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-handle-thing/nodejs-handle-... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-handle-thing/nodejs-handle-... Description: Wrap Streams2 instance into a HandleWrap Fedora Account System Username: jsmith
FWIW, this is a re-review of a previously orphaned package
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1770949
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1736292
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1736292 [Bug 1736292] nodejs-select-hose: FTBFS in Fedora rawhide/f31
https://bugzilla.redhat.com/show_bug.cgi?id=1770949
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Tests don't work:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.6PxhSJ + umask 022 + cd /builddir/build/BUILD + cd package + /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check + /usr/bin/node -e 'require("./")' + /usr/bin/mocha -R spec Handle Thing normal (node:28294) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
1) should write data to Socket
✓ should read data from Socket
2) should invoke `close` callback
✓ should kill pending requests (77ms)
✓ should invoke `getPeerName` callback
3) should emit ECONNRESET at `close` event lazy
4) should write data to Socket
✓ should read data from Socket (52ms)
5) should invoke `close` callback
✓ should kill pending requests (125ms) 5 passing (10s) 5 failing 1) Handle Thing normal should write data to Socket: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7) 2) Handle Thing normal should invoke `close` callback: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7) 3) Handle Thing normal should emit ECONNRESET at `close` event: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7) 4) Handle Thing lazy should write data to Socket: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7) 5) Handle Thing lazy should invoke `close` callback: Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test. at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7) error: Bad exit status from /var/tmp/rpm-tmp.6PxhSJ (%check) Bad exit status from /var/tmp/rpm-tmp.6PxhSJ (%check)
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Jared Smith jsmith.fedora@gmail.com's needinfo: Bug 1770949: Review Request: nodejs-handle-thing - Wrap Streams2 instance into a HandleWrap https://bugzilla.redhat.com/show_bug.cgi?id=1770949
--- Comment #3 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com