[Bug 1343063] New: Review Request: artemis - Java high performance, clustered, asynchronous messaging system - package-review

List overview All Threads
Download

newer

[Bug 1343063] New: Review Request: artemis - Java high performance, clustered, asynchronous messaging system

older

[Bug 1434746] New: Review Request:...

[Bug 1655909] New: Review Request:...

Red Hat Bugzilla

6 Jun 2016 6 Jun '16

1:25 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Bug ID: 1343063 Summary: Review Request: artemis - Java high performance, clustered, asynchronous messaging system Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://gil.fedorapeople.org/artemis.spec SRPM URL: https://gil.fedorapeople.org/artemis-1.2.0-1.fc23.src.rpm Description: Apache ActiveMQ Artemis is an open source project to build a multi-protocol, embeddable, very high performance, clustered, asynchronous messaging system. Artemis is an example of Message Oriented Middleware (MoM). Fedora Account System Username: gil

Wildfly 10+ dependency

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14392997

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

6 Jun 6 Jun

5:26 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Jun 10 Jun

12:21 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Michael Simacek msimacek@redhat.com changed:

--- Comment #1 from Michael Simacek msimacek@redhat.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1024000 bytes in 89 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - I don't like this XPath expression: %pom_xpath_remove pom:configuration artemis-server-osgi It's too general, it will remove any configuration of any plugin that might appear there in the future. Please make it more specific. - Can you put a comment about the patch above it? - There's artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java file under public domain - "Evil MIT" under /artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json You'll need to remove this code and replace with an alternative. You should also inform upstream that they bundle non-free code. - You should use cmake macro. https://fedoraproject.org/wiki/Packaging:Cmake - artemis-native/README contains only build instructions, it shouldn't be installed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", "Public domain Apache (v2.0) MIT/X11 (BSD like)", "*No copyright* Public domain", "*No copyright* Apache (v2.0)". 528 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1343063-artemis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in artemis- boot , artemis-cli , artemis-commons , artemis-core-client , artemis- dto , artemis-jms-client , artemis-jms-server , artemis-journal , artemis-maven-plugin , artemis-native , artemis-protocols , artemis- amqp-protocol , artemis-hornetq-protocol , artemis-hqclient-protocol , artemis-proton-plug , artemis-stomp-protocol , artemis-ra , artemis- rest , artemis-selector , artemis-server , artemis-server-osgi , artemis-service-extensions , artemis-web , artemis-spring-integration , artemis-pom , artemis-javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

Java: [x]: Packages are noarch unless they use JNI Note: artemis-native subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: artemis-boot-1.2.0-1.fc25.noarch.rpm artemis-cli-1.2.0-1.fc25.noarch.rpm artemis-commons-1.2.0-1.fc25.noarch.rpm artemis-core-client-1.2.0-1.fc25.noarch.rpm artemis-dto-1.2.0-1.fc25.noarch.rpm artemis-jms-client-1.2.0-1.fc25.noarch.rpm artemis-jms-server-1.2.0-1.fc25.noarch.rpm artemis-journal-1.2.0-1.fc25.noarch.rpm artemis-maven-plugin-1.2.0-1.fc25.noarch.rpm artemis-native-1.2.0-1.fc25.x86_64.rpm artemis-protocols-1.2.0-1.fc25.noarch.rpm artemis-amqp-protocol-1.2.0-1.fc25.noarch.rpm artemis-hornetq-protocol-1.2.0-1.fc25.noarch.rpm artemis-hqclient-protocol-1.2.0-1.fc25.noarch.rpm artemis-proton-plug-1.2.0-1.fc25.noarch.rpm artemis-stomp-protocol-1.2.0-1.fc25.noarch.rpm artemis-ra-1.2.0-1.fc25.noarch.rpm artemis-rest-1.2.0-1.fc25.noarch.rpm artemis-selector-1.2.0-1.fc25.noarch.rpm artemis-server-1.2.0-1.fc25.noarch.rpm artemis-server-osgi-1.2.0-1.fc25.noarch.rpm artemis-service-extensions-1.2.0-1.fc25.noarch.rpm artemis-web-1.2.0-1.fc25.noarch.rpm artemis-spring-integration-1.2.0-1.fc25.noarch.rpm artemis-pom-1.2.0-1.fc25.noarch.rpm artemis-javadoc-1.2.0-1.fc25.noarch.rpm artemis-1.2.0-1.fc25.src.rpm artemis-boot.noarch: W: no-documentation artemis-cli.noarch: W: no-documentation artemis-dto.noarch: W: no-documentation artemis-jms-client.noarch: W: no-documentation artemis-jms-server.noarch: W: no-documentation artemis-journal.noarch: W: no-documentation artemis-maven-plugin.noarch: W: no-documentation artemis-native.x86_64: W: spelling-error %description -l en_US libaio -> libation artemis-native.x86_64: W: only-non-binary-in-usr-lib artemis-protocols.noarch: W: no-documentation artemis-amqp-protocol.noarch: W: no-documentation artemis-hornetq-protocol.noarch: W: no-documentation artemis-hqclient-protocol.noarch: W: no-documentation artemis-proton-plug.noarch: W: no-documentation artemis-stomp-protocol.noarch: W: no-documentation artemis-ra.noarch: W: no-documentation artemis-rest.noarch: W: no-documentation artemis-selector.noarch: W: no-documentation artemis-server.noarch: W: no-documentation artemis-server-osgi.noarch: W: no-documentation artemis-service-extensions.noarch: W: no-documentation artemis-web.noarch: W: no-documentation artemis-spring-integration.noarch: W: no-documentation artemis-pom.noarch: W: no-documentation artemis.src: W: spelling-error %description -l en_US multi -> mulch, mufti artemis.src: W: spelling-error %description -l en_US embeddable -> embedded 27 packages and 0 specfiles checked; 0 errors, 26 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory artemis-web.noarch: W: no-documentation artemis-journal.noarch: W: no-documentation artemis-hqclient-protocol.noarch: W: no-documentation artemis-pom.noarch: W: no-documentation artemis-cli.noarch: W: no-documentation artemis-server.noarch: W: no-documentation artemis-service-extensions.noarch: W: no-documentation artemis-maven-plugin.noarch: W: no-documentation artemis-server-osgi.noarch: W: no-documentation artemis-jms-client.noarch: W: no-documentation artemis-ra.noarch: W: no-documentation artemis-hornetq-protocol.noarch: W: no-documentation artemis-selector.noarch: W: no-documentation artemis-boot.noarch: W: no-documentation artemis-stomp-protocol.noarch: W: no-documentation artemis-dto.noarch: W: no-documentation artemis-protocols.noarch: W: no-documentation artemis-spring-integration.noarch: W: no-documentation artemis-proton-plug.noarch: W: no-documentation artemis-jms-server.noarch: W: no-documentation artemis-amqp-protocol.noarch: W: no-documentation artemis-rest.noarch: W: no-documentation artemis-native.x86_64: W: spelling-error %description -l en_US libaio -> libation artemis-native.x86_64: W: only-non-binary-in-usr-lib 26 packages and 0 specfiles checked; 0 errors, 24 warnings.

Requires -------- artemis-web (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-cli) mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-dto) mvn(org.eclipse.jetty:jetty-server) mvn(org.eclipse.jetty:jetty-webapp) mvn(org.jboss.logging:jboss-logging)

artemis-journal (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-native) mvn(org.jboss.logging:jboss-logging)

artemis-hqclient-protocol (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-core-client) mvn(org.jboss.logging:jboss-logging)

artemis-pom (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.felix:maven-bundle-plugin) mvn(org.apache.maven.plugins:maven-enforcer-plugin) mvn(org.apache.maven.plugins:maven-help-plugin) mvn(org.apache.maven.plugins:maven-install-plugin) mvn(org.apache.maven.plugins:maven-javadoc-plugin) mvn(org.apache.rat:apache-rat-plugin) mvn(org.apache:apache:pom:)

artemis-cli (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(io.airlift:airline) mvn(org.apache.activemq:artemis-dto) mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-server) mvn(org.jboss.logging:jboss-logging)

artemis-server (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(io.netty:netty-all) mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-journal) mvn(org.apache.activemq:artemis-selector) mvn(org.jboss.logging:jboss-logging)

artemis-commons (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.google.guava:guava) mvn(commons-beanutils:commons-beanutils) mvn(io.netty:netty-all) mvn(org.jboss.logging:jboss-logging)

artemis-service-extensions (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.geronimo.specs:geronimo-jta_1.1_spec) mvn(org.jboss.logging:jboss-logging)

artemis-maven-plugin (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(io.netty:netty-all) mvn(org.apache.activemq:artemis-boot) mvn(org.apache.activemq:artemis-cli) mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-server) mvn(org.apache.maven.plugins:maven-dependency-plugin) mvn(org.apache.maven:maven-plugin-api) mvn(org.eclipse.aether:aether-api) mvn(org.eclipse.aether:aether-util)

artemis-server-osgi (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-journal) mvn(org.apache.activemq:artemis-selector) mvn(org.apache.activemq:artemis-server) mvn(org.apache.activemq:artemis-service-extensions)

artemis-jms-client (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(javax.inject:javax.inject) mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-selector) mvn(org.jboss.spec.javax.jms:jboss-jms-api_2.0_spec)

artemis-ra (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-service-extensions) mvn(org.jboss.logging:jboss-logging)

artemis-hornetq-protocol (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-hqclient-protocol) mvn(org.apache.activemq:artemis-server) mvn(org.jboss.logging:jboss-logging)

artemis-selector (rpmlib, GLIBC filtered): java-headless javapackages-tools

artemis-boot (rpmlib, GLIBC filtered): java-headless javapackages-tools

artemis-stomp-protocol (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-server) mvn(org.jboss.logging:jboss-logging)

artemis-dto (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-commons)

artemis-core-client (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(io.netty:netty-all) mvn(org.apache.activemq:artemis-commons) mvn(org.jgroups:jgroups)

artemis-protocols (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-pom:pom:)

artemis-spring-integration (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-server) mvn(org.jboss.logging:jboss-logging) mvn(org.springframework:spring-beans) mvn(org.springframework:spring-context) mvn(org.springframework:spring-core) mvn(org.springframework:spring-jms)

artemis-proton-plug (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.activemq:artemis-server) mvn(org.apache.qpid:proton-j) mvn(org.jboss.logging:jboss-logging)

artemis-jms-server (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.activemq:artemis-server) mvn(org.apache.activemq:artemis-service-extensions) mvn(org.apache.geronimo.specs:geronimo-ejb_3.0_spec) mvn(org.apache.geronimo.specs:geronimo-jta_1.1_spec) mvn(org.jboss.spec.javax.jms:jboss-jms-api_2.0_spec)

artemis-amqp-protocol (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.activemq:artemis-proton-plug) mvn(org.apache.activemq:artemis-server) mvn(org.apache.qpid:proton-j) mvn(org.apache.qpid:proton-jms) mvn(org.jboss.logging:jboss-logging)

artemis-javadoc (rpmlib, GLIBC filtered): javapackages-tools

artemis-rest (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(io.netty:netty-all) mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-server) mvn(org.apache.geronimo.specs:geronimo-annotation_1.1_spec) mvn(org.jboss.logging:jboss-logging) mvn(org.jboss.resteasy:resteasy-atom-provider) mvn(org.jboss.resteasy:resteasy-jackson-provider) mvn(org.jboss.resteasy:resteasy-jaxb-provider) mvn(org.jboss.resteasy:resteasy-jaxrs) mvn(org.jboss.resteasy:tjws) mvn(org.jboss.spec.javax.jms:jboss-jms-api_2.0_spec)

artemis-native (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.jboss.logging:jboss-logging)

Provides -------- artemis-web: artemis-web mvn(org.apache.activemq:artemis-web) mvn(org.apache.activemq:artemis-web:pom:)

artemis-journal: artemis-journal mvn(org.apache.activemq:artemis-journal) mvn(org.apache.activemq:artemis-journal:pom:)

artemis-hqclient-protocol: artemis-hqclient-protocol mvn(org.apache.activemq:artemis-hqclient-protocol) mvn(org.apache.activemq:artemis-hqclient-protocol:pom:) osgi(org.apache.activemq.artemis-hqclient-protocol)

artemis-pom: artemis-pom mvn(org.apache.activemq:artemis-pom:pom:)

artemis-cli: artemis-cli mvn(org.apache.activemq:artemis-cli) mvn(org.apache.activemq:artemis-cli:pom:)

artemis-server: artemis-server mvn(org.apache.activemq:artemis-server) mvn(org.apache.activemq:artemis-server:pom:)

artemis-commons: artemis-commons mvn(org.apache.activemq:artemis-commons) mvn(org.apache.activemq:artemis-commons:pom:)

artemis-service-extensions: artemis-service-extensions mvn(org.apache.activemq:artemis-service-extensions) mvn(org.apache.activemq:artemis-service-extensions:pom:)

artemis-maven-plugin: artemis-maven-plugin mvn(org.apache.activemq:artemis-maven-plugin) mvn(org.apache.activemq:artemis-maven-plugin:pom:)

artemis-server-osgi: artemis-server-osgi mvn(org.apache.activemq:artemis-server-osgi) mvn(org.apache.activemq:artemis-server-osgi:pom:) osgi(org.apache.activemq.artemis-server-osgi)

artemis-jms-client: artemis-jms-client mvn(org.apache.activemq:artemis-jms-client) mvn(org.apache.activemq:artemis-jms-client:pom:)

artemis-ra: artemis-ra mvn(org.apache.activemq:artemis-ra) mvn(org.apache.activemq:artemis-ra:pom:)

artemis-hornetq-protocol: artemis-hornetq-protocol mvn(org.apache.activemq:artemis-hornetq-protocol) mvn(org.apache.activemq:artemis-hornetq-protocol:pom:) osgi(org.apache.activemq.artemis-hornetq-protocol)

artemis-selector: artemis-selector mvn(org.apache.activemq:artemis-selector) mvn(org.apache.activemq:artemis-selector:pom:)

artemis-boot: artemis-boot mvn(org.apache.activemq:artemis-boot) mvn(org.apache.activemq:artemis-boot:pom:)

artemis-stomp-protocol: artemis-stomp-protocol mvn(org.apache.activemq:artemis-stomp-protocol) mvn(org.apache.activemq:artemis-stomp-protocol:pom:) osgi(org.apache.activemq.artemis-stomp-protocol)

artemis-dto: artemis-dto mvn(org.apache.activemq:artemis-dto) mvn(org.apache.activemq:artemis-dto:pom:)

artemis-core-client: artemis-core-client mvn(org.apache.activemq:artemis-core-client) mvn(org.apache.activemq:artemis-core-client:pom:)

artemis-protocols: artemis-protocols mvn(org.apache.activemq:artemis-protocols:pom:)

artemis-spring-integration: artemis-spring-integration mvn(org.apache.activemq:artemis-spring-integration) mvn(org.apache.activemq:artemis-spring-integration:pom:)

artemis-proton-plug: artemis-proton-plug mvn(org.apache.activemq:artemis-proton-plug) mvn(org.apache.activemq:artemis-proton-plug:pom:) osgi(org.apache.activemq.artemis-proton-plug)

artemis-jms-server: artemis-jms-server mvn(org.apache.activemq:artemis-jms-server) mvn(org.apache.activemq:artemis-jms-server:pom:)

artemis-amqp-protocol: artemis-amqp-protocol mvn(org.apache.activemq:artemis-amqp-protocol) mvn(org.apache.activemq:artemis-amqp-protocol:pom:) osgi(org.apache.activemq.artemis-amqp-protocol)

artemis-javadoc: artemis-javadoc

artemis-rest: artemis-rest mvn(org.apache.activemq.rest:artemis-rest) mvn(org.apache.activemq.rest:artemis-rest:pom:)

artemis-native: artemis-native artemis-native(x86-64) mvn(org.apache.activemq:artemis-native) mvn(org.apache.activemq:artemis-native:pom:) osgi(org.apache.activemq.artemis-native)

Source checksums ---------------- http://www.apache.org/dist/activemq/activemq-artemis/1.2.0/apache-artemis-1.... : CHECKSUM(SHA256) this package : f6e800be1640a4d319e4a738c07e295b0be9e1f0ccba7a13ffdc61ba78510088 CHECKSUM(SHA256) upstream package : f6e800be1640a4d319e4a738c07e295b0be9e1f0ccba7a13ffdc61ba78510088

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1343063 Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++ Disabled plugins: Python, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:01 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #2 from gil cattaneo puntogil@libero.it --- (In reply to Michael Simacek from comment #1)

...

Package Review

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues:

Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1024000 bytes in 89 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

I don't like this XPath expression: %pom_xpath_remove pom:configuration artemis-server-osgi It's too general, it will remove any configuration of any plugin that might appear there in the future. Please make it more specific.

Can you put a comment about the patch above it?

There's artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java file under public domain

"Evil MIT" under

/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json You'll need to remove this code and replace with an alternative. You should also inform upstream that they bundle non-free code.

Upstream is no interested to replace json.org with other alternative, already contacted for other projects e.g. tika and solr. For they the json.org license is not a problem

...

You should use cmake macro. https://fedoraproject.org/wiki/Packaging:Cmake

artemis-native/README contains only build instructions, it shouldn't be installed

Too much work for replace json.org with an alternative. Closed this bug. Thanks for your help i am not aware of that .... of json bundle in the code

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:03 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:19 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Jun 18 Jun

5:43 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #3 from gil cattaneo puntogil@libero.it --- (In reply to gil cattaneo from comment #2)

...

(In reply to Michael Simacek from comment #1)

...
Package Review

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues:

Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1024000 bytes in 89 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Done

...

...

I don't like this XPath expression: %pom_xpath_remove pom:configuration artemis-server-osgi It's too general, it will remove any configuration of any plugin that might appear there in the future. Please make it more specific.

Can you put a comment about the patch above it?

Done

...

...

There's artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java

Done "Provides: bundled(java-base64) = 2.2.2"

...

...
file under public domain

"Evil MIT" under

/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json You'll need to remove this code and replace with an alternative. You should also inform upstream that they bundle non-free code.

Upstream is no interested to replace json.org with other alternative, already contacted for other projects e.g. tika and solr. For they the json.org license is not a problem

...

You should use cmake macro. https://fedoraproject.org/wiki/Packaging:Cmake

artemis-native/README contains only build instructions, it shouldn't be installed

Too much work for replace json.org with an alternative. Closed this bug. Thanks for your help i am not aware of that .... of json bundle in the code

Open https://issues.apache.org/jira/browse/ARTEMIS-565

- update to 1.3.0

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Jun 30 Jun

1:29 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1348297

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1348297 [Bug 1348297] Update to 5.2.12.Final

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Jul 18 Jul

3:30 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

--- Comment #4 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/artemis.spec SRPM URL: https://gil.fedorapeople.org/artemis-1.3.0-2.fc23.src.rpm

- replace json.org with javax.json

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14934508

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Jul 20 Jul

11:17 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #5 from Michael Simacek msimacek@redhat.com --- AS we talked on IRC, you should also remove the json.org license from LICENSE file.

Also, can you use %cmake macro? It should set the CFLAGS for you.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:54 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #6 from gil cattaneo puntogil@libero.it --- (In reply to Michael Simacek from comment #5)

...

AS we talked on IRC, you should also remove the json.org license from LICENSE file.

fro this i waiting a upstream response

...

Also, can you use %cmake macro? It should set the CFLAGS for you.

sorry for my ignorance, i should change cmake line in this way? %cmake -DCMAKE_C_FLAGS:STRING="${CFLAGS:-%optflags}" -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS:-%optflags}" .

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:10 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #7 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/artemis.spec SRPM URL: https://gil.fedorapeople.org/artemis-1.3.0-2.fc23.src.rpm

- replace json.org with javax.json and remove the json.org license from LICENSE file.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

22 Jul 22 Jul

3:44 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1358980

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1358980 [Bug 1358980] Review Request: johnzon - Implementation of JSR-353

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

25 Jul 25 Jul

9:51 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #8 from Michael Simacek msimacek@redhat.com --- (In reply to gil cattaneo from comment #6)

...

(In reply to Michael Simacek from comment #5)

...
AS we talked on IRC, you should also remove the json.org license from LICENSE file.

fro this i waiting a upstream response

...
Also, can you use %cmake macro? It should set the CFLAGS for you.

sorry for my ignorance, i should change cmake line in this way? %cmake -DCMAKE_C_FLAGS:STRING="${CFLAGS:-%optflags}" -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS:-%optflags}" .

I think using just: %cmake . should be enough.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:53 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #9 from gil cattaneo puntogil@libero.it --- (In reply to Michael Simacek from comment #8)

...

I think using just: %cmake . should be enough.

Done

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:04 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #10 from gil cattaneo puntogil@libero.it --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15014104

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

26 Jul 26 Jul

1:56 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Michael Simacek msimacek@redhat.com changed:

--- Comment #11 from Michael Simacek msimacek@redhat.com --- Looks ok now. APPROVED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:04 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #12 from gil cattaneo puntogil@libero.it --- Thanks for the review!

create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/6636 https://admin.fedoraproject.org/pkgdb/package/requests/6637

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:32 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/artemis

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Jul 29 Jul

1:28 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1359246

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1359246 [Bug 1359246] Review Request: netty5 - An asynchronous event-driven network application framework and tools for Java

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Aug 4 Aug

9:54 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063 Bug 1343063 depends on bug 1358980, which changed state.

Bug 1358980 Summary: Review Request: johnzon - Implementation of JSR-353 https://bugzilla.redhat.com/show_bug.cgi?id=1358980

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Aug 18 Aug

12:07 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-890632cdbc

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:07 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:27 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6c13fc715

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:54 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-890632cdbc

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

19 Aug 19 Aug

1:59 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6c13fc715

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

26 Aug 26 Aug

11:22 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:22 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Aug 27 Aug

11:23 a.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- artemis-1.4.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Aug 29 Aug

5:24 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1181081

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1181081 [Bug 1181081] wildfly: Upgrade to 10.1.0.Final

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

4 Dec 4 Dec

1:50 p.m.

New subject: [Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system

https://bugzilla.redhat.com/show_bug.cgi?id=1343063 Bug 1343063 depends on bug 1359246, which changed state.

Bug 1359246 Summary: Review Request: netty41 - An asynchronous event-driven network application framework and tools for Java https://bugzilla.redhat.com/show_bug.cgi?id=1359246

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2131

Age (days ago)

3042

Last active (days ago)

package-review@lists.fedoraproject.org

30 comments

2 participants

tags (0)

participants (2)

bugzilla＠redhat.com
Red Hat Bugzilla