Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: elliptics - Distributed hash table storage
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Summary: Review Request: elliptics - Distributed hash table storage Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian.deutsch@gmx.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.informatik.uni-bremen.de/~fabiand/fedora/elliptics/1/elliptics.sp... SRPM URL: http://www.informatik.uni-bremen.de/~fabiand/fedora/elliptics/1/elliptics-2.... Description: Elliptics network/dnet is a fault tolerant distributed hash table object storage. This package includes an example ioserver and a FastCGI interface.
Note: Future versions of POHMELFS will be using elliptics/dnet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #1 from Fabian Deutsch fabian.deutsch@gmx.de 2010-03-01 20:36:36 EST --- [fabiand@proprietary rpmbuild]$ rpmlint -v SPECS/elliptics.spec SRPMS/elliptics-2.6.4-1.fc14.src.rpm RPMS/i686/elliptics-* SPECS/elliptics.spec: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.6.4.tar.gz (timeout 10 seconds) elliptics.src: I: checking elliptics.src: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.src: W: spelling-error %description -l en_US ioserver -> observer, timeserver, servery elliptics.src: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.src: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.6.4.tar.gz (timeout 10 seconds) elliptics.i686: I: checking elliptics.i686: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.i686: W: spelling-error %description -l en_US ioserver -> observer, timeserver, servery elliptics.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-debuginfo.i686: I: checking elliptics-debuginfo.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.i686: I: checking elliptics-devel.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 4 warnings.
spelling-error: Nope. dnet is correct.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #2 from Fabian Deutsch fabian.deutsch@gmx.de 2010-03-01 20:38:11 EST --- What might be a bit confusing is the naming of the project and package. I chose to use elliptics as it is popular upstream and dnet is already taken (libdnet).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #3 from Fabian Deutsch fabian.deutsch@gmx.de 2010-03-01 20:39:08 EST --- Oh. When thinking about this: There are naming conflicts. libdnet provides libdnet.so as elliptics does to. What can be done?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-02 01:50:26 EST --- First contacting the upstream is better.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #5 from Fabian Deutsch fabian.deutsch@gmx.de 2010-03-02 17:07:15 EST --- Upstream has been contacted, is open about changing the name. No conflict appeard up to now, because the conflicting package libdnet wasn't present.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@uos.de
--- Comment #6 from Martin Gieseking martin.gieseking@uos.de 2010-06-15 03:30:53 EDT --- Hi Fabian, are you still interested in this package? In the meantime, upstream released several updates. Maybe you'd like to update the package, too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #7 from Fabian Deutsch fabian.deutsch@gmx.de 2010-06-15 03:38:24 EDT --- Hi, yes I am. I waited for upstream to change it's name, to solve the naming conflict with libdnet. As this did not happen I'm planning to add a Conflicts tag to the spec.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #8 from Martin Gieseking martin.gieseking@uos.de 2010-06-15 03:42:23 EDT --- OK, that's fine. Thanks for the info.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #9 from Fabian Deutsch fabian.deutsch@gmx.de 2010-06-16 08:15:46 EDT --- So, I upted the spec ad fixed two problems: - Removed DSO fix (fiexd upstream) - Removed rpath for x86_64
rpmlint just throws a couple of warning about non existant man-pages (see below).
SPEC and SRPM: http://fedorapeople.org/~fabiand/elliptics/ Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=2253194
rpmlint: $ rpmlint -v elliptics-* elliptics.i686: I: checking elliptics.i686: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.i686: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.i686: W: no-manual-page-for-binary dnet_fcgi elliptics.i686: W: no-manual-page-for-binary dnet_check_merge elliptics.i686: W: no-manual-page-for-binary dnet_check_create elliptics.i686: W: no-manual-page-for-binary dnet_stat elliptics.i686: W: no-manual-page-for-binary dnet_iotest elliptics.i686: W: no-manual-page-for-binary dnet_check_log elliptics.i686: W: no-manual-page-for-binary dnet_notify elliptics.i686: W: no-manual-page-for-binary dnet_hparser elliptics.i686: W: no-manual-page-for-binary dnet_ioserv elliptics.src: I: checking elliptics.src: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.src: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.src: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.src: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.8.0.tar.gz (timeout 10 seconds) elliptics.x86_64: I: checking elliptics.x86_64: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.x86_64: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.x86_64: W: no-manual-page-for-binary dnet_fcgi elliptics.x86_64: W: no-manual-page-for-binary dnet_check_merge elliptics.x86_64: W: no-manual-page-for-binary dnet_check_create elliptics.x86_64: W: no-manual-page-for-binary dnet_stat elliptics.x86_64: W: no-manual-page-for-binary dnet_iotest elliptics.x86_64: W: no-manual-page-for-binary dnet_check_log elliptics.x86_64: W: no-manual-page-for-binary dnet_notify elliptics.x86_64: W: no-manual-page-for-binary dnet_hparser elliptics.x86_64: W: no-manual-page-for-binary dnet_ioserv elliptics-debuginfo.i686: I: checking elliptics-debuginfo.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-debuginfo.x86_64: I: checking elliptics-debuginfo.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.i686: I: checking elliptics-devel.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.x86_64: I: checking elliptics-devel.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) 7 packages and 0 specfiles checked; 0 errors, 24 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #10 from Martin Gieseking martin.gieseking@uos.de 2010-06-17 15:25:43 EDT --- Here are a couple of quick comments:
- in the first line, replace %define with %global
- according to the source file headers, the license is GPLv2+, not GPLv2
- I suggest to use the default %description for the devel package: The %{name}-devel package contains libraries and header files for developing applications that use %{name}.
- remove the duplicate %defattr line in %files devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #11 from Fabian Deutsch fabian.deutsch@gmx.de 2010-06-19 12:32:24 EDT --- Thanks Martin.
I applied those changes. Spec and srpm can be found at http://fedorapeople.org/~fabiand/elliptics/
A quick rpmlint on local files just shows the usual warnings. Koji build was also fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #12 from Martin Gieseking martin.gieseking@uos.de 2010-06-21 07:55:25 EDT --- Hi Fabian,
since using Conflicts should be avoided in Fedora packages, I suggest to move the library (and its symlinks) to a subdirectory of %{_libdir}, e.g. %{_libdir}/elliptics/, as long as the conflict persists. In this case, you also have to add a file elliptics-%{_arch}.conf to /etc/ld.so.conf.d containing the directory where the library is located. Nonetheless, it would be much better if upstream renamed the library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #13 from Jussi Lehtola jussi.lehtola@iki.fi 2010-06-21 08:34:37 EDT --- (In reply to comment #12)
Hi Fabian,
since using Conflicts should be avoided in Fedora packages, I suggest to move the library (and its symlinks) to a subdirectory of %{_libdir}, e.g. %{_libdir}/elliptics/, as long as the conflict persists. In this case, you also have to add a file elliptics-%{_arch}.conf to /etc/ld.so.conf.d containing the directory where the library is located. Nonetheless, it would be much better if upstream renamed the library.
I hope the library function names don't clash with those in libdnet, since otherwise also this is asking for trouble.
Upstream should rename the tarball to 'elliptics'. However, until that happens this review has the wrong name, as per Fedora naming guidelines. The correct package name would be, of course, dnet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #14 from Martin Gieseking martin.gieseking@uos.de 2010-06-21 10:05:28 EDT --- (In reply to comment #13)
I hope the library function names don't clash with those in libdnet, since otherwise also this is asking for trouble.
As far as I see, there are no symbol naming conflicts.
Upstream should rename the tarball to 'elliptics'. However, until that happens this review has the wrong name, as per Fedora naming guidelines. The correct package name would be, of course, dnet.
If I understand the naming guidelines correctly, the package name could also be elliptics, since it's the name of the project:
"When naming a package, the name should match the upstream tarball or project name from which this software came."
But maybe I just didn't get the intended meaning.
However, I find it pretty strange to call the project "elliptics" and use "dnet" everywhere else. So, dnet is perhaps indeed the better package name.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
--- Comment #15 from Fabian Deutsch fabian.deutsch@gmx.de 2010-07-02 05:49:28 EDT --- I'm currently quite bussy at the moment. When I get a bit of time, I will take the points above to resolve the current Conflict with libdnet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |StalledSubmitter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks| |201449(FE-DEADREVIEW) Resolution| |NOTABUG Status Whiteboard|StalledSubmitter | Last Closed| |2010-12-17 12:50:47
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Fabian Deutsch fabian.deutsch@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG | Keywords| |Reopened
--- Comment #16 from Fabian Deutsch fabian.deutsch@gmx.de 2011-05-17 07:50:39 EDT --- Upstream finally resolved the conflict. I am reopening this ticket.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569671
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Blocks|201449(FE-DEADREVIEW) |
--- Comment #17 from Jason Tibbitts tibbs@math.uh.edu 2011-06-08 16:13:55 EDT --- The only direct URLs to the spec and srpm (in the original comment) are invalid. Please post correct and direct URLs to the spec and srpm. Also, you neglected to unblock FE-DEADREVIEW. I cleared that out for you.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla