[Bug 520343] New: Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: clc - command line client for MUDs

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Summary: Review Request: clc - command line client for MUDs
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://middleditch.us/sean/clc.spec
SRPM URL: http://middleditch.us/sean/clc-0.01-1.fc12.src.rpm
Description: Very simplistic MUD client for command line usage.

Note: Requires the libtelnet package under review at bug #515832.

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

--- Comment #1 from Sean Middleditch   2009-09-06 05:57:23 EDT ---
Spec URL: http://middleditch.us/sean/clc.spec
SRPM URL: http://middleditch.us/sean/clc-0.01-2.fc12.src.rpm

Fixed a typo I just caught in the source URL for the spec file.  Updated to
release -2 and added a changelog note.

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |515832

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Bug 520343 depends on bug 515832, which changed state.

Bug 515832 Summary: Review Request: libtelnet - TELNET protocol handling library
https://bugzilla.redhat.com/show_bug.cgi?id=515832

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

--- Comment #2 from Sean Middleditch   2009-09-12 16:17:30 EDT ---
Now that libtelnet is in F12, I tried a scratch build on Koji.  That made it
clear that I forgot some build requires on packages I had installed on my local
machine (Koji is damn handy that way).  Updated to 0.01-3 with the build
requires added.  Verified it works on Koji now.

Spec URL: http://middleditch.us/sean/clc.spec
SRPM URL: http://middleditch.us/sean/clc-0.01-3.fc12.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=1674042

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sean@middleditch.
                   |                            |us)

--- Comment #3 from Jan Klepek   2009-09-18 09:12:23 EDT ---
1]
i didn't see there usage of fedora compiler flags.
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

2] 
md5sum of download from SOURCE is different from tar which is in src.rpm
b6043dececbaa61e8a3b26a2bda33d38  clc-0.01.tar.gz
ed6d17913a6f8e1d9db4a210f5edef34  SOURCES/clc-0.01.tar.gz

3] macros usage
use only one style of macros or variable. not both in one spec file. so you
eiter replace variables with corresponding macros or macros with variables.
http://fedoraproject.org/wiki/Packaging/Guidelines#macros

otherwise it looks good
spec file is in english and have correct name
directories, files and ownership is correct
compiling/building ok
dependencies ok
clean section present

please fix 1],2],3].

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Sean Middleditch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(sean@middleditch. |
                   |us)                         |

--- Comment #4 from Sean Middleditch   2009-09-19 17:04:03 EDT ---
1) I am now explicitly setting the CFLAGS in the spec file, which both adds the
Fedora optimization flags and also overrides the Makefile's defaults (so the
spec file has to include a couple flags specific to clc).

2) Annoyingly, the tarballs were identical in contents other than timestamps on
the files.  I made sure I have the tarball directly from upstream in SOURCES
now.

3) The package is using the macros/variables consistently.  I had
$RPM_BUILD_ROOT only and no references to %{buildroot}.  The link you provided
states that I should use one or the other (with no official preference towards
either) and that I should not mix usage of $RPM_BUILD_ROOT and %{buildroot} in
a single spec file, which I already complied with.  I converted to the macro
style anyway since it looks nicer IMO, and I used the macro style for
%{optflags} as well.

New files:

Spec URL: http://middleditch.us/sean/clc.spec
SRPM URL: http://middleditch.us/sean/clc-0.01-4.fc12.src.rpm

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Jan Klepek   2009-09-24 03:05:57 EDT ---
approved

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Sean Middleditch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Sean Middleditch   2009-09-24 03:54:13 EDT ---
New Package CVS Request
=======================
Package Name: clc
Short Description: Very simplistic MUD client for command line usage
Owners: elanthis
Branches: F12

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-09-24 12:27:17 EDT ---
cvs done.

[Bug 520343] Review Request: clc - command line client for MUDs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520343

Sean Middleditch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE