[Bug 1730907] New: Review Request: golang-github-mikioh-ipaddr - Basic functions for the manipulation of IP address prefixes
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Bug ID: 1730907 Summary: Review Request: golang-github-mikioh-ipaddr - Basic functions for the manipulation of IP address prefixes Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mikioh-ipaddr.spe... SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mikioh-ipaddr-0-0...
Description: Package ipaddr provides basic functions for the manipulation of IP address prefixes and subsequent addresses as described in RFC 4632 and RFC 4291.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36309269
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1730911 (wgctrl)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1730911 [Bug 1730911] Review Request: wgctrl - Control of WireGuard interfaces on multiple platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |quantum.analyst@gmail.com Assignee|nobody@fedoraproject.org |quantum.analyst@gmail.com Flags| |fedora-review+
--- Comment #2 from Elliott Sales de Andrade quantum.analyst@gmail.com --- LGTM
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License". 18 files have unknown license. Detailed output of licensecheck in 1730907-golang-github-mikioh-ipaddr/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-mikioh-ipaddr-0-0.1.20190717gitd465c8a.fc31.src.rpm golang-github-mikioh-ipaddr.src: W: no-%build-section golang-github-mikioh-ipaddr.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables! 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/mikioh/ipaddr/archive/d465c8ab672111787b24b8f03326449059a... : CHECKSUM(SHA256) this package : de65fbbf4d0b89fd356a79a10e1a55904739d6a549484e8bdb118d5efb71d11c CHECKSUM(SHA256) upstream package : de65fbbf4d0b89fd356a79a10e1a55904739d6a549484e8bdb118d5efb71d11c
Requires --------
Provides --------
Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1730907 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, SugarActivity, Python, PHP, R, Ocaml, Java, Perl, Haskell, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
--- Comment #3 from Mohan Boddu mboddu@bhujji.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mikioh-ipaddr
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-3dc1c2773a has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3dc1c2773a
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-9505328dd6 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9505328dd6
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-mikioh-ipaddr-0-0.1.20190720gitd465c8a.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3dc1c2773a
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-mikioh-ipaddr-0-0.1.20190720gitd465c8a.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9505328dd6
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-08-04 01:13:13
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-mikioh-ipaddr-0-0.1.20190720gitd465c8a.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1730907
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-mikioh-ipaddr-0-0.1.20190720gitd465c8a.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com