[Bug 739347] New: Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed
entropy into random pool

https://bugzilla.redhat.com/show_bug.cgi?id=739347

           Summary: Review Request: haveged - A Linux entropy source using
                    the HAVEGE algorithm. Feed entropy into random pool
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: hladky.jiri(a)gmail.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
    Classification: Fedora
      Story Points: ---
              Type: ---


Spec URL: http://jhladky.fedorapeople.org/haveged.spec
SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-0.fc14.src.rpm
Description: 
A Linux entropy source using the HAVEGE algorithm

Haveged is a user space entropy daemon which is not dependent upon the
standard mechanisms for harvesting randomness for the system entropy
pool. This is important in systems with high entropy needs or limited
user interaction (e.g. headless servers).

Haveged uses HAVEGE (HArdware Volatile Entropy Gathering and Expansion)
to maintain a 1M pool of random bytes used to fill /dev/random
whenever the supply of random bits in /dev/random falls below the low
water mark of the device. The principle inputs to haveged are the
sizes of the processor instruction and data caches used to setup the
HAVEGE collector. The haveged default is a 4kb data cache and a 16kb
instruction cache. On machines with a cpuid instruction, haveged will
attempt to select appropriate values from internal tables.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola(a)iki.fi

--- Comment #1 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-21 02:55:59 EDT
---
Patch0 doesn't have a comment in the spec file. Please document what it does.

Is there any reason why you macroize everything? Why not run just automake,
make and so on?

Is SMP build not supported?

Please use cp or install instead of mv in %install, so that shortcutting builds
work. Besides, why do you
 %{__mv} init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged
 %{__rm} -rf %{buildroot}/etc/init.d
since at least on F15
 $ rpm --eval %{_initrddir}
 /etc/rc.d/init.d
 $ file /etc/init.d
 /etc/init.d: symbolic link to `rc.d/init.d'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-21 17:47:39 EDT ---
Just tested hwloc-1.2.1, bug is still there, contacting hwloc developers

ppc-koji build --scratch dist-f16 rpmbuild/SRPMS/hwloc-1.2.1-0.fc14.src.rpm


PASS: glibc-sched
exported to buffer 0x10568a30 length 1835
re-exported to buffer 0x1056d118 length 1834
### First exported buffer is:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE topology SYSTEM "hwloc.dtd">
<topology>
  <object type="Machine" os_level="-1" os_index="0"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" local_memory="16091512832">
    <page_type size="17179869184" count="0"/>
    <page_type size="65536" count="245537"/>
    <page_type size="16777216" count="0"/>
    <info name="Backend" value="Linux"/>
    <info name="OSName" value="Linux"/>
    <info name="OSRelease" value="2.6.32-131.6.1.el6.ppc64"/>
    <info name="OSVersion" value="#1 SMP Mon Jun 20 14:15:43 EDT
2011"/>
    <info name="HostName" value="ppc-comm01"/>
    <info name="Architecture" value="ppc"/>
    <object type="Socket" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003">
      <object type="Cache" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" cache_size="4194304" depth="2"
cache_linesize="128">
        <object type="Cache" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" cache_size="65536" depth="1"
cache_linesize="128">
          <object type="Core" os_level="-1" os_index="0"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003">
            <object type="PU" os_level="-1" os_index="0"
cpuset="0x00000001"
complete_cpuset="0x00000001" online_cpuset="0x00000001"
allowed_cpuset="0x00000001"/>
            <object type="PU" os_level="-1" os_index="1"
cpuset="0x00000002"
complete_cpuset="0x00000002" online_cpuset="0x00000002"
allowed_cpuset="0x00000002"/>
          </object>
        </object>
      </object>
    </object>
  </object>
</topology>
### End of first export buffer
### Second exported buffer is:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE topology SYSTEM "hwloc.dtd">
<topology>
  <object type="Machine" os_level="-1" os_index="0"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" local_memory="16091512832">
    <page_type size="4294967295" count="0"/>
    <page_type size="65536" count="245537"/>
    <page_type size="16777216" count="0"/>
    <info name="Backend" value="Linux"/>
    <info name="OSName" value="Linux"/>
    <info name="OSRelease" value="2.6.32-131.6.1.el6.ppc64"/>
    <info name="OSVersion" value="#1 SMP Mon Jun 20 14:15:43 EDT
2011"/>
    <info name="HostName" value="ppc-comm01"/>
    <info name="Architecture" value="ppc"/>
    <object type="Socket" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003">
      <object type="Cache" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" cache_size="4194304" depth="2"
cache_linesize="128">
        <object type="Cache" os_level="-1"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003" cache_size="65536" depth="1"
cache_linesize="128">
          <object type="Core" os_level="-1" os_index="0"
cpuset="0x00000003"
complete_cpuset="0x00000003" online_cpuset="0x00000003"
allowed_cpuset="0x00000003">
            <object type="PU" os_level="-1" os_index="0"
cpuset="0x00000001"
complete_cpuset="0x00000001" online_cpuset="0x00000001"
allowed_cpuset="0x00000001"/>
            <object type="PU" os_level="-1" os_index="1"
cpuset="0x00000002"
complete_cpuset="0x00000002" online_cpuset="0x00000002"
allowed_cpuset="0x00000002"/>
          </object>
        </object>
      </object>
    </object>
  </object>
</topology>
### End of second export buffer
FAIL: xmlbuffer
========================================================
1 of 26 tests failed
Please report to http://www.open-mpi.org/community/help/
========================================================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |hladky.jiri(a)gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #3 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-21 17:53:12 EDT ---
Please ignore https://bugzilla.redhat.com/show_bug.cgi?id=739347#c2 
I have updated wrong BZ

Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #4 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-21 19:17:56 EDT ---
(In reply to comment #1)

Hi Jussi,

please see my comments bellow:

>  Patch0 doesn't have a comment in the spec file. Please document
> what it does. 
It's coming update to the version 1.3 of haveged. I have documented it now in
the SPEC file. 

>  Is there any reason why you macroize everything? Why not run just
> automake,
>  make and so on? 
Not really. I was not sure which way is preferred. I have changed
it now to rm,
make, install and so on.

>  Is SMP build not supported? 
It's supported. I have just
added it.


>  Please use cp or install instead of mv in %install, so that
> shortcutting builds
>  work. 
Done.

>  Besides, why do you
>   %{__mv} init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged
>   %{__rm} -rf %{buildroot}/etc/init.d
>  since at least on F15
>   $ rpm --eval %{_initrddir}
>   /etc/rc.d/init.d
>   $ file /etc/init.d
>   /etc/init.d: symbolic link to `rc.d/init.d' 
Changed it to
rm -rf %{buildroot}/etc/init.d
install -m755 -D init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged

Since /etc/init.d is a symbolic link I believe it's better to install files
into the master directory %{_initrddir} == /etc/rc.d/init.d

Besides that, I prefer to use MACRO %{_initddir} instead of
%{_sysconfdir}/init.d (which would expand to /etc/init.d)

Please let me know your opinion on this. Is there a reason to prefer
/etc/init.d over /etc/rc.d/init.d? Is there a macro that expands to /etc/init.d
??

New SPEC File and SRPM:

Spec URL: http://jhladky.fedorapeople.org/hwloc-1.0.2-1.spec
SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-1.fc14.src.rpm

Scratch build:
koji build --scratch dist-f15 SRPMS/haveged-1.2-1.fc14.src.rpm 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3369279

Thanks for the input!
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|hladky.jiri(a)gmail.com       |nobody(a)fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #5 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-22 03:09:51 EDT
---
But my question is: why do you run
 rm -rf %{buildroot}/etc/init.d
in the first place?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #6 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-22 18:48:07 EDT ---
(In reply to comment #5)
>  But my question is: why do you run
>   rm -rf %{buildroot}/etc/init.d
>  in the first place? 
Hi Jussi,

two reasons:

1)There is generic haveged start script. This one is installed to /etc/init.d.
However, this script does not work well on Fedora. I need to use haveged_fedora

That's why I rename the script:

install -m755 -D init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged

2) I would like to install start script into /etc/rc.d/init.d directory. 

What's your opinion?

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #7 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-23 02:45:54 EDT
---
(In reply to comment #6)
>  (In reply to comment #5)
>  > But my question is: why do you run
>  >  rm -rf %{buildroot}/etc/init.d
>  > in the first place?
>  
>  1)There is generic haveged start script. This one is installed to /etc/init.d. 
OK, then please make a note about this in the spec file. Note that you don't
necessarily need to remove the generic script if you just replace it with the
Fedora specific script.

>  However, this script does not work well on Fedora. I need to use
> haveged_fedora
>  
>  That's why I rename the script:
>  
>  install -m755 -D init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged
>  
>  2) I would like to install start script into /etc/rc.d/init.d directory.  
http://fedoraproject.org/wiki/Packaging:SysVInitScript
"Packages with SysV-style initscripts must put them into /etc/rc.d/init.d. A
rpm macro exists for this directory, %_initddir."

So the directory itself is fine, but you should use a different macro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #8 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-23 02:47:28 EDT
---
(In reply to comment #7)
>  (In reply to comment #6)
>  > (In reply to comment #5)
>  > > But my question is: why do you run
>  > >  rm -rf %{buildroot}/etc/init.d
>  > > in the first place?
>  > 
>  > 1)There is generic haveged start script. This one is installed to /etc/init.d.
>  
>  OK, then please make a note about this in the spec file. Note that you don't
>  necessarily need to remove the generic script if you just replace it with the
>  Fedora specific script. 
.. although this still does not explain why you run the command. You're just
removing a symlink. Please remove the line altogether.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #9 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-23 18:48:08 EDT ---
Hi Jussi,

I have tried to remove
rm -rf %{buildroot}/etc/init.d
line and it does not work:

========================================================================
rpmbuild -ba SPECS/haveged.spec

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/jirka/rpmbuild/BUILDROOT/haveged-1.2-1.fc14.i386
error: Installed (but unpackaged) file(s) found:
   /etc/init.d/haveged


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /etc/init.d/haveged
========================================================================

To summarize:
make install of the package havege will install generic script to
/etc/init.d/haveged

We need to:
Install Fedora specific script to /etc/rc.d/init.d directory

Since we don't want /etc/init.d/haveged to be packed into rpm, we need to
remove it from the %{buildroot} directory otherwise rpm built-in check will
give us an error described above.


Resolution:
I have added following comment to the spec file
#Installing Fedora specific haveged SysV-style initscript 
#http://fedoraproject.org/wiki/Packaging:SysVInitScript
#Need to remove haveged specific script from %{buildroot} since it's installed
to the wrong location 
#(/etc/init.d instead of /etc/rc.d/init.d)

New SPEC File and SRPM:
Spec URL: http://jhladky.fedorapeople.org/haveged-1.2-2.fc14.spec
SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-2.fc14.src.rpm

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #10 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-25 18:53:58 EDT
---
Hi Jussi,

have you had time to review the latest SPEC file? 

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |jussi.lehtola(a)iki.fi
               Flag|                            |fedora-review?

--- Comment #11 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-26 03:07:26 EDT
---
Very well. I now see that the rm -rf line is necessary, since for some reason
/etc/init.d is a directory and not a symlink as on installed Fedoras.

Here's my review:

***

rpmlint output:
haveged.src: W: spelling-error %description -l en_US dev -> deb, derv, div
haveged.src: W: spelling-error %description -l en_US cpuid -> cupid
haveged.src: W: spelling-error %description -l en_US stdout -> stout, std out,
std-out
haveged.src:63: W: macro-in-comment %{buildroot}
haveged.src:91: W: macro-in-comment %attr
haveged.src:91: W: macro-in-comment %{_initrddir}
haveged.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div
haveged.x86_64: W: spelling-error %description -l en_US cpuid -> cupid
haveged.x86_64: W: spelling-error %description -l en_US stdout -> stout, std
out, std-out
haveged.x86_64: W: incoherent-subsys /etc/rc.d/init.d/haveged $prog
3 packages and 0 specfiles checked; 0 errors, 10 warnings.

- Patch0 is missing a comment, still. Please add one in the spec file.
- Please drop the "Apply patches: " comment and the following commented line.
- Please drop the commented line in %files.
- The "spelling-errors" are false alarms.
- Fix the subsystem stuff.


MUST: The spec file for the package is legible and macros are used
consistently.  OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- License is GPLv3+, not GPLv3.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
$ md5sum haveged-1.2.tar.gz ../SOURCES/haveged-1.2.tar.gz 
dc961f36c065239f2ddeeb840ddf9ec0  haveged-1.2.tar.gz
dc961f36c065239f2ddeeb840ddf9ec0  ../SOURCES/haveged-1.2.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A

MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
- ... but *please* don't use wildcards for just one or two files. Change
 %{_mandir}/man8/*
 %{_sbindir}/*
 %{_initrddir}/*
to
 %{_mandir}/man8/haveged.8*
 %{_sbindir}/haveged
 %{_initrddir}/haveged
or the same using %{name}, both of which have the same effect as the wildcard
but make the %files section MUCH clearer.

MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #12 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-26 18:05:12 EDT
---
(In reply to comment #11)

Hi,

please see my comments bellow:

>  - Patch0 is missing a comment, still. Please add one in the spec
> file. 
Well, I have added following text to he description already in 
https://bugzilla.redhat.com/show_bug.cgi?id=739347#c4

===================================================================
Patch represents changes planed for the version 1.3:
1)Changed run levels:
0=daemon
-1=configuration info
-2=write Bytes to stdout without limit
> 0 write <r> Bytes to file. Units k,m,g,t are supported: 

2)Added option to write random bytes to stdout: -f -
===================================================================

Not sure if I got it wrong - is there special section for it? Or perhaps you
have just overlooked it. Please let me know.


>  - Please drop the "Apply patches: " comment and the
> following commented line. 
Done

>  - Please drop the commented line in %files. 
Done

>  - The "spelling-errors" are false alarms.
>  - Fix the subsystem stuff. 
It also false alarm. Please run
rpmlint -i

to see the detailed explanation:

haveged.i686: W: incoherent-subsys /etc/rc.d/init.d/haveged ${prog}
...... It is also possible
that rpmlint gets this wrong, especially if the init script contains
nontrivial shell variables and/or assignments.  These cases usually manifest
themselves when rpmlint reports that the subsys name starts a with '$'; in
these cases a warning instead of an error is reported and you should check the
script manually.

Init script is indeed using a variable.


>  NEEDSWORK
>  - License is GPLv3+, not GPLv3. 
Good hint, thanks!

>  - ... but *please* don't use wildcards for just one or two files.
> Change
>   %{_mandir}/man8/*
>   %{_sbindir}/*
>   %{_initrddir}/*
>  to
>   %{_mandir}/man8/haveged.8*
>   %{_sbindir}/haveged
>   %{_initrddir}/haveged
>  or the same using %{name}, both of which have the same effect as the wildcard
>  but make the %files section MUCH clearer. 
Done.

Spec URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.spec
SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.src.rpm

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-26 18:19:35 EDT
---
(In reply to comment #12)
>  > - Patch0 is missing a comment, still. Please add one in the spec
> file.
>  Well, I have added following text to he description already in 
>  https://bugzilla.redhat.com/show_bug.cgi?id=739347#c4 
... you put it at the end of %description? Well, that's the wrong place to put 
it. When you have a bunch of patches, then you'd like to see what they're for.
For instance:

# Link to foo correctly
Patch0: haveged-1.2.3-foo.patch
# Don't do bar on install
Patch1: haveged-1.2.3-nobar.patch

>  haveged.i686: W: incoherent-subsys /etc/rc.d/init.d/haveged ${prog}
>  ...... It is also possible
>  that rpmlint gets this wrong, especially if the init script contains
>  nontrivial shell variables and/or assignments.  These cases usually manifest
>  themselves when rpmlint reports that the subsys name starts a with '$'; in
>  these cases a warning instead of an error is reported and you should check the
>  script manually.
>  
>  Init script is indeed using a variable. 
OK.


Before commit to git, please remove the patch comment from %description, where
it doesn't serve any purpose, and add a short description of Patch0 as above.

This package has been

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #14 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-28 16:44:35 EDT
---
Hi Jussi,

thanks a lot for reviewing the package. I have moved the patch description to
the right location. The update package is here

Spec URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.spec
SRPM URL: http://jhladky.fedorapeople.org/haveged-1.2-3.fc14.src.rpm

Cheers
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #15 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-28 16:56:59 EDT
---
New Package SCM Request
=======================
Package Name: haveged
Short Description:  A Linux entropy source using the HAVEGE algorithm. Feed
entropy into the random pool
Owners: Jirka Hladky
Branches: f15 f16 el6
InitialCC: jhladky

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #16 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-28 16:58:57 EDT
---
Errata:

New Package SCM Request
=======================
Package Name: haveged
Short Description:  A Linux entropy source using the HAVEGE algorithm. Feed
entropy into the random pool
Owners: jhladky
Branches: f15 f16 el6
InitialCC: jhladky

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #17 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2011-09-28 17:58:47 EDT
---
Actually, please change the description to
"A Linux entropy source using the HAVEGE algorithm".

I forgot to nag about this in the review..

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #18 from Jon Ciesla <limb(a)jcomserv.net&gt; 2011-09-28 21:00:43 EDT ---
Git done (by process-git-requests).

Edited description.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-09-29
20:21:32 EDT ---
haveged-1.2-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/haveged-1.2-3.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-09-29
20:23:42 EDT ---
haveged-1.2-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/haveged-1.2-3.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #21 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; 2011-09-29 20:26:07 EDT
---
Hi Jussi,

I have updated the package description.

@GIT TEAM: thanks a lot!

Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #22 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-09-29
22:48:00 EDT ---
haveged-1.2-3.fc16 has been pushed to the Fedora 16 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #23 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-11-05
17:25:04 EDT ---
haveged-1.3-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/haveged-1.3-1.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #24 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-11-05
17:34:32 EDT ---
haveged-1.3-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/haveged-1.3-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2012-09-26 06:56:39

--- Comment #25 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; ---
Odd that the update system hasn't closed this, even though the updates have hit
stable. Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jiri Hladky <hladky.jiri(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs+                 |
              Flags|                            |fedora-cvs?

--- Comment #26 from Jiri Hladky <hladky.jiri(a)gmail.com&gt; ---
Package Change Request
======================
Package Name: haveged
New Branches: el5
Owners: jhladky
InitialCC: jhladky

Requested by Jason Roysdon:

 Jirka,
Any chance you can add EL5 for your builds for haveged in EPEL?  I’d really
appreciate it.  We’ve a number of Oracle-based apps that are not yet certified
for EL6.

Thanks for your consideration,
Jason Roysdon
Information Security Analyst
Modesto Irrigation District
Ph: 209-557-1482

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=739347

--- Comment #27 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.