[Bug 1208381] New: Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects - package-review

List overview All Threads
Download

newer

[Bug 1208381] New: Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

older

[Bug 1301268] New: Review Request:...

[Bug 1310796] New: Review Request:...

Red Hat Bugzilla

2 Apr 2015 2 Apr '15

6:46 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Bug ID: 1208381 Summary: Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://gil.fedorapeople.org/gmavenplus-plugin.spec SRPM URL: https://gil.fedorapeople.org/gmavenplus-plugin-1.5-1.fc20.src.rpm Description: GMavenPlus is a rewrite of GMaven, a Maven plugin that allows you to integrate Groovy into your Maven projects. Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9394813

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

7 Aug 7 Aug

12:10 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1251207

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1251207 [Bug 1251207] logback-1.1.3 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Aug 14 Aug

11:48 a.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #1 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/gmavenplus-plugin.spec SRPM URL: https://gil.fedorapeople.org/gmavenplus-plugin-1.5-1.fc22.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10703206

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Nov 5 Nov

4:18 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #2 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/gmavenplus-plugin.spec SRPM URL: https://gil.fedorapeople.org/gmavenplus-plugin-1.5-1.fc23.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Mar 6 Mar

7:48 a.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #3 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- gil's scratch build of gmavenplus-plugin-1.5-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13249054

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:23 a.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Mukundan Ragavan nonamedotc@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:43 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #4 from Raphael Groner projects.rg@smart.ms --- Created attachment 1133532 --> https://bugzilla.redhat.com/attachment.cgi?id=1133532&action=edit review.txt

LGTM, please approve

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:44 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #5 from Raphael Groner projects.rg@smart.ms --- Created attachment 1133533 --> https://bugzilla.redhat.com/attachment.cgi?id=1133533&action=edit licensecheck.txt

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:40 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #6 from gil cattaneo puntogil@libero.it --- [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 25 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1208381-gmavenplus-plugin/licensecheck.txt => Some source files without license header, please validate. See also below.

Only one file: GMavenPlus-1.5/src/main/java/org/codehaus/gmavenplus/plexus/AbstractIncludeProjectDependenciesComponentConfigurator.java Open https://github.com/groovy/GMavenPlus/issues/50

[?]: Package contains no bundled libraries without FPC exception. => I assume the src/it and src/main folders only are relevant for built jar.

Only src/main/java the rest is not involved

[?]: Package functions as described. => OK, all provided and enabled tests pass. Can't tell about UAT.

Sorry, I don't understand the meaning of "UAT"

gmavenplus-plugin.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gmavenplus-plugin/README.markdown Fixed

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:26 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #7 from Raphael Groner projects.rg@smart.ms ---

...

Sorry, I don't understand the meaning of "UAT"

http://www.techopedia.com/definition/3887/user-acceptance-testing-uat http://www.softwaretestinghelp.com/what-is-user-acceptance-testing-uat etc.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:58 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #8 from Mukundan Ragavan nonamedotc@gmail.com --- Created attachment 1133565 --> https://bugzilla.redhat.com/attachment.cgi?id=1133565&action=edit build.log

Thanks Raphael for the excellent work!

---> review.txt as done by raphael looks fine by me. I do not have additional concerns.

---> license situation is addressed as such

---> tests are run and all seem to pass without issues.

---> build.log is attached. Everything seems fine there.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:01 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Mukundan Ragavan nonamedotc@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #9 from Mukundan Ragavan nonamedotc@gmail.com --- Everything looks fine to me. Package APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Mar 7 Mar

2:01 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/gmavenplus-plugin

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:19 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- gmavenplus-plugin-1.5-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b73e30bc77

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:19 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9 Mar 9 Mar

10:57 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- gmavenplus-plugin-1.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b73e30bc77

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Mar 17 Mar

8:52 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- gmavenplus-plugin-1.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:52 p.m.

New subject: [Bug 1208381] Review Request: gmavenplus-plugin - Integrates Groovy into Maven projects

https://bugzilla.redhat.com/show_bug.cgi?id=1208381

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3027

Age (days ago)

3377

Last active (days ago)

package-review@lists.fedoraproject.org

17 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla