[Bug 227077] New: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension
                    for performance and scalability testing
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.redhat.com/rafaels/specs/junitperf-1.9.1-2jpp.spec
SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/junitperf-1.9.1-2jpp.src.rpm
Description: JUnitPerf is a collection of JUnit test decorators used to measure the
performance and scalability of functionality contained within existing
JUnit tests.

Javadoc for junitperf.

Demonstrations and samples for junitperf.

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

------- Additional Comments From [e-mail]  2007-02-12 19:33 EST -------
- incorrect build root
- %{?dist} should be used
- remove javadoc %post and %postun sections

$ rpmlint /home/fitzsim/rpmbuild/SRPMS/junitperf-1.9.1-2jpp.src.rpm
W: junitperf non-standard-group Development/Testing
E: junitperf tag-not-utf8 %changelog
E: junitperf non-utf8-spec-file junitperf.spec
W: junitperf mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 89)

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-1.9.1-2jpp.noarch.rpm
W: junitperf non-standard-group Development/Testing
E: junitperf tag-not-utf8 %changelog

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-javadoc-1.9.1-2jpp.noarch.rpm
W: junitperf-javadoc non-standard-group Development/Documentation
E: junitperf-javadoc tag-not-utf8 %changelog
W: junitperf-javadoc dangerous-command-in-%post rm
W: junitperf-javadoc dangerous-command-in-%postun rm

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-demo-1.9.1-2jpp.noarch.rpm
W: junitperf-demo non-standard-group Development/Testing
E: junitperf-demo tag-not-utf8 %changelog
W: junitperf-demo no-documentation

- remove Vendor tag
- 80 characters per line

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

------- Additional Comments From [e-mail]  2007-02-15 17:18 EST -------
Fixed spec and srpm:

http://people.redhat.com/dbhole/fedora/junitperf/

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]           |[e-mail]

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]         |[e-mail]
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-02-16 16:31 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches
* skim the summary and description for typos, etc.
* correct buildroot
* %{?dist} is used properly
* license text included in package and marked with %doc
* packages meet FHS
* rpmlint on <this package>.srpm gives no output
$ rpmlint junitperf-1.9.1-2jpp.1.src.rpm
W: junitperf non-standard-group Development/Testing

This is fine.

* changelog fine
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* use License and not Copyright 
* Summary tag does not end in a period
* no PreReq
* specfile is legible
* package successfully compiles and builds on at least x86
* BuildRequires are proper
* summary should be a short and concise description of the package
* description expands upon summary
* make sure lines are <= 80 characters
  . the lines that aren't, I'm okay with
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* no config files
* not a GUI app
* no -devel sub-package
* macros used appropriately and consistently
* no locale data
* consider using cp -p to preserve timestamps
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions okay; %defattrs should be present
* %clean present
* %doc files do not affect runtime
* not a web apps
* verify the final provides and requires of the binary RPMs
* run rpmlint on the binary RPMs
$ rpmlint junitperf-*.noarch.rpm
W: junitperf non-standard-group Development/Testing
W: junitperf-demo non-standard-group Development/Testing
W: junitperf-demo no-documentation

These are all fine

SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
* package should build in mock

APPROVED

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

------- Additional Comments From [e-mail]  2007-03-06 10:48 EST -------
New Package CVS Request
=======================
Package Name: junitpref
Short Description: JUnit extension for performance and scalability testing
Owners: [e-mail]
Branches: devel
InitialCC:

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2007-03-06 17:03 EST -------
I seem to have made a typo in the above comment, it should have been "junitperf"
instead of "junitpref". Can I please get this renamed properly in cvs.

Thanks,

Matt Wringe

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-03-07 14:21 EST -------
corrected

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-03-07 15:40 EST -------
Build into plague. Marking as NEXTRELEASE

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |
              nThis|                            |

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=227077

Mat Booth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #8 from Mat Booth  2011-07-31 13:41:39 EDT ---
Package Change Request
======================
Package Name: junitperf
New Branches: el6
Owners: mbooth

[Bug 227077] Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=227077

--- Comment #9 from Jon Ciesla  2011-07-31 15:37:35 EDT ---
Git done (by process-git-requests).