[Bug 488359] New: Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: dcbd - daemon and configuration tool for data center bridging

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Summary: Review Request: dcbd - daemon and configuration tool
                    for data center bridging
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://people.redhat.com/agospoda/dcbd/dcbd.spec
SRPM URL: http://people.redhat.com/agospoda/dcbd/dcbd-0.9.7-1.fc10.src.rpm
Description:

This package contains the Linux user space daemon and configuration tool for
Intel Enhanced Ethernet for the Data Center software.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Dan Horák   2009-03-05 05:29:46 EDT ---
adding future maintainer to CC

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #2 from Dan Horák   2009-03-05 06:17:30 EDT ---
- upstream download page says that 0.9.4 is the latest version
(https://sourceforge.net/project/showfiles.php?group_id=42302) => check with
upstream
- wants to build with the included libconfig => BuildRequires: libconfig-devel
is missing, but then it fails to build on Rawhide due some undefined symbols
during linking
- are the headers alone in -devel subpackage (no library there) useful for any
development?

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Andy Gospodarek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail])

--- Comment #3 from Andy Gospodarek   2009-03-06 09:45:50 EDT ---
(In reply to comment #2)
> upstream download page says that 0.9.4 is the latest version
>
> (https://sourceforge.net/project/showfiles.php?group_id=42302) => check with
> upstream

I got this direct from Intel.  I can harass them to update the stuff on their
sourceforge page, but this is the latest.
> wants to build with the included libconfig => BuildRequires: libconfig-devel
>
> is missing, but then it fails to build on Rawhide due some undefined symbols
> during linking

Can you paste of attach the build failure message?  I was able to build and
install it just find on an f11 alpha system.
> are the headers alone in -devel subpackage (no library there) useful for any
>
> development?

They are useful for anyone who might want to write an app that builds on the
infrastructure in place and used by dcbtool/dcbd.  I think it could probably be
dropped though.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #4 from Jan Zeleny   2009-03-09 06:06:33 EDT ---
Created an attachment (id=334487)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=334487)
Build failure log

I'm attaching log of failed build. Build failed when I added libconfig-devel to
BuildRequires field. I'm currently trying to fix this, the fix should be
aviable soon.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?([e-mail])     |

--- Comment #5 from Dan Horák   2009-03-09 06:28:30 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > upstream download page says that 0.9.4 is the latest version
> >
> > (https://sourceforge.net/project/showfiles.php?group_id=42302) => check with
> > upstream
>
> I got this direct from Intel.  I can harass them to update the stuff on their
> sourceforge page, but this is the latest.

That's what I have expected :-) It's not a blocker, the source URL works, but
should be fixed.
> > wants to build with the included libconfig => BuildRequires: libconfig-devel
> >
> > is missing, but then it fails to build on Rawhide due some undefined symbols
> > during linking
>
> Can you paste of attach the build failure message?  I was able to build and
> install it just find on an f11 alpha system.

Did you have "libconfig-devel" installed?
> > are the headers alone in -devel subpackage (no library there) useful for any
> >
> > development?
>
> They are useful for anyone who might want to write an app that builds on the
> infrastructure in place and used by dcbtool/dcbd.  I think it could probably be
> dropped though.

OK

Jan should be already in contact with you, because he was designated as the
maintainer of dcbd package in the BaseOS Engineering.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #6 from Jan Zeleny   2009-03-09 11:43:35 EDT ---
Created an attachment (id=334548)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=334548)
Makefile.am patch - enable system libconfig

This patch adds support for libconfig shared in system.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #7 from Andy Gospodarek   2009-03-09 14:21:19 EDT ---
Sounds like this is under control -- that is good.  I did have libconfig-devel
installed since it probably got pulled into my f11 alpha system when I was
doing some other builds.

Thanks for taking care of this package, Jan!  :-)

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #8 from Jan Zeleny   2009-03-10 05:44:53 EDT ---
Updated package is aviable:
http://jzeleny.fedorapeople.org/packages/dcbd-0.9.7-1.fc10.src.rpm

Dan, could you please review it?

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #9 from Jan Zeleny   2009-03-10 09:42:04 EDT ---
Ok, after review and some fixes:
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/dcbd-0.9.7-2.fc10.src.rpm
Updated SPEC: http://jzeleny.fedorapeople.org/packages/dcbd-0.9.7-2.fc10.spec

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #10 from Dan Horák   2009-03-11 04:59:27 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     2f67e0c17ffef6fbc3de67234a6eb42cd281f449  dcbd-0.9.7.tar.gz
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- use plain dcbd.spec in the "Updated SPEC" URL
- rpmlint complains a bit:
dcbd.x86_64: W: service-default-enabled /etc/rc.d/init.d/dcbd
dcbd.x86_64: W: service-default-enabled /etc/rc.d/init.d/dcbd
    both in chkconfig and LSB sections
dcbd.x86_64: E: missing-mandatory-lsb-keyword Short-Description in
/etc/rc.d/init.d/dcbd
 => https://fedoraproject.org/wiki/Packaging/SysVInitScript

- non-standard dir (/etc/sysconfig/dcbd/) is used for application config files

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #11 from Jan Zeleny   2009-03-11 13:44:39 EDT ---
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/dcbd/dcbd-0.9.7-3.fc10.src.rpm
Updated SPEC: http://jzeleny.fedorapeople.org/packages/dcbd/dcbd.spec

All issues should be fixed now.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #12 from Dan Horák   2009-03-12 05:56:20 EDT ---
few issues still remain:
- the initscript scriptlets (%post/%preun/%postun) doesn't conform to
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscript_packaging
(redirection to /dev/null is missing and wrong comparison in %postun)
- rpmlint is not silent, because there are few typos in the initscript patch
dcbd.x86_64: E: unknown-lsb-keyword # Short-description: Data Center Bridging
Exchange protocol daemon
dcbd.x86_64: E: missing-mandatory-lsb-keyword Short-Description in
/etc/rc.d/init.d/dcbd
 => self-explained
dcbd.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/dcbd
 => your line is "chkconfig 20 80", but it must be "chkconfig - 20 80"

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #13 from Jan Zeleny   2009-03-13 08:30:03 EDT ---
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/dcbd/dcbd-0.9.7-3.fc10.src.rpm
Updated SPEC: http://jzeleny.fedorapeople.org/packages/dcbd/dcbd.spec

Tried it with rpmlint myself this time (with no output), so hopefully it's ok
now.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

--- Comment #14 from Jan Zeleny   2009-03-20 06:32:23 EDT ---
Hopefully final version:
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/dcbd/dcbd-0.9.7-4.fc10.src.rpm
Updated SPEC: http://jzeleny.fedorapeople.org/packages/dcbd/dcbd.spec

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #15 from Dan Horák   2009-03-20 06:44:18 EDT ---
All issues are fixed, this package is APPROVED.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Jan Zeleny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #16 from Jan Zeleny   2009-03-20 06:52:29 EDT ---
New Package CVS Request
=======================
Package Name: dcbd
Short Description: Daemon and configuration tool for
Intel Enhanced Ethernet for the Data Center software
Owners: jzeleny
Branches: 
InitialCC:

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Ronald Pacheco  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |488382

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #17 from Kevin Fenzi   2009-03-22 01:30:02 EDT ---
cvs done.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Jan Zeleny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #18 from Jan Zeleny   2009-03-23 09:26:11 EDT ---
Package has been uploaded to CVS, closing this bug.

[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488359

Ronald Pacheco  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|488382                      |